[GitHub] [kafka] lushilin commented on pull request #8535: KAFKA-9903

2020-04-24 Thread GitBox
lushilin commented on pull request #8535: URL: https://github.com/apache/kafka/pull/8535#issuecomment-619326049 ok,i will write test case and run unit test locally This is an automated message from the Apache Git Service. To

[GitHub] [kafka] cmccabe commented on pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-24 Thread GitBox
cmccabe commented on pull request #8527: URL: https://github.com/apache/kafka/pull/8527#issuecomment-619322065 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] abbccdda opened a new pull request #8549: KAFKA-9911: Add new PRODUCER_FENCED error code

2020-04-24 Thread GitBox
abbccdda opened a new pull request #8549: URL: https://github.com/apache/kafka/pull/8549 Add a separate error code as PRODUCER_FENCED to differentiate INVALID_PRODUCER_EPOCH. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Ve

[GitHub] [kafka] bseenu commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-04-24 Thread GitBox
bseenu commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-619310861 @ning2008wisc what happens in a situation where i have a single consumer group subscribing to multiple topics . Let's say we have two sites - Site A and Site B and three topics - t

[GitHub] [kafka] guozhangwang commented on pull request #8548: KAFKA-9823: Follow-up, check state for handling commit error response

2020-04-24 Thread GitBox
guozhangwang commented on pull request #8548: URL: https://github.com/apache/kafka/pull/8548#issuecomment-619308603 @ableegoldman @hachikuji This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] guozhangwang opened a new pull request #8548: KAFKA-9823: Follow-up, check state for handling commit error response

2020-04-24 Thread GitBox
guozhangwang opened a new pull request #8548: URL: https://github.com/apache/kafka/pull/8548 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including up

[GitHub] [kafka] d8tltanc commented on pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-24 Thread GitBox
d8tltanc commented on pull request #8527: URL: https://github.com/apache/kafka/pull/8527#issuecomment-619308386 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] d8tltanc commented on a change in pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-24 Thread GitBox
d8tltanc commented on a change in pull request #8527: URL: https://github.com/apache/kafka/pull/8527#discussion_r414955081 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -293,13 +293,6 @@ class TopicCommandWithAdminClientTest ext

[GitHub] [kafka] d8tltanc commented on a change in pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-24 Thread GitBox
d8tltanc commented on a change in pull request #8527: URL: https://github.com/apache/kafka/pull/8527#discussion_r414952990 ## File path: core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandArgsTest.scala ## @@ -255,7 +225,7 @@ class ReassignPartitionsCommandArgsTest

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-24 Thread GitBox
ConcurrencyPractitioner commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619300992 @vvcephei Alright, got the test fixed. Turned out I made a change which had broken the test, just that I hadn't caught it until now. This PR should be good for rev

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-24 Thread GitBox
ConcurrencyPractitioner commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619299805 @vvcephei Alright, will get this one fixed. This is an automated message from the Apache Git Servi

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-24 Thread GitBox
vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619298410 This one seemed to fail consistently: org.apache.kafka.streams.integration.RestoreIntegrationTest.shouldRestoreStateFromSourceTopic -

[GitHub] [kafka] d8tltanc commented on a change in pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-24 Thread GitBox
d8tltanc commented on a change in pull request #8527: URL: https://github.com/apache/kafka/pull/8527#discussion_r414945297 ## File path: core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala ## @@ -227,8 +227,10 @@ class DeleteTopicTest extends ZooKeeperTestHarness {

[GitHub] [kafka] vvcephei commented on pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-24 Thread GitBox
vvcephei commented on pull request #8541: URL: https://github.com/apache/kafka/pull/8541#issuecomment-619298256 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Assigned] (KAFKA-5636) Add Sliding-Window support for Aggregations

2020-04-24 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-5636: -- Assignee: Sophie Blee-Goldman > Add Sliding-Window support for Aggregations >

[jira] [Assigned] (KAFKA-7497) Kafka Streams should support self-join on streams

2020-04-24 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-7497: -- Assignee: Sophie Blee-Goldman > Kafka Streams should support self-join on stre

[jira] [Commented] (KAFKA-9906) Is bytesSinceLastIndexEntry updated correctly in LogSegment.append()?

2020-04-24 Thread Xiang Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091976#comment-17091976 ] Xiang Zhang commented on KAFKA-9906: cc [~mjsax] > Is bytesSinceLastIndexEntry updat

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-24 Thread GitBox
ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414923007 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -327,15 +331,15 @@ private void prepareStreamThread(final Stre

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-24 Thread GitBox
ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414922504 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -327,15 +331,15 @@ private void prepareStreamThread(final Stre

[GitHub] [kafka] ableegoldman commented on a change in pull request #8445: KAFKA-9823: Remember the sent generation for the coordinator request

2020-04-24 Thread GitBox
ableegoldman commented on a change in pull request #8445: URL: https://github.com/apache/kafka/pull/8445#discussion_r414921746 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1209,9 +1227,18 @@ public void handle(

[GitHub] [kafka] guozhangwang opened a new pull request #8547: MINOR: Remove unused foreign-key join class

2020-04-24 Thread GitBox
guozhangwang opened a new pull request #8547: URL: https://github.com/apache/kafka/pull/8547 As titled ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (inc

[GitHub] [kafka] guozhangwang commented on pull request #8547: MINOR: Remove unused foreign-key join class

2020-04-24 Thread GitBox
guozhangwang commented on pull request #8547: URL: https://github.com/apache/kafka/pull/8547#issuecomment-619281593 @vvcephei for reviews. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] ableegoldman commented on a change in pull request #8445: KAFKA-9823: Remember the sent generation for the coordinator request

2020-04-24 Thread GitBox
ableegoldman commented on a change in pull request #8445: URL: https://github.com/apache/kafka/pull/8445#discussion_r414919285 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1209,9 +1227,18 @@ public void handle(

[jira] [Resolved] (KAFKA-9853) Improve performance of Log.fetchOffsetByTimestamp()

2020-04-24 Thread Eric Bolinger (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Bolinger resolved KAFKA-9853. -- Fix Version/s: 2.6.0 Reviewer: Ismael Juma Resolution: Implemented PR# 8474 pro

[GitHub] [kafka] vvcephei commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-24 Thread GitBox
vvcephei commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414916950 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -327,15 +331,15 @@ private void prepareStreamThread(final StreamTh

[GitHub] [kafka] vvcephei commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-24 Thread GitBox
vvcephei commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414916950 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -327,15 +331,15 @@ private void prepareStreamThread(final StreamTh

[GitHub] [kafka] ijuma commented on pull request #8364: MINOR: Partition is under reassignment when adding and removing

2020-04-24 Thread GitBox
ijuma commented on pull request #8364: URL: https://github.com/apache/kafka/pull/8364#issuecomment-619277155 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] ijuma commented on pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-24 Thread GitBox
ijuma commented on pull request #8467: URL: https://github.com/apache/kafka/pull/8467#issuecomment-619277197 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Comment Edited] (KAFKA-9916) Materialize Table-Table Join Result to Avoid Performing Same Join Twice

2020-04-24 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091963#comment-17091963 ] Guozhang Wang edited comment on KAFKA-9916 at 4/24/20, 11:15 PM: --

[GitHub] [kafka] guozhangwang commented on a change in pull request #8445: KAFKA-9823: Remember the sent generation for the coordinator request

2020-04-24 Thread GitBox
guozhangwang commented on a change in pull request #8445: URL: https://github.com/apache/kafka/pull/8445#discussion_r414912275 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1209,9 +1227,18 @@ public void handle(

[GitHub] [kafka] guozhangwang commented on pull request #8535: KAFKA-9903

2020-04-24 Thread GitBox
guozhangwang commented on pull request #8535: URL: https://github.com/apache/kafka/pull/8535#issuecomment-619273600 Also could you run the unit test suite locally (you can see `README.md` for instructions), the jenkins failures seem relevant. --

[GitHub] [kafka] guozhangwang commented on pull request #8535: KAFKA-9903

2020-04-24 Thread GitBox
guozhangwang commented on pull request #8535: URL: https://github.com/apache/kafka/pull/8535#issuecomment-619273287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Commented] (KAFKA-9916) Materialize Table-Table Join Result to Avoid Performing Same Join Twice

2020-04-24 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091963#comment-17091963 ] Guozhang Wang commented on KAFKA-9916: -- Thanks [~cadonna] for filing the JIRA! I'd l

[GitHub] [kafka] vvcephei commented on pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-24 Thread GitBox
vvcephei commented on pull request #8541: URL: https://github.com/apache/kafka/pull/8541#issuecomment-619268681 Looks like the Jenkins agents are all saturated. I'll try again later to give them some breathing room. This is

[GitHub] [kafka] vvcephei commented on pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-24 Thread GitBox
vvcephei commented on pull request #8541: URL: https://github.com/apache/kafka/pull/8541#issuecomment-619268082 Kicked off https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3916/ This is an automated message

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-24 Thread GitBox
vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414899203 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/LagFetchIntegrationTest.java ## @@ -147,6 +149,9 @@ private void shouldFetchLagsD

[GitHub] [kafka] ableegoldman commented on a change in pull request #8445: KAFKA-9823: Remember the sent generation for the coordinator request

2020-04-24 Thread GitBox
ableegoldman commented on a change in pull request #8445: URL: https://github.com/apache/kafka/pull/8445#discussion_r414900070 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1209,9 +1227,18 @@ public void handle(

[GitHub] [kafka] ableegoldman commented on a change in pull request #8445: KAFKA-9823: Remember the sent generation for the coordinator request

2020-04-24 Thread GitBox
ableegoldman commented on a change in pull request #8445: URL: https://github.com/apache/kafka/pull/8445#discussion_r414898776 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1209,9 +1227,18 @@ public void handle(

[GitHub] [kafka] vvcephei commented on a change in pull request #8546: MINOR: document how to escape json parameters to ducktape tests

2020-04-24 Thread GitBox
vvcephei commented on a change in pull request #8546: URL: https://github.com/apache/kafka/pull/8546#discussion_r414897161 ## File path: tests/README.md ## @@ -36,6 +36,10 @@ TC_PATHS="tests/kafkatest/tests/client/pluggable_test.py::PluggableConsumerTest" ``` TC_PATHS="test

[GitHub] [kafka] ijuma commented on pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-24 Thread GitBox
ijuma commented on pull request #8467: URL: https://github.com/apache/kafka/pull/8467#issuecomment-619262770 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] ijuma commented on pull request #8364: MINOR: Partition is under reassignment when adding and removing

2020-04-24 Thread GitBox
ijuma commented on pull request #8364: URL: https://github.com/apache/kafka/pull/8364#issuecomment-619262854 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] ijuma commented on pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-24 Thread GitBox
ijuma commented on pull request #8467: URL: https://github.com/apache/kafka/pull/8467#issuecomment-619262713 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] ijuma commented on pull request #8364: MINOR: Partition is under reassignment when adding and removing

2020-04-24 Thread GitBox
ijuma commented on pull request #8364: URL: https://github.com/apache/kafka/pull/8364#issuecomment-619262139 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] bseenu commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-04-24 Thread GitBox
bseenu commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-619260911 Sorry false alarm, my consumer was having enable.auto.commit set to false , it started working after i made it true. Thanks --

[GitHub] [kafka] jsancio commented on pull request #8364: MINOR: Partition is under reassignment when adding and removing

2020-04-24 Thread GitBox
jsancio commented on pull request #8364: URL: https://github.com/apache/kafka/pull/8364#issuecomment-619258391 Thanks for the review @ijuma This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] jsancio commented on a change in pull request #8364: MINOR: Partition is under reassignment when adding and removing

2020-04-24 Thread GitBox
jsancio commented on a change in pull request #8364: URL: https://github.com/apache/kafka/pull/8364#discussion_r414889291 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithZKClientTest.scala ## @@ -31,7 +31,7 @@ import org.scalatest.Assertions.intercept imp

[GitHub] [kafka] jsancio commented on a change in pull request #8364: MINOR: Partition is under reassignment when adding and removing

2020-04-24 Thread GitBox
jsancio commented on a change in pull request #8364: URL: https://github.com/apache/kafka/pull/8364#discussion_r414888218 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala ## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache Software Foundation (ASF) unde

[jira] [Comment Edited] (KAFKA-9912) Kafka deletes full log on startup written 30mins ago - wrongly claims retention time 7d breach

2020-04-24 Thread Igor Baltiyskiy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091917#comment-17091917 ] Igor Baltiyskiy edited comment on KAFKA-9912 at 4/24/20, 9:39 PM: -

[jira] [Commented] (KAFKA-9912) Kafka deletes full log on startup written 30mins ago - wrongly claims retention time 7d breach

2020-04-24 Thread Igor Baltiyskiy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091917#comment-17091917 ] Igor Baltiyskiy commented on KAFKA-9912: I couldn't reproduce it, and now is bloc

[GitHub] [kafka] mjsax commented on a change in pull request #8546: MINOR: document how to escape json parameters to ducktape tests

2020-04-24 Thread GitBox
mjsax commented on a change in pull request #8546: URL: https://github.com/apache/kafka/pull/8546#discussion_r414878512 ## File path: tests/README.md ## @@ -36,6 +36,10 @@ TC_PATHS="tests/kafkatest/tests/client/pluggable_test.py::PluggableConsumerTest" ``` TC_PATHS="tests/k

[jira] [Updated] (KAFKA-9917) Consumer not assigned any partitions in group after broker restart

2020-04-24 Thread Igor Baltiyskiy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Baltiyskiy updated KAFKA-9917: --- Description: I've only reproduced it once for now, so I don't have a ready reproduction sequ

[jira] [Created] (KAFKA-9917) Consumer not assigned any partitions in group after broker restart

2020-04-24 Thread Igor Baltiyskiy (Jira)
Igor Baltiyskiy created KAFKA-9917: -- Summary: Consumer not assigned any partitions in group after broker restart Key: KAFKA-9917 URL: https://issues.apache.org/jira/browse/KAFKA-9917 Project: Kafka

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-24 Thread GitBox
vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619247286 On second thought, once the whitelist takes effect, it should just automatically run tests when you push. Maybe it'll only get picked up when you open a new PR? ---

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-24 Thread GitBox
vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619246848 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-24 Thread GitBox
vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619247014 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-24 Thread GitBox
vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619242033 Ah, congrats! In that case, try saying what I said before. This is an automated message from the Apache Gi

[GitHub] [kafka] vvcephei commented on pull request #8546: MINOR: document how to escape json parameters to ducktape tests

2020-04-24 Thread GitBox
vvcephei commented on pull request #8546: URL: https://github.com/apache/kafka/pull/8546#issuecomment-619238965 Getting the escaping right is surprisingly tricky, since the string gets evaluated by Bash, then wrapped in double-quotes to be passed into the Docker command, where it gets eval

[GitHub] [kafka] vvcephei opened a new pull request #8546: MINOR: document how to escape json parameters to ducktape tests

2020-04-24 Thread GitBox
vvcephei opened a new pull request #8546: URL: https://github.com/apache/kafka/pull/8546 * update the readme with an example of correctly escaped JSON to be passed as the parameters to a parameterized ducktape tests in docker ### Committer Checklist (excluded from commit message)

[jira] [Commented] (KAFKA-9450) Decouple inner state flushing from committing

2020-04-24 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091899#comment-17091899 ] Guozhang Wang commented on KAFKA-9450: -- We had some more discussion with [~desai.p.r

[GitHub] [kafka] d8tltanc commented on a change in pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-24 Thread GitBox
d8tltanc commented on a change in pull request #8527: URL: https://github.com/apache/kafka/pull/8527#discussion_r414844095 ## File path: core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala ## @@ -1408,13 +1408,23 @@ class DynamicBrokerReconfigur

[GitHub] [kafka] junrao commented on pull request #8542: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

2020-04-24 Thread GitBox
junrao commented on pull request #8542: URL: https://github.com/apache/kafka/pull/8542#issuecomment-619216927 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-24 Thread GitBox
ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414832679 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -327,15 +331,15 @@ private void prepareStreamThread(final Stre

[GitHub] [kafka] steverod commented on pull request #8543: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

2020-04-24 Thread GitBox
steverod commented on pull request #8543: URL: https://github.com/apache/kafka/pull/8543#issuecomment-619214390 > is this duplicate to #8542? Yes, this is aimed at 2.4 rather than 2.5. Took a best guess for propagation. ---

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-24 Thread GitBox
ConcurrencyPractitioner commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619213065 @vvcephei Can you retrigger tests? This is an automated message from the Apache Git Service. To r

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-24 Thread GitBox
ConcurrencyPractitioner commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619212877 @vvcephei Oh yeah, I was aware of that. Just recently though, I was added to the jenkins whitelist (my handle is listed in .asf.yaml). Supposedly, I will be able

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-24 Thread GitBox
ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414825387 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -883,6 +887,50 @@ public void statefulTopologyShouldCreateStat

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-24 Thread GitBox
ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414822929 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -701,18 +703,33 @@ private KafkaStreams(final InternalTopologyBuil

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-24 Thread GitBox
ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414823010 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -327,15 +331,15 @@ private void prepareStreamThread(final Stre

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-24 Thread GitBox
ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414822406 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -701,18 +703,33 @@ private KafkaStreams(final InternalTopologyBuil

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-24 Thread GitBox
ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414819765 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -883,6 +887,50 @@ public void statefulTopologyShouldCreateStat

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-24 Thread GitBox
vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619195143 FYI, a recent change is that only committers can kick off the tests. It's mighty inconvenient, but better for security. -

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-24 Thread GitBox
vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619194659 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-24 Thread GitBox
vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619194786 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Commented] (KAFKA-9913) TopologyDescription should expose all topic name progrematically

2020-04-24 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091804#comment-17091804 ] Boyang Chen commented on KAFKA-9913: I'm fine with combining the two tickets in one K

[GitHub] [kafka] guozhangwang commented on pull request #8535: KAFKA-9903

2020-04-24 Thread GitBox
guozhangwang commented on pull request #8535: URL: https://github.com/apache/kafka/pull/8535#issuecomment-619168284 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vvcephei commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-04-24 Thread GitBox
vvcephei commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r414731001 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java ## @@ -989,16 +994,18 @@ private void to(final TopicNameEx

[GitHub] [kafka] vvcephei commented on pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-24 Thread GitBox
vvcephei commented on pull request #8541: URL: https://github.com/apache/kafka/pull/8541#issuecomment-619162446 > > 29 system tests failed > > Expected, but still upsetting scream_cat I should have said "130 system tests passed" ---

[GitHub] [kafka] hachikuji commented on a change in pull request #8525: KAFKA-9885; Evict last members of a group when the maximum allowed is reached

2020-04-24 Thread GitBox
hachikuji commented on a change in pull request #8525: URL: https://github.com/apache/kafka/pull/8525#discussion_r414737521 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -124,6 +124,35 @@ class GroupCoordinator(val brokerId: Int, in

[GitHub] [kafka] ableegoldman commented on pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-24 Thread GitBox
ableegoldman commented on pull request #8541: URL: https://github.com/apache/kafka/pull/8541#issuecomment-619148319 > 29 system tests failed Expected, but still upsetting 🙀 This is an automated message from the Apache

[GitHub] [kafka] junrao commented on a change in pull request #8524: KAFKA-9866: Avoid election for topics where preferred leader is not in ISR

2020-04-24 Thread GitBox
junrao commented on a change in pull request #8524: URL: https://github.com/apache/kafka/pull/8524#discussion_r414740034 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1068,12 +1068,23 @@ class KafkaController(val config: KafkaConfig, v

[GitHub] [kafka] hachikuji commented on pull request #8525: KAFKA-9885; Evict last members of a group when the maximum allowed is reached

2020-04-24 Thread GitBox
hachikuji commented on pull request #8525: URL: https://github.com/apache/kafka/pull/8525#issuecomment-619142257 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] cadonna commented on pull request #8529: KAFKA-9901:Fix streams_broker_bounce_test error

2020-04-24 Thread GitBox
cadonna commented on pull request #8529: URL: https://github.com/apache/kafka/pull/8529#issuecomment-619140731 @jiameixie My PR was merged. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] mjsax commented on a change in pull request #8483: KAFKA-9865: Expose output topic names from TopologyTestDriver

2020-04-24 Thread GitBox
mjsax commented on a change in pull request #8483: URL: https://github.com/apache/kafka/pull/8483#discussion_r414732356 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -855,6 +856,20 @@ public void advanceWallClockTime(fina

[jira] [Created] (KAFKA-9916) Materialize Table-Table Join Result to Avoid Performing Same Join Twice

2020-04-24 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-9916: Summary: Materialize Table-Table Join Result to Avoid Performing Same Join Twice Key: KAFKA-9916 URL: https://issues.apache.org/jira/browse/KAFKA-9916 Project: Kafka

[GitHub] [kafka] vvcephei commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-04-24 Thread GitBox
vvcephei commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r414731001 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java ## @@ -989,16 +994,18 @@ private void to(final TopicNameEx

[jira] [Updated] (KAFKA-9526) Augment topology description with serdes

2020-04-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-9526: --- Description: Today we have multiple ways to infer and inherit serde along the topology, and

[jira] [Updated] (KAFKA-9913) TopologyDescription should expose all topic name progrematically

2020-04-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-9913: --- Description: During the discussion of KIP-594, it became clear that it is helpful for testin

[jira] [Updated] (KAFKA-9526) Augment topology description with serdes

2020-04-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-9526: --- Labels: kip (was: needs-kip) > Augment topology description with serdes > --

[jira] [Updated] (KAFKA-9913) TopologyDescription should expose all topic name progrematically

2020-04-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-9913: --- Labels: beginner kip newbie (was: beginner need-kip newbie) > TopologyDescription should exp

[jira] [Assigned] (KAFKA-9913) TopologyDescription should expose all topic name progrematically

2020-04-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-9913: -- Assignee: Guozhang Wang > TopologyDescription should expose all topic name progrematic

[jira] [Commented] (KAFKA-9913) TopologyDescription should expose all topic name progrematically

2020-04-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091751#comment-17091751 ] Matthias J. Sax commented on KAFKA-9913: Oh, I think you linked to the wrong KIP,

[jira] [Commented] (KAFKA-9913) TopologyDescription should expose all topic name progrematically

2020-04-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091740#comment-17091740 ] Matthias J. Sax commented on KAFKA-9913: Seems a little weird to mix two totally

[GitHub] [kafka] junrao commented on pull request #8543: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

2020-04-24 Thread GitBox
junrao commented on pull request #8543: URL: https://github.com/apache/kafka/pull/8543#issuecomment-619129858 @steverod : There seems to be compilation errors in JDK 8 test? This is an automated message from the Apache Git Se

[GitHub] [kafka] junrao commented on pull request #8543: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

2020-04-24 Thread GitBox
junrao commented on pull request #8543: URL: https://github.com/apache/kafka/pull/8543#issuecomment-619128544 @chia7712 : It's the same patch, but for a different branch. This is an automated message from the Apache Git Servi

[GitHub] [kafka] junrao commented on pull request #8542: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

2020-04-24 Thread GitBox
junrao commented on pull request #8542: URL: https://github.com/apache/kafka/pull/8542#issuecomment-619127117 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] junrao commented on a change in pull request #8103: KAFKA-7061: KIP-280 Enhanced log compaction

2020-04-24 Thread GitBox
junrao commented on a change in pull request #8103: URL: https://github.com/apache/kafka/pull/8103#discussion_r414175405 ## File path: core/src/main/scala/kafka/log/OffsetMap.scala ## @@ -20,28 +20,80 @@ package kafka.log import java.util.Arrays import java.security.MessageDi

[jira] [Commented] (KAFKA-9603) Number of open files keeps increasing in Streams application

2020-04-24 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091707#comment-17091707 ] Lovro Pandžić commented on KAFKA-9603: -- Small update: I've been able to reproduce th

[GitHub] [kafka] hachikuji commented on pull request #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

2020-04-24 Thread GitBox
hachikuji commented on pull request #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-619100794 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] hachikuji commented on pull request #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

2020-04-24 Thread GitBox
hachikuji commented on pull request #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-619100923 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mjsax commented on a change in pull request #8532: HOTFIX: Fix broker bounce system tests

2020-04-24 Thread GitBox
mjsax commented on a change in pull request #8532: URL: https://github.com/apache/kafka/pull/8532#discussion_r414679179 ## File path: tests/kafkatest/tests/streams/streams_broker_bounce_test.py ## @@ -164,7 +164,7 @@ def setup_system(self, start_processor=True, num_threads=3):

  1   2   >