Re: GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-22 Thread Idan Adar
The solution was to add "PR*" to the filter list. -- You received this message because you are subscribed to the Google Groups "Jenkins Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-users+unsubscr...@googlegroups.com. To view this dis

Re: GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-22 Thread Idan Adar
*Discover pull requests from origin*: Merging the pull request with the current target branch revision *Filter by name (with wildcards)*: develop master *Discover branches*: All branches I didn't set the "..forks" option because we don't work with forks. I have now changed "Discover branches" to

Re: GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-22 Thread Daniel Beck
> On 22. Sep 2017, at 12:18, Idan Adar wrote: > > > Checking pull request #215 > > Submitted from origin repository, skipping > > I have a repository and in this repository I have two branches: develop and > master. > I created another branch, "devops", from which I make a pull request to >

Re: GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-22 Thread Idan Adar
Why is it saying this? > Checking pull request #215 > Submitted from origin repository, skipping I have a repository and in this repository I have two branches: develop and master. I created another bra

Re: GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-22 Thread Idan Adar
Thanks Daniel. Now that jobs can run again, I'm back to the original topic of upgrading the plugins... I see that the job configuration looks different in multibranch pipelines and now PRs opened in GitHub are no longer automatically starting... On Friday, September 22, 2017 at 12:40:37 PM UTC

Re: GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-22 Thread Daniel Beck
> On 22. Sep 2017, at 11:33, Idan Adar wrote: > > credentials("${JENKINSBOT_USERNAME_PASSWORD}") This is equivalent to: credentials(JENKINSBOT_USERNAME_PASSWORD) -- You received this message because you are subscribed to the Google Groups "Jenkins Users" group. To unsubscribe from this grou

Re: GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-22 Thread Idan Adar
Okay, the problem was lines like this: JENKINSBOT = credentials('${JENKINSBOT_USERNAME_PASSWORD}') In v2.46 this worked. Once I upgraded to 2.73 I had to change it to: JENKINSBOT = credentials("${JENKINSBOT_USERNAME_PASSWORD}") -- You received this message because you are subscribed to the

Re: GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-22 Thread Idan Adar
And yes, I do have a backup from yesterday. If all fails I'll ask to restore to yesterday... -- You received this message because you are subscribed to the Google Groups "Jenkins Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-users+un

Re: GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-22 Thread Idan Adar
I've upgraded to 2.73.1 as well as to the latest plug-in releases. the stack trace is gone, however I now get this: org.jenkinsci.plugins.credentialsbinding.impl.CredentialNotFoundException: ${JENKINSBOT_USERNAME_PASSWORD} This, despite the credential ID and the global variable are all there and c

Re: GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-22 Thread Daniel Beck
> On 22. Sep 2017, at 09:45, Daniel Beck wrote: > > This is unrelated to GHBS, rather looks like a problem in Declarative > Pipeline. Possibly related to yesterday's release of version 1.2. Oops, didn't notice there were further responses. Sorry about that. -- You received this message becau

Re: GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-22 Thread Daniel Beck
> On 22. Sep 2017, at 07:48, Idan Adar wrote: > > which didn't help. This is unrelated to GHBS, rather looks like a problem in Declarative Pipeline. Possibly related to yesterday's release of version 1.2. -- You received this message because you are subscribed to the Google Groups "Jenkins

Re: GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-21 Thread Stephen Connolly
Reverting random plugins or downgrading without a corresponding backup to restore will not help you now, the data on disk has been rewritten, so whatever was affected has been affected. So if you don’t have a backup you’ll just have to double down and upgrade all the things... though i’d advise ba

Re: GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-21 Thread Stephen Connolly
Restore the backup you were warned to take, or move plugins forward until you pick up the downstream update required by the method change in some plugin. On Fri 22 Sep 2017 at 07:08, Idan Adar wrote: > I went back to version 1.1.8 (instead of 1.2) of pipeline model > definition, but that didn'

Re: GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-21 Thread Idan Adar
I went back to version 1.1.8 (instead of 1.2) of pipeline model definition, but that didn't help either... Stephen, what are my options here? On Friday, September 22, 2017 at 8:54:22 AM UTC+3, Stephen Connolly wrote: > > That stack trace is from a different plugin. > > Pipeline model definition.

Re: GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-21 Thread Stephen Connolly
That stack trace is from a different plugin. Pipeline model definition. Upgrading updated some other plugins, and *those* other plugins are causing the stack trace On Fri 22 Sep 2017 at 06:51, Idan Adar wrote: > The plug-in author is stephen connolly, but I'm not sure how to contact > him... >

Re: GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-21 Thread Idan Adar
The plug-in author is stephen connolly, but I'm not sure how to contact him... The plug-in release notes didn't mention info that could help me AFAICT. I'm not sure how to manually restore old settings and what those should be... Appreciate any help anyone could provide is this totally brings d

GitHub Branch Source Plugin - upgrade messed up jobs

2017-09-21 Thread Idan Adar
I had the unfortunate luck of upgrading said plug-in. Now any job fails with the error below. The upgrade warning does say: Warning: the new version of this plugin claims to use a different settings format than the installed version. Jobs using this plugin may need to be reconfigured, and/or you