Re: Modernize core dependency json-lib library

2024-04-11 Thread Basil Crow
On Wed, Apr 10, 2024 at 7:50 PM Bob Du wrote: > > Before that, I checked and compared the code and found that the fork > dependency version currently in use should have been built and released from > the rebase-2.4 branch, not master. I confirmed that by comparing the sources JAR on Artifactory

Re: Modernize core dependency json-lib library

2024-04-11 Thread Basil Crow
On Thu, Apr 11, 2024 at 6:31 AM 'Jesse Glick' via Jenkins Developers wrote: > > I think it is worse than that Note that I wrote "migrate core *and* plugins", which would mean creating a new method that returns a different type and adjusting consumers accordingly. If we were to upgrade to the late

Re: Modernize core dependency json-lib library

2024-04-11 Thread 'Jesse Glick' via Jenkins Developers
On Wed, Apr 10, 2024 at 6:27 PM Basil Crow wrote: > Even if we did want to migrate core and plugins to […] a different JSON > library […], we'd have to continue to support JSON-lib under the net.sf > package namespace during the transition period at the very least. > I think it is worse than tha

Re: Modernize core dependency json-lib library

2024-04-10 Thread Bob Du
Thanks basil, I agree with your idea. I will prepare another PR to modernize the CI system first. Before that, I checked and compared the code and found that the fork dependency version currently in use should have been built and released from the rebase-2.4 branch, not master. If you also con

Re: Modernize core dependency json-lib library

2024-04-10 Thread Basil Crow
Hey Bob, thank you for proposing this! Jenkins core delivers JSON-lib under the net.sf package namespace, consumes it itself, and provides it to many consuming plugins. It looks like Andres Almiray is still maintaining JSON-lib and EZMorph over at https://github.com/kordamp/json-lib and https://gi

Modernize core dependency json-lib library

2024-04-10 Thread Bob Du
As part of the core dependencies, json-lib has not been updated for a decade and depends on an outdated version of commons-lang2. https://github.com/jenkinsci/jenkins/pull/8996#issuecomment-2033276342 I have created a Jira issue for the modernization of json-lib, which has been added to the Jira e