tzaeschke commented on PR #61:
URL: https://github.com/apache/db-jdo/pull/61#issuecomment-1407688135
I filed a ticket for the Datanucleus reference implementation:
https://github.com/datanucleus/datanucleus-api-jdo/issues/127
--
This is an automated message from the Apache Git Service.
To
sonarcloud[bot] commented on PR #68:
URL: https://github.com/apache/db-jdo/pull/68#issuecomment-1414114735
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #68:
URL: https://github.com/apache/db-jdo/pull/68#issuecomment-1414328038
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
mboapache merged PR #68:
URL: https://github.com/apache/db-jdo/pull/68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
tzaeschke opened a new pull request, #69:
URL: https://github.com/apache/db-jdo/pull/69
Remove code smells of type: nested try-catch.
See https://issues.apache.org/jira/browse/JDO-823.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
sonarcloud[bot] commented on PR #69:
URL: https://github.com/apache/db-jdo/pull/69#issuecomment-1450884853
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #69:
URL: https://github.com/apache/db-jdo/pull/69#issuecomment-1450889770
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
mboapache commented on PR #69:
URL: https://github.com/apache/db-jdo/pull/69#issuecomment-1454827446
The PR looks good, I just added a minor comment above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
sonarcloud[bot] commented on PR #70:
URL: https://github.com/apache/db-jdo/pull/70#issuecomment-1455192676
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #69:
URL: https://github.com/apache/db-jdo/pull/69#issuecomment-1462627621
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
mboapache merged PR #70:
URL: https://github.com/apache/db-jdo/pull/70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
tzaeschke merged PR #69:
URL: https://github.com/apache/db-jdo/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
sonarcloud[bot] commented on PR #71:
URL: https://github.com/apache/db-jdo/pull/71#issuecomment-1462682826
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
tzaeschke merged PR #71:
URL: https://github.com/apache/db-jdo/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
tzaeschke opened a new pull request, #72:
URL: https://github.com/apache/db-jdo/pull/72
Remove unused local variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
sonarcloud[bot] commented on PR #72:
URL: https://github.com/apache/db-jdo/pull/72#issuecomment-1490850995
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
sonarcloud[bot] commented on PR #72:
URL: https://github.com/apache/db-jdo/pull/72#issuecomment-1490859079
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality G
clr-apache opened a new pull request, #73:
URL: https://github.com/apache/db-jdo/pull/73
JDO-819 Fix code smells
Use "Arrays.copyOf", "Arrays.asList", "Collections.addAll" or
"System.arraycopy" instead.
--
This is an automated message from the Apache Git Service.
To respond to the mess
sonarcloud[bot] commented on PR #73:
URL: https://github.com/apache/db-jdo/pull/73#issuecomment-1493455267
Kudos, SonarCloud Quality Gate passed! [` and `printStackTrace(...)`.
To avoid duplication in the `printStackTrace()`, the nested exceptions are
no longer printed as part of the `toString()`.
sonarcloud[bot] commented on PR #75:
URL: https://github.com/apache/db-jdo/pull/75#issuecomment-1513918820
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jd
tobous opened a new pull request, #47:
URL: https://github.com/apache/db-jdo-site/pull/47
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
sonarcloud[bot] commented on PR #78:
URL: https://github.com/apache/db-jdo/pull/78#issuecomment-1575656329
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
tobous opened a new pull request, #79:
URL: https://github.com/apache/db-jdo/pull/79
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jd
sonarcloud[bot] commented on PR #79:
URL: https://github.com/apache/db-jdo/pull/79#issuecomment-1575670686
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #80:
URL: https://github.com/apache/db-jdo/pull/80#issuecomment-1611870703
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #82:
URL: https://github.com/apache/db-jdo/pull/82#issuecomment-1627466461
Kudos, SonarCloud Quality Gate passed! [`. Done.
- [ ] ~~Fix p
sonarcloud[bot] commented on PR #83:
URL: https://github.com/apache/db-jdo/pull/83#issuecomment-1628800957
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jd
sonarcloud[bot] commented on PR #84:
URL: https://github.com/apache/db-jdo/pull/84#issuecomment-1777490176
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1794402762
Kudos, SonarCloud Quality Gate passed! [ {
return
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1387168344
##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -140,37 +141,178 @@ private String getTrimmedPropertyValue(Properties props,
String key) {
return
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1387172217
##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -263,231 +396,261 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
}
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1387252360
##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -263,231 +396,261 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
}
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1387254461
##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -528,13 +693,14 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
sonarcloud[bot] commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1804648411
Kudos, SonarCloud Quality Gate passed! [
--
This is an au
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398237350
##
tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java:
##
@@ -35,29 +36,23 @@ public class IsDetached extends DetachTest {
private static final String A
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398237350
##
tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java:
##
@@ -35,29 +36,23 @@ public class IsDetached extends DetachTest {
private static final String A
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398241937
##
tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java:
##
@@ -35,29 +36,23 @@ public class IsDetached extends DetachTest {
private static final String A
mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398242075
##
tck/src/main/java/org/apache/jdo/tck/util/ResultSummary.java:
##
@@ -36,9 +37,14 @@ public class ResultSummary implements Serializable {
/** The name of the file to
mboapache commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817585647
1. About the test log output: this is what I have mentioned before, you
should print the output using more -R or less -R.
If we do not like this output, then we need to find a JUnit launc
sonarcloud[bot] commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817586768
Kudos, SonarCloud Quality Gate passed! [