Re: testing with system properties

2018-08-12 Thread Michael Sokolov
I ended up using SystemPropertiesInvariantRule to enforce the presence of cleanup in an @After method - I like the explicitness of that since, as you say I know what the property modification is that needs to be reset. Thanks again for the excellent tooling! On Fri, Aug 10, 2018 at 7:51 AM Michael

Re: testing with system properties

2018-08-10 Thread Michael Sokolov
OK thanks for the tips -- I'm glad to know this exists. On Fri, Aug 10, 2018 at 2:03 AM Dawid Weiss wrote: > Erick already pointed you at the "cleanup" rule. This is fairly > generic, but if you know > the properties being modified you should still clean them up in @After or > @AfterClass -- thi

Re: testing with system properties

2018-08-09 Thread Dawid Weiss
Erick already pointed you at the "cleanup" rule. This is fairly generic, but if you know the properties being modified you should still clean them up in @After or @AfterClass -- this is useful for other people to know that you're modifying them, if for nothing else. Randomized testing package has

Re: testing with system properties

2018-08-09 Thread Erick Erickson
See TestSolrXml.java for an example of: @Rule public TestRule solrTestRules = RuleChain.outerRule(new SystemPropertiesRestoreRule()); Best, Erick On Thu, Aug 9, 2018 at 2:33 PM, Michael Sokolov wrote: > I ran into a need to test some functionality that relies on system > properties. Writing the

testing with system properties

2018-08-09 Thread Michael Sokolov
I ran into a need to test some functionality that relies on system properties. Writing the test was error-prone because the properties persist across the jvm so if you set them in a test they leak across to other tests unless you are careful about @After methods. It occurred to me it would be nice