Re: TF in MoreLikeThis

2022-06-01 Thread Petko Minkov
Sorry for the delay, but better late than never :). I put up a PR here: https://github.com/apache/lucene/pull/940. --Petko On Fri, Apr 1, 2022 at 10:11 AM Petko Minkov wrote: > Yeah, I'll be happy to. I'll try to get a patch out soon. > > On Fri, Apr 1, 2022 at 9:31 AM Adrien Grand wrote: > >>

Re: TF in MoreLikeThis

2022-04-01 Thread Petko Minkov
Yeah, I'll be happy to. I'll try to get a patch out soon. On Fri, Apr 1, 2022 at 9:31 AM Adrien Grand wrote: > From a quick look, your suggestion of passing the term frequency to > TFIDFSimilarity#tf makes sense. > > Would you like to contribute this change? You can find contributing > guideline

Re: TF in MoreLikeThis

2022-04-01 Thread Adrien Grand
>From a quick look, your suggestion of passing the term frequency to TFIDFSimilarity#tf makes sense. Would you like to contribute this change? You can find contributing guidelines here: https://github.com/apache/lucene/blob/main/CONTRIBUTING.md. On Thu, Mar 31, 2022 at 11:46 PM Petko Minkov wrot

TF in MoreLikeThis

2022-03-31 Thread Petko Minkov
Hi, I was looking at Lucene's code for MoreLikeThis, specifically this line: https://github.com/apache/lucene/blob/69b040fc6292ac47d7f7fc8bc3b7fd601794e54b/lucene/queries/src/java/org/apache/lucene/queries/mlt/MoreLikeThis.java#L640 It looks like in ClassicSimilarity, TF is a square root, but in