Re: Querying into a Collector visits documents multiple times

2021-09-24 Thread Michael Sokolov
Ah sorry never mind. Confused collector and collector manager On Fri, Sep 24, 2021, 6:51 AM Michael Sokolov wrote: > Separate issue, but this collector is not going to work with concurrent > search since the sum is not updated in a thread safe manner. Maybe you > don't care, since you don't use

Re: Querying into a Collector visits documents multiple times

2021-09-24 Thread Michael Sokolov
Separate issue, but this collector is not going to work with concurrent search since the sum is not updated in a thread safe manner. Maybe you don't care, since you don't use a thread pool to execute your queries, but you probably should! On Wed, Sep 22, 2021, 8:38 AM Adrien Grand wrote: > Hi St

Re: Querying into a Collector visits documents multiple times

2021-09-22 Thread Adrien Grand
Hi Steven, This collector looks correct to me. Resetting the counter to 0 on the first segment is indeed not necessary. We have plenty of collectors that are very similar to this one and we never observed any double-counting issue. I would suspect an issue in the code that calls this collector. M