Re: Race condition between IndexWriter.commit and IndexWriter.close

2018-12-06 Thread Boris Petrov
I just started doing that and noticed that in "close"'s documentation it says: NOTE: You must ensure no other threads are still making changes at the same time that this method is invoked. Which I guess is what I've missed and should be enough. Thanks for the support! :) On 12/5/18 12:52 PM, Mi

Re: Race condition between IndexWriter.commit and IndexWriter.close

2018-12-05 Thread Michael McCandless
Yeah I agree we should fix the javadocs to say that you should not try to close and commit concurrently from different threads. Wanna open a quick PR or issue with a patch? Thanks, Mike On Wed, Dec 5, 2018, 4:06 AM Boris Petrov So you're saying that this race-condition is OK? Nowhere in the >

Re: Race condition between IndexWriter.commit and IndexWriter.close

2018-12-05 Thread Boris Petrov
So you're saying that this race-condition is OK? Nowhere in the documentation does it say that these two calls should be synchronized... at least that must be fixed. :) On 12/1/18 6:25 PM, Michael McCandless wrote: > I think if you call commit and close concurrently the results are undefined > and

Re: Race condition between IndexWriter.commit and IndexWriter.close

2018-12-01 Thread Michael McCandless
I think if you call commit and close concurrently the results are undefined and so this is acceptable. Mike On Thu, Nov 29, 2018 at 5:53 AM Boris Petrov wrote: > Hi all, > > We're getting the following exception: > > java.lang.IllegalStateException: cannot close: prepareCommit was already > cal

Race condition between IndexWriter.commit and IndexWriter.close

2018-11-29 Thread Boris Petrov
Hi all, We're getting the following exception: java.lang.IllegalStateException: cannot close: prepareCommit was already called with no corresponding call to commit     at org.apache.lucene.index.IndexWriter.shutdown(IndexWriter.java:1025)     at org.apache.lucene.index.IndexWriter.close(IndexWrit