Re: Questions about the new query parser framework

2010-05-03 Thread Daniel Noll
On Mon, May 3, 2010 at 15:11, Adriano Crestani wrote: > I actually never liked how QueryNode -> query string is done today, using > QueryNode.toQueryString(...) method. A QueryNode shouldn't be responsible > for converting itself back to the string format, because different > SyntaxParser(s) may c

Re: Questions about the new query parser framework

2010-05-02 Thread Adriano Crestani
Hi Daniel, 1. Is it intentional that query nodes do not implement equals()? I had rather a lot of overhead when writing unit tests due to being unable to use it - it's either (a) define a Matcher for every single QueryNode class, or (b) toString() it and perform some sanitisation (which is what

Questions about the new query parser framework

2010-05-02 Thread Daniel Noll
Hi all. I have been using the new query parser framework fairly heavily, although our use case is largely for *generating* queries rather than parsing them - the intermediate query nodes happened to be a very good model for doing this without all the usual nightmares of thinking about the escape s