Re: QueryParser, phrases and stopwords

2005-07-19 Thread Stephen Halsey
e of control", but if its likely to go into the new version soon I'll hold off and and download that. thanks a lot Stephen Halsey - Original Message - From: Erik Hatcher To: java-user@lucene.apache.org Sent: Thursday, June 16, 2005 7:55 PM Subject: Re: QueryParser, p

Re: QueryParser, phrases and stopwords

2005-06-16 Thread Mike Barry
Daniel Naber wrote: >On Thursday 16 June 2005 04:17, Erik Hatcher wrote: > > > >>So we could change StopFilter to put the gaps back in safely now, I >>think. >> >>Thoughts? >> >> > >I personally don't have a problem with this, but shouldn't such a change be >optional? Like a parameter for

Re: QueryParser, phrases and stopwords

2005-06-16 Thread Erik Hatcher
On Jun 16, 2005, at 2:03 PM, Daniel Naber wrote: On Thursday 16 June 2005 04:17, Erik Hatcher wrote: So we could change StopFilter to put the gaps back in safely now, I think. Thoughts? I personally don't have a problem with this, but shouldn't such a change be optional? Like a parame

Re: QueryParser, phrases and stopwords

2005-06-16 Thread Daniel Naber
On Thursday 16 June 2005 04:17, Erik Hatcher wrote: > So we could change StopFilter to put the gaps back in safely now, I   > think. > > Thoughts? I personally don't have a problem with this, but shouldn't such a change be optional? Like a parameter for StopFilter or a StopGapFilter? I'm sure t

Re: QueryParser, phrases and stopwords

2005-06-16 Thread Erik Hatcher
Are there any other issues or concerns with making this change to StopFilter? Should we make this change in 1.9? Or wait until after 2.0 is released? Mike - if you could create some test cases for this scenario and contribute your patch and tests to Bugzilla, barring no objections, I'll

Re: QueryParser, phrases and stopwords

2005-06-16 Thread Mike Barry
Erik, Thanks, I applied the changes found in version 150148 of StopFilter.java and they work great for me. I did remove the setting of position=1 before the return of the token since that seemed spurious to me. Here's a context diff of the current StopFilter.java and my changes: *** analysis/S

Re: QueryParser, phrases and stopwords

2005-06-15 Thread Erik Hatcher
On Jun 15, 2005, at 12:12 PM, Mike Barry wrote: I have a situation where a query such as "climate control" is returning documents with the phrase "climate of control". (I'm using QueryParser). After searching, I found the similar issue on the mailing list from Greg Robertson with a patch

QueryParser, phrases and stopwords

2005-06-15 Thread Mike Barry
I have a situation where a query such as "climate control" is returning documents with the phrase "climate of control". (I'm using QueryParser). After searching, I found the similar issue on the mailing list from Greg Robertson with a patch from Steve Rowe. Looking at the source repository for