Re: Race condition between IndexWriter.commit and IndexWriter.close

2018-12-05 Thread Michael McCandless
Yeah I agree we should fix the javadocs to say that you should not try to close and commit concurrently from different threads. Wanna open a quick PR or issue with a patch? Thanks, Mike On Wed, Dec 5, 2018, 4:06 AM Boris Petrov So you're saying that this race-condition is OK? Nowhere in the >

Re: Race condition between IndexWriter.commit and IndexWriter.close

2018-12-05 Thread Boris Petrov
So you're saying that this race-condition is OK? Nowhere in the documentation does it say that these two calls should be synchronized... at least that must be fixed. :) On 12/1/18 6:25 PM, Michael McCandless wrote: > I think if you call commit and close concurrently the results are undefined > and