[jira] [Commented] (SOLR-16167) Review static initializers that reference subclasses

2022-04-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527567#comment-17527567 ] Dawid Weiss commented on SOLR-16167: I've no idea if this can be statically deduced o

[jira] [Created] (SOLR-16225) Upgrade dependencies (Carrot2, HPPC)

2022-05-31 Thread Dawid Weiss (Jira)
Dawid Weiss created SOLR-16225: -- Summary: Upgrade dependencies (Carrot2, HPPC) Key: SOLR-16225 URL: https://issues.apache.org/jira/browse/SOLR-16225 Project: Solr Issue Type: Improvement S

[jira] [Updated] (SOLR-16225) Upgrade dependencies (Carrot2, HPPC)

2022-05-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-16225: --- Description: PR is here: https://github.com/apache/solr/pull/884 > Upgrade dependencies (Carrot2, HP

[jira] [Updated] (SOLR-16225) Upgrade dependencies (Carrot2, HPPC)

2022-05-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-16225: --- Description: PR is here: https://github.com/apache/solr/pull/884 This issue upgrades Carrot2 and HPP

[jira] [Commented] (SOLR-16225) Upgrade dependencies (Carrot2, HPPC)

2022-05-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544729#comment-17544729 ] Dawid Weiss commented on SOLR-16225: I plant to commit shortly if there are no object

[jira] [Resolved] (SOLR-16225) Upgrade dependencies (Carrot2, HPPC)

2022-06-05 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved SOLR-16225. Fix Version/s: 9.1 Resolution: Fixed > Upgrade dependencies (Carrot2, HPPC) > --

[jira] [Updated] (SOLR-16225) Upgrade dependencies (Carrot2, HPPC)

2022-06-05 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-16225: --- Affects Version/s: (was: 9.1) > Upgrade dependencies (Carrot2, HPPC) > --

[jira] [Commented] (SOLR-16258) gradle should not normally use 'errorprone'

2022-06-24 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558669#comment-17558669 ] Dawid Weiss commented on SOLR-16258: Hi Chris. This looks good to me. > gradle shoul

[jira] [Commented] (SOLR-16322) Beast task does not print correct seeds

2022-08-03 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574899#comment-17574899 ] Dawid Weiss commented on SOLR-16322: Yep, beasting is a workaround implemented at gra

[jira] [Created] (SOLR-16351) Upgrade Carrot2 to 4.4.3, upgrade randomizedtesting to 2.8.0.

2022-08-23 Thread Dawid Weiss (Jira)
Dawid Weiss created SOLR-16351: -- Summary: Upgrade Carrot2 to 4.4.3, upgrade randomizedtesting to 2.8.0. Key: SOLR-16351 URL: https://issues.apache.org/jira/browse/SOLR-16351 Project: Solr Issue

[jira] [Updated] (SOLR-16351) Upgrade Carrot2 to 4.4.3, upgrade randomizedtesting to 2.8.0.

2022-08-23 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-16351: --- Description: PR at [https://github.com/apache/solr/pull/981.] It's a trivial change, I'll commit soo

[jira] [Updated] (SOLR-16351) Upgrade Carrot2 to 4.4.3, upgrade randomizedtesting to 2.8.0.

2022-08-23 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-16351: --- Description: PR at [https://github.com/apache/solr/pull/981.] PR 9x at: https://github.com/apache/so

[jira] [Commented] (SOLR-16187) ExecutorUtil#awaitTermination shouldn't wait forever

2022-08-24 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584128#comment-17584128 ] Dawid Weiss commented on SOLR-16187: Ideally, you'd want to wait for all threads of a

[jira] [Resolved] (SOLR-16351) Upgrade Carrot2 to 4.4.3, upgrade randomizedtesting to 2.8.0.

2022-08-24 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved SOLR-16351. Fix Version/s: 9.1 Resolution: Fixed > Upgrade Carrot2 to 4.4.3, upgrade randomizedtesting t

[jira] [Commented] (SOLR-15345) filter queries (fq) ignore the default query parser (defType)

2022-09-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598798#comment-17598798 ] Dawid Weiss commented on SOLR-15345: Cleaning up outstanding issues. I'm closing this

[jira] [Resolved] (SOLR-15345) filter queries (fq) ignore the default query parser (defType)

2022-09-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved SOLR-15345. Resolution: Won't Fix > filter queries (fq) ignore the default query parser (defType) > ---

[jira] [Created] (SOLR-16545) Upgrade Carrot2 to 4.5.0

2022-11-10 Thread Dawid Weiss (Jira)
Dawid Weiss created SOLR-16545: -- Summary: Upgrade Carrot2 to 4.5.0 Key: SOLR-16545 URL: https://issues.apache.org/jira/browse/SOLR-16545 Project: Solr Issue Type: Task Security Level: Publ

[jira] [Updated] (SOLR-16545) Upgrade Carrot2 to 4.5.0

2022-11-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-16545: --- Fix Version/s: 9.2 > Upgrade Carrot2 to 4.5.0 > > > Key: SOL

[jira] [Updated] (SOLR-16545) Upgrade Carrot2 to 4.5.0

2022-11-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-16545: --- Description: This is a trivial change upgrading Carrot2 clustering dependency to the latest release.

[jira] [Resolved] (SOLR-16545) Upgrade Carrot2 to 4.5.0

2022-11-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved SOLR-16545. Resolution: Fixed Since it's a trivial dependency upgrade, I allowed myself to commit this in with

[jira] [Commented] (SOLR-16641) Circular task dependency in gradle

2023-01-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682512#comment-17682512 ] Dawid Weiss commented on SOLR-16641: I'd recommend keeping localSettings as a task -

[jira] [Commented] (SOLR-16641) Circular task dependency in gradle

2023-01-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682589#comment-17682589 ] Dawid Weiss commented on SOLR-16641: Thanks for figuring it out. Moving this to gradl

[jira] [Commented] (SOLR-16641) Circular task dependency in gradle

2023-01-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682639#comment-17682639 ] Dawid Weiss commented on SOLR-16641: I think this looks good. The original motivation

[jira] [Commented] (SOLR-16916) JSON Query DSL doesn't work if defType isn't lucene

2023-12-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792123#comment-17792123 ] Dawid Weiss commented on SOLR-16916: I just hit this one and it seems like a regressi

[jira] [Commented] (SOLR-17057) JSON Query regression; defType doesn't work in "params"

2024-02-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822031#comment-17822031 ] Dawid Weiss commented on SOLR-17057: Thank you for fixing this, [~dsmiley]  > JSON Q

[jira] [Commented] (SOLR-11352) Automatic testing of all Solr examples

2024-03-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824098#comment-17824098 ] Dawid Weiss commented on SOLR-11352: What's BATS, Jan? :) > Automatic testing of all

[jira] [Commented] (SOLR-11352) Automatic testing of all Solr examples

2024-03-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824189#comment-17824189 ] Dawid Weiss commented on SOLR-11352: Have to take a look at that - interesting. Thank

[jira] [Commented] (SOLR-14497) Migrate to the Solr TLP

2021-03-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300074#comment-17300074 ] Dawid Weiss commented on SOLR-14497: Yes, thanks for taking most of it on your should

[jira] [Commented] (SOLR-15262) deal with "local" ref-guide link checking after lucene/solr repo split

2021-03-15 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301974#comment-17301974 ] Dawid Weiss commented on SOLR-15262: Hi Chris. Sorry I wasn't able to fix this myself

[jira] [Commented] (SOLR-15264) refactor ref-guide htmlLuceneJavadocs build variable to be based on lucene version from ivy properties

2021-03-15 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301975#comment-17301975 ] Dawid Weiss commented on SOLR-15264: See these relevant comments I left in the code:

[jira] [Commented] (SOLR-15265) decide if/how to validate lucene javadoc links

2021-03-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303176#comment-17303176 ] Dawid Weiss commented on SOLR-15265: bq. if lucene start publishing javadoc jars It'

[jira] [Commented] (SOLR-15265) decide if/how to validate lucene javadoc links

2021-03-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303959#comment-17303959 ] Dawid Weiss commented on SOLR-15265: Hi Chris. I added a PR showing how to fetch Luce

[jira] [Commented] (SOLR-15265) decide if/how to validate lucene javadoc links

2021-03-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17304489#comment-17304489 ] Dawid Weiss commented on SOLR-15265: Hi Chris. It's all quite simple... but not strai

[jira] [Commented] (SOLR-15178) Non-existent dependency listed in solr-core

2021-03-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17304680#comment-17304680 ] Dawid Weiss commented on SOLR-15178: I merged this in. If tests pass and validation p

[jira] [Resolved] (SOLR-15178) Non-existent dependency listed in solr-core

2021-03-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved SOLR-15178. Fix Version/s: main (9.0) Resolution: Fixed > Non-existent dependency listed in solr-core >

[jira] [Commented] (SOLR-15264) refactor ref-guide htmlLuceneJavadocs build variable to be based on lucene version from ivy properties

2021-03-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17304899#comment-17304899 ] Dawid Weiss commented on SOLR-15264: I did some digging myself; gradle now comes with

[jira] [Commented] (SOLR-15264) refactor ref-guide htmlLuceneJavadocs build variable to be based on lucene version from ivy properties

2021-03-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17304903#comment-17304903 ] Dawid Weiss commented on SOLR-15264: https://github.com/apache/solr/pull/34 This is t

[jira] [Commented] (SOLR-15265) decide if/how to validate lucene javadoc links

2021-03-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305163#comment-17305163 ] Dawid Weiss commented on SOLR-15265: Thanks Chris. Improvements can come later, no wo

[jira] [Commented] (SOLR-15264) refactor ref-guide htmlLuceneJavadocs build variable to be based on lucene version from ivy properties

2021-03-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305164#comment-17305164 ] Dawid Weiss commented on SOLR-15264: Thanks! > refactor ref-guide htmlLuceneJavadocs

[jira] [Commented] (SOLR-15282) speed up precommit

2021-03-24 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307963#comment-17307963 ] Dawid Weiss commented on SOLR-15282: Please go ahead, Uwe! > speed up precommit > --

[jira] [Created] (SOLR-15289) Increase snapshot check frequency

2021-03-25 Thread Dawid Weiss (Jira)
Dawid Weiss created SOLR-15289: -- Summary: Increase snapshot check frequency Key: SOLR-15289 URL: https://issues.apache.org/jira/browse/SOLR-15289 Project: Solr Issue Type: Improvement Secu

[jira] [Created] (SOLR-15299) ECJ linting doesn't seem to work

2021-03-26 Thread Dawid Weiss (Jira)
Dawid Weiss created SOLR-15299: -- Summary: ECJ linting doesn't seem to work Key: SOLR-15299 URL: https://issues.apache.org/jira/browse/SOLR-15299 Project: Solr Issue Type: Bug Security Leve

[jira] [Resolved] (SOLR-15299) ECJ linting doesn't seem to work

2021-03-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved SOLR-15299. Fix Version/s: main (9.0) Resolution: Fixed Thanks [~hossman] > ECJ linting doesn't seem to

[jira] [Created] (SOLR-15302) Task ordering can be incorrect for gradlew clean [...]

2021-03-30 Thread Dawid Weiss (Jira)
Dawid Weiss created SOLR-15302: -- Summary: Task ordering can be incorrect for gradlew clean [...] Key: SOLR-15302 URL: https://issues.apache.org/jira/browse/SOLR-15302 Project: Solr Issue Type: B

[jira] [Assigned] (SOLR-15302) Task ordering can be incorrect for gradlew clean [...]

2021-03-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned SOLR-15302: -- Assignee: Dawid Weiss > Task ordering can be incorrect for gradlew clean [...] > -

[jira] [Resolved] (SOLR-15302) Task ordering can be incorrect for gradlew clean [...]

2021-03-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved SOLR-15302. Fix Version/s: main (9.0) Resolution: Fixed > Task ordering can be incorrect for gradlew cle

[jira] [Created] (SOLR-15345) filter queries (fq) ignore the default query parser (defType)

2021-04-15 Thread Dawid Weiss (Jira)
Dawid Weiss created SOLR-15345: -- Summary: filter queries (fq) ignore the default query parser (defType) Key: SOLR-15345 URL: https://issues.apache.org/jira/browse/SOLR-15345 Project: Solr Issue

[jira] [Commented] (SOLR-15345) filter queries (fq) ignore the default query parser (defType)

2021-04-16 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322684#comment-17322684 ] Dawid Weiss commented on SOLR-15345: In reality there are many users that are in betw

[jira] [Commented] (SOLR-15345) filter queries (fq) ignore the default query parser (defType)

2021-04-16 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322691#comment-17322691 ] Dawid Weiss commented on SOLR-15345: I like {{fq.defType}}. > filter queries (fq) ig

[jira] [Commented] (SOLR-15345) filter queries (fq) ignore the default query parser (defType)

2021-04-20 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325548#comment-17325548 ] Dawid Weiss commented on SOLR-15345: Thank you all for feedback. I filed a PR. I file

[jira] [Commented] (SOLR-15345) filter queries (fq) ignore the default query parser (defType)

2021-04-20 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325578#comment-17325578 ] Dawid Weiss commented on SOLR-15345: Can't get the tests to pass because of SOLR-1535

[jira] [Commented] (SOLR-15361) update gradle build to support gpg signing of tgz/zip distributions

2021-04-21 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326350#comment-17326350 ] Dawid Weiss commented on SOLR-15361: I think it's fine. I'm really not sure what the

[jira] [Commented] (SOLR-15361) update gradle build to support gpg signing of tgz/zip distributions

2021-04-21 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326835#comment-17326835 ] Dawid Weiss commented on SOLR-15361: I think what you did fulfils the need. It's a pi

[jira] [Updated] (SOLR-15361) update gradle build to support gpg signing of tgz/zip distributions

2021-04-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-15361: --- Attachment: SOLR-15361.patch > update gradle build to support gpg signing of tgz/zip distributions >

[jira] [Commented] (SOLR-15361) update gradle build to support gpg signing of tgz/zip distributions

2021-04-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327174#comment-17327174 ] Dawid Weiss commented on SOLR-15361: Gradle is code. The evaluation/ execution order

[jira] [Commented] (SOLR-15361) update gradle build to support gpg signing of tgz/zip distributions

2021-04-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329416#comment-17329416 ] Dawid Weiss commented on SOLR-15361: It's weird this task runs on jenkins? Does it at

[jira] [Commented] (SOLR-15361) update gradle build to support gpg signing of tgz/zip distributions

2021-04-23 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17330050#comment-17330050 ] Dawid Weiss commented on SOLR-15361: I don't think you attached the updated patch, Ch

[jira] [Commented] (SOLR-15361) update gradle build to support gpg signing of tgz/zip distributions

2021-04-23 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331070#comment-17331070 ] Dawid Weiss commented on SOLR-15361: There is something wrong about this patch, Chris

[jira] [Commented] (SOLR-15361) update gradle build to support gpg signing of tgz/zip distributions

2021-04-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331620#comment-17331620 ] Dawid Weiss commented on SOLR-15361: Sorry for the delay, I was away. > I guess i'm

[jira] [Commented] (SOLR-15361) update gradle build to support gpg signing of tgz/zip distributions

2021-04-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331622#comment-17331622 ] Dawid Weiss commented on SOLR-15361: > TL;DR: the order of the distributions block vs

[jira] [Commented] (SOLR-15361) update gradle build to support gpg signing of tgz/zip distributions

2021-04-27 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333002#comment-17333002 ] Dawid Weiss commented on SOLR-15361: I've ran it on Windows but had to use gpg and wi

[jira] [Commented] (SOLR-15361) update gradle build to support gpg signing of tgz/zip distributions

2021-04-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335197#comment-17335197 ] Dawid Weiss commented on SOLR-15361: Thanks Chris. > update gradle build to support

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-05-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344360#comment-17344360 ] Dawid Weiss commented on SOLR-14920: This is how it was done for Lucene - step by ste

[jira] [Commented] (SOLR-15420) Exception thrown during intensive batch partial updating and segment merging

2021-05-20 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348190#comment-17348190 ] Dawid Weiss commented on SOLR-15420: Hmmm... I think this is valid code - ByteBuffers

[jira] [Commented] (SOLR-15447) Reproduce with line inaccurate for class methods

2021-06-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355324#comment-17355324 ] Dawid Weiss commented on SOLR-15447: This is a synthetic name for anything that is cl

[jira] [Updated] (SOLR-15447) Reproduce with line inaccurate for class methods

2021-06-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-15447: --- Attachment: SOLR-15447.patch > Reproduce with line inaccurate for class methods > ---

[jira] [Commented] (SOLR-15447) Reproduce with line inaccurate for class methods

2021-06-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355519#comment-17355519 ] Dawid Weiss commented on SOLR-15447: It looks like something broke either in junit or

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-06-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357519#comment-17357519 ] Dawid Weiss commented on SOLR-14920: Hi Christine. Solr's repository still has roots

[jira] [Commented] (SOLR-15454) remove Lucene commits from .git-blame-ignore-revs

2021-06-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359049#comment-17359049 ] Dawid Weiss commented on SOLR-15454: I did express my opinion that it's no harm to le

[jira] [Commented] (SOLR-15465) Do not require LICENSE and NOTICE files for test-dependencies

2021-06-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360311#comment-17360311 ] Dawid Weiss commented on SOLR-15465: Well, maybe. But I like the consistency of havin

[jira] [Commented] (SOLR-15465) Do not require LICENSE and NOTICE files for test-dependencies

2021-06-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360332#comment-17360332 ] Dawid Weiss commented on SOLR-15465: Such a file will quickly go out of sync. Here yo

[jira] [Commented] (SOLR-15465) Do not require LICENSE and NOTICE files for test-dependencies

2021-06-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360664#comment-17360664 ] Dawid Weiss commented on SOLR-15465: I see what bothers you. I think what's needed

[jira] [Commented] (SOLR-15465) Do not require LICENSE and NOTICE files for test-dependencies

2021-06-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360697#comment-17360697 ] Dawid Weiss commented on SOLR-15465: It is clear which jars are test or compile/ runt

[jira] [Commented] (SOLR-15465) Do not require LICENSE and NOTICE files for test-dependencies

2021-06-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360730#comment-17360730 ] Dawid Weiss commented on SOLR-15465: bq. Removing the two test classpaths will make t

[jira] [Commented] (SOLR-15465) Do not require LICENSE and NOTICE files for test-dependencies

2021-06-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360761#comment-17360761 ] Dawid Weiss commented on SOLR-15465: Yep, the test-framework probably pulls in stuff.

[jira] [Commented] (SOLR-15465) Do not require LICENSE and NOTICE files for test-dependencies

2021-06-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360823#comment-17360823 ] Dawid Weiss commented on SOLR-15465: It's a published artifact so it's a non-test con

[jira] [Commented] (SOLR-14981) Remove search results clustering contrib from 8x

2021-12-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461954#comment-17461954 ] Dawid Weiss commented on SOLR-14981: The backport patch should also work with some tw

[jira] [Commented] (SOLR-15867) Port over build improvements from lucene

2021-12-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463745#comment-17463745 ] Dawid Weiss commented on SOLR-15867: Hi Jan. I don't have an outline, no - there have

[jira] [Commented] (SOLR-15867) Port over build improvements from lucene

2022-01-03 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468391#comment-17468391 ] Dawid Weiss commented on SOLR-15867: Hi Jan. Ack. I'll take a look later today. > Po

[jira] [Comment Edited] (SOLR-15912) Update Guava to 31.0.1

2022-01-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478986#comment-17478986 ] Dawid Weiss edited comment on SOLR-15912 at 1/19/22, 9:05 PM: -

[jira] [Commented] (SOLR-15912) Update Guava to 31.0.1

2022-01-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478986#comment-17478986 ] Dawid Weiss commented on SOLR-15912: > For some reason, gradle and consistent-version

[jira] [Commented] (SOLR-15912) Update Guava to 31.0.1

2022-01-20 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479170#comment-17479170 ] Dawid Weiss commented on SOLR-15912: That's one way to do it, right. The lesson taugh

[jira] [Commented] (SOLR-14660) Migrating HDFS into a module

2022-01-21 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480265#comment-17480265 ] Dawid Weiss commented on SOLR-14660: I am away this week and with limited access to t

[jira] [Commented] (SOLR-15984) Ensure all used dependencies are declared

2022-02-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488613#comment-17488613 ] Dawid Weiss commented on SOLR-15984: All these transitive dependencies are present in

[jira] [Commented] (SOLR-15984) Ensure all used dependencies are declared

2022-02-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488618#comment-17488618 ] Dawid Weiss commented on SOLR-15984: Also, check shouldn't pass when you add a new tr

[jira] [Commented] (SOLR-15972) Remove gradle-wrapper.jar from source

2022-02-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489304#comment-17489304 ] Dawid Weiss commented on SOLR-15972: > What's the harm in leaving it in the source re

[jira] [Commented] (SOLR-16043) HDFS tests - "Command processor" thread leak

2022-02-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496499#comment-17496499 ] Dawid Weiss commented on SOLR-16043: The framework by default detects all leaked thre

[jira] [Commented] (SOLR-16049) Upgrade to spotless 6.3.0

2022-02-24 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497520#comment-17497520 ] Dawid Weiss commented on SOLR-16049: I've seen this too - that's why I didn't upgrade

[jira] [Created] (SOLR-16059) FieldType.DefaultAnalyzer issues incorrect final offset (and has broken buffer read)

2022-02-25 Thread Dawid Weiss (Jira)
Dawid Weiss created SOLR-16059: -- Summary: FieldType.DefaultAnalyzer issues incorrect final offset (and has broken buffer read) Key: SOLR-16059 URL: https://issues.apache.org/jira/browse/SOLR-16059 Projec

[jira] [Updated] (SOLR-16059) FieldType.DefaultAnalyzer issues incorrect final offset (and has broken buffer read)

2022-02-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-16059: --- Description: FieldType.DefaultAnalyzer (used as a default in many field types) has a broken implement

[jira] [Assigned] (SOLR-16059) FieldType.DefaultAnalyzer issues incorrect final offset (and has broken buffer read)

2022-02-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned SOLR-16059: -- Assignee: Dawid Weiss > FieldType.DefaultAnalyzer issues incorrect final offset (and has broke

[jira] [Commented] (SOLR-16059) FieldType.DefaultAnalyzer issues incorrect final offset (and has broken buffer read)

2022-02-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498296#comment-17498296 ] Dawid Weiss commented on SOLR-16059: I left the PR at [https://github.com/apache/sol

[jira] [Resolved] (SOLR-16059) FieldType.DefaultAnalyzer issues incorrect final offset (and has broken buffer read)

2022-02-28 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved SOLR-16059. Fix Version/s: main (10.0) Resolution: Fixed > FieldType.DefaultAnalyzer issues incorrect fi

[jira] [Commented] (SOLR-15503) Record current number of warnings and fail the build if that number is exceeded

2021-06-28 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371092#comment-17371092 ] Dawid Weiss commented on SOLR-15503: Hi Mike. I think this should be implemented as a

[jira] [Commented] (SOLR-15428) Integrate the OpenJDK JMH micro benchmark framework for micro benchmarks and performance comparisons and investigation.

2021-08-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399245#comment-17399245 ] Dawid Weiss commented on SOLR-15428: > The plugin stuff was more about the Gradle bui

[jira] [Commented] (SOLR-15428) Integrate the OpenJDK JMH micro benchmark framework for micro benchmarks and performance comparisons and investigation.

2021-08-15 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399326#comment-17399326 ] Dawid Weiss commented on SOLR-15428: bq. I am not a fan of the central ./gradle/somet

[jira] [Created] (SOLR-15601) Remove blank rat exclusions and add proper licenses to certain files

2021-08-26 Thread Dawid Weiss (Jira)
Dawid Weiss created SOLR-15601: -- Summary: Remove blank rat exclusions and add proper licenses to certain files Key: SOLR-15601 URL: https://issues.apache.org/jira/browse/SOLR-15601 Project: Solr

[jira] [Created] (SOLR-15602) Upgrade gradle to 7.2

2021-08-26 Thread Dawid Weiss (Jira)
Dawid Weiss created SOLR-15602: -- Summary: Upgrade gradle to 7.2 Key: SOLR-15602 URL: https://issues.apache.org/jira/browse/SOLR-15602 Project: Solr Issue Type: Task Security Level: Public

[jira] [Resolved] (SOLR-15436) Gradle's RAT task has missing inputs, so it can't figure out when to run

2021-08-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved SOLR-15436. Fix Version/s: main (9.0) Resolution: Fixed > Gradle's RAT task has missing inputs, so it ca

[jira] [Assigned] (SOLR-15603) Activate Gradle build cache

2021-08-27 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned SOLR-15603: -- Assignee: Dawid Weiss > Activate Gradle build cache > --- > >

  1   2   >