Re: [PR] SOLR-17651: Make sure CLI unit tests don't call System.exit() [solr]

2025-03-12 Thread via GitHub
epugh commented on PR #3258: URL: https://github.com/apache/solr/pull/3258#issuecomment-2717436061 On and I really like > runtime context for outputs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (SOLR-17018) LTR queries producing out of memory issues

2025-03-12 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-17018: -- Fix Version/s: (was: 9.1.2) > LTR queries producing out of memory issues >

[jira] [Updated] (SOLR-17699) High Query Time in Solr When Using OR with frange in fq

2025-03-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17699: Affects Version/s: 9.0 > High Query Time in Solr When Using OR with frange in fq >

[jira] [Commented] (SOLR-17699) High Query Time in Solr When Using OR with frange in fq

2025-03-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934514#comment-17934514 ] David Smiley commented on SOLR-17699: - When you tried just the {{frange}} alone in a

[jira] [Resolved] (SOLR-17562) Unify v2 API streaming support

2025-03-12 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-17562. Fix Version/s: main (10.0) 9.9 Assignee: Jason Gerlowski

Re: [PR] SOLR-17651: Make sure CLI unit tests don't call System.exit() [solr]

2025-03-12 Thread via GitHub
madrob commented on PR #3258: URL: https://github.com/apache/solr/pull/3258#issuecomment-2718393886 Relevant is also how ZooKeeper handles this - https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/util/ServiceUtils.java -- This is an automa

Re: [PR] SOLR-17699: Fix frange perf regression when sub-clause [solr]

2025-03-12 Thread via GitHub
HoustonPutman commented on PR #3259: URL: https://github.com/apache/solr/pull/3259#issuecomment-2718977932 Nice, quick find. Are there other places this needs to be updated or is this a special case? -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] SOLR-17651: Make sure CLI unit tests don't call System.exit() [solr]

2025-03-12 Thread via GitHub
psalagnac commented on code in PR #3258: URL: https://github.com/apache/solr/pull/3258#discussion_r1992083719 ## solr/core/src/test/org/apache/solr/cli/PackageToolTest.java: ## @@ -94,7 +94,8 @@ private > T withBasicAuth(T req) { @Test public void testPackageTool() thro

Re: [PR] SOLR-17651: Make sure CLI unit tests don't call System.exit() [solr]

2025-03-12 Thread via GitHub
HoustonPutman commented on PR #3258: URL: https://github.com/apache/solr/pull/3258#issuecomment-2718214104 Yeah, this is great! Can we instead of having two implementations of the tests (for logging and system exit capture), have one that does both? -- This is an automated message from th

[PR] Allow disabling new UI module during builds [solr]

2025-03-12 Thread via GitHub
malliaridis opened a new pull request, #3261: URL: https://github.com/apache/solr/pull/3261 # Description The new UI module has shown some compatibilty challenges when it comes to building the project with less common operating systems like s390x or when running with alterantive JDKs

Re: [PR] Allow disabling new UI module during builds [solr]

2025-03-12 Thread via GitHub
dsmiley commented on code in PR #3261: URL: https://github.com/apache/solr/pull/3261#discussion_r1992200082 ## solr/webapp/build.gradle: ## @@ -97,6 +97,7 @@ task downloadBrowserify(type: NpmTask) { tasks.register("generateUiDevFiles") { description = "Generate new UI for de

Re: [PR] Allow disabling new UI module during builds [solr]

2025-03-12 Thread via GitHub
HoustonPutman commented on code in PR #3261: URL: https://github.com/apache/solr/pull/3261#discussion_r1992212672 ## settings.gradle: ## @@ -68,5 +67,11 @@ include "solr:distribution" include "solr:docker" include "solr:prometheus-exporter" +// Do not load the new UI module

Re: [PR] SOLR-17655: Mark ExternalFileField as deprecated [solr]

2025-03-12 Thread via GitHub
gerlowskija commented on code in PR #3257: URL: https://github.com/apache/solr/pull/3257#discussion_r1991544946 ## solr/solr-ref-guide/modules/indexing-guide/pages/external-files-processes.adoc: ## @@ -21,6 +21,12 @@ It can also consume a stream of tokens that have already unde

Re: [PR] SOLR-17655: Mark ExternalFileField as deprecated [solr]

2025-03-12 Thread via GitHub
epugh commented on code in PR #3257: URL: https://github.com/apache/solr/pull/3257#discussion_r1991550442 ## solr/solr-ref-guide/modules/indexing-guide/pages/external-files-processes.adoc: ## @@ -21,6 +21,12 @@ It can also consume a stream of tokens that have already undergone

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-03-12 Thread via GitHub
gerlowskija commented on code in PR #3238: URL: https://github.com/apache/solr/pull/3238#discussion_r1991496264 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -139,7 +137,8 @@ public CompletableFuture requestAsync(Req req) { Completab

[jira] [Commented] (SOLR-17699) High Query Time in Solr When Using OR with frange in fq

2025-03-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934523#comment-17934523 ] David Smiley commented on SOLR-17699: - If I had merged SOLR-14164 way back then we wo

[jira] [Updated] (SOLR-17699) High Query Time in Solr When Using OR with frange in fq

2025-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17699: -- Labels: pull-request-available (was: ) > High Query Time in Solr When Using OR with frange in 

[jira] [Created] (SOLR-17700) CoreContainer does not obtain a lock when unloading cores

2025-03-12 Thread Houston Putman (Jira)
Houston Putman created SOLR-17700: - Summary: CoreContainer does not obtain a lock when unloading cores Key: SOLR-17700 URL: https://issues.apache.org/jira/browse/SOLR-17700 Project: Solr Issu

[PR] SOLR-17700: Use core operation lock when unloading core [solr]

2025-03-12 Thread via GitHub
HoustonPutman opened a new pull request, #3260: URL: https://github.com/apache/solr/pull/3260 https://issues.apache.org/jira/browse/SOLR-17700 The tests seem to be happy with this change. `DeleteInactiveReplicaTest` failed before I added the non-locked private `unloadWithoutCoreOp()`

[jira] [Updated] (SOLR-17700) CoreContainer does not obtain a lock when unloading cores

2025-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17700: -- Labels: pull-request-available (was: ) > CoreContainer does not obtain a lock when unloading c

Re: [PR] Allow disabling new UI module during builds [solr]

2025-03-12 Thread via GitHub
malliaridis commented on code in PR #3261: URL: https://github.com/apache/solr/pull/3261#discussion_r1992217095 ## settings.gradle: ## @@ -68,5 +67,11 @@ include "solr:distribution" include "solr:docker" include "solr:prometheus-exporter" +// Do not load the new UI module if

Re: [PR] Allow disabling new UI module during builds [solr]

2025-03-12 Thread via GitHub
malliaridis commented on code in PR #3261: URL: https://github.com/apache/solr/pull/3261#discussion_r1992229936 ## solr/webapp/build.gradle: ## @@ -97,6 +97,7 @@ task downloadBrowserify(type: NpmTask) { tasks.register("generateUiDevFiles") { description = "Generate new UI fo

Re: [PR] Allow disabling new UI module during builds [solr]

2025-03-12 Thread via GitHub
malliaridis commented on PR #3261: URL: https://github.com/apache/solr/pull/3261#issuecomment-2719050964 > Could we also disable it by default in the OS/Arch values we know are unsupported, as well as the ALT JDK option? This can be done by checking the values set in `System.getPrope

Re: [PR] SOLR-17651: Make sure CLI unit tests don't call System.exit() [solr]

2025-03-12 Thread via GitHub
psalagnac commented on PR #3258: URL: https://github.com/apache/solr/pull/3258#issuecomment-2718756248 > Can we instead of having two implementations of the tests (for logging and system exit capture), have one that does both? This would make all tests capture the output even when not

[PR] Bump golang.org/x/net from 0.33.0 to 0.36.0 [solr-operator]

2025-03-12 Thread via GitHub
dependabot[bot] opened a new pull request, #765: URL: https://github.com/apache/solr-operator/pull/765 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.33.0 to 0.36.0. Commits https://github.com/golang/net/commit/85d1d54551b68719346cb9fec24b911da4e452a1";>85d1d54

Re: [PR] Fix flaky TestSchemaDesignerAPI [solr]

2025-03-12 Thread via GitHub
HoustonPutman commented on PR #3213: URL: https://github.com/apache/solr/pull/3213#issuecomment-2718647138 Ok @dsmiley I think I actually found the issue. I'm going to close this, and open another PR actually fixing the issue. https://issues.apache.org/jira/browse/SOLR-17700 -- This is

Re: [PR] SOLR-17699: Fix frange perf regression when sub-clause [solr]

2025-03-12 Thread via GitHub
dsmiley commented on PR #3259: URL: https://github.com/apache/solr/pull/3259#issuecomment-2719621474 Looking across all `ConstantScoreScorer` using a DISI, -- they are all fine because they are based on a docSet/bitSet so it's super fast to iterate. Only this one here wasn't. I'm very fam