bkysela opened a new pull request, #3252:
URL: https://github.com/apache/solr/pull/3252
Solr 9.8 start script `bin/solr` reads `SOLR_INCLUDE` environment variable
not `SOLR_ENV`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
dsmiley opened a new pull request, #3253:
URL: https://github.com/apache/solr/pull/3253
The use of a SolrClient didn't seem to make sense if the web server isn't
(necessarily) Solr. Seemed to be getting more in the way. There was some
double or even triple(?) JSON back & forth parsing / s
dsmiley commented on PR #3209:
URL: https://github.com/apache/solr/pull/3209#issuecomment-2712803895
Planning to merge in a couple days without further feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
dsmiley merged PR #3235:
URL: https://github.com/apache/solr/pull/3235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on code in PR #3248:
URL: https://github.com/apache/solr/pull/3248#discussion_r1987294113
##
solr/solrj/src/java/org/apache/solr/client/solrj/ResponseParser.java:
##
@@ -16,45 +16,31 @@
*/
package org.apache.solr.client.solrj;
+import java.io.IOException;
dsmiley commented on code in PR #3248:
URL: https://github.com/apache/solr/pull/3248#discussion_r1987289810
##
solr/core/src/test/org/apache/solr/handler/admin/ShowFileRequestHandlerTest.java:
##
@@ -100,18 +100,15 @@ public String getWriterType() {
}
@Ov
[
https://issues.apache.org/jira/browse/SOLR-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Salagnac resolved SOLR-17518.
Fix Version/s: 9.9
Resolution: Fixed
> Refactor out a XmlRequestWriter so that Reque
epugh merged PR #3246:
URL: https://github.com/apache/solr/pull/3246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on code in PR #3247:
URL: https://github.com/apache/solr/pull/3247#discussion_r1987164110
##
solr/core/src/java/org/apache/solr/cli/HealthcheckTool.java:
##
@@ -227,6 +250,20 @@ protected void runCloudTool(CloudSolrClient
cloudSolrClient, CommandLine cli) th
jkmuriithi commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1987458954
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +188,31 @@ public void setQueryParams(Set queryParams) {
this.queryParams = quer
HoustonPutman merged PR #3225:
URL: https://github.com/apache/solr/pull/3225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
[
https://issues.apache.org/jira/browse/SOLR-17510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934031#comment-17934031
]
David Smiley commented on SOLR-17510:
-
[~gus], responding to you months later but the
epugh commented on code in PR #3248:
URL: https://github.com/apache/solr/pull/3248#discussion_r1987149392
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/NoOpResponseParser.java:
##
Review Comment:
Not specific to your changes, but a bit of JavaDocs on why you woul
epugh commented on code in PR #3223:
URL: https://github.com/apache/solr/pull/3223#discussion_r1987194246
##
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##
@@ -96,7 +98,7 @@ public class AuthTool extends ToolBase {
.argName("FILE")
.required()
epugh commented on code in PR #3223:
URL: https://github.com/apache/solr/pull/3223#discussion_r1987200962
##
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##
@@ -75,8 +75,10 @@ public class AuthTool extends ToolBase {
.longOpt("solr-include-file")
.
dsmiley commented on code in PR #3248:
URL: https://github.com/apache/solr/pull/3248#discussion_r1987307957
##
solr/core/src/test/org/apache/solr/response/TestRawTransformer.java:
##
@@ -283,12 +283,7 @@ public void testJsonTransformer() throws Exception {
strResponse.c
mlbiscoc commented on code in PR #3249:
URL: https://github.com/apache/solr/pull/3249#discussion_r1987240404
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -230,43 +214,41 @@ private SimpleOrderedMap submitClusterStateRequest(
17 matches
Mail list logo
