Re: [PR] Simplify BinaryResponseWriter.getParsedResponse [solr]

2025-03-07 Thread via GitHub
dsmiley commented on PR #3243: URL: https://github.com/apache/solr/pull/3243#issuecomment-2707315246 Will merge Monday if no further feedback. Pretty simple change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (SOLR-17694) LeaderElector not able to parse node ID correctly when it has a leading dash

2025-03-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933496#comment-17933496 ] David Smiley commented on SOLR-17694: - I'm inclined to think Solr should reject such

Re: [PR] SOLR-17537: Manage ZK Compression through Curator [solr]

2025-03-07 Thread via GitHub
HoustonPutman commented on PR #2849: URL: https://github.com/apache/solr/pull/2849#issuecomment-2707275445 With the Curator Global Compression stuff merged, we should be good to go here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-03-07 Thread via GitHub
kotman12 commented on code in PR #3238: URL: https://github.com/apache/solr/pull/3238#discussion_r1985801827 ## solr/solrj/src/java/org/apache/solr/client/solrj/request/SolrPing.java: ## @@ -53,8 +53,9 @@ public ModifiableSolrParams getParams() { } @Override - public St

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-03-07 Thread via GitHub
kotman12 commented on code in PR #3238: URL: https://github.com/apache/solr/pull/3238#discussion_r1985801827 ## solr/solrj/src/java/org/apache/solr/client/solrj/request/SolrPing.java: ## @@ -53,8 +53,9 @@ public ModifiableSolrParams getParams() { } @Override - public St

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-03-07 Thread via GitHub
kotman12 commented on code in PR #3238: URL: https://github.com/apache/solr/pull/3238#discussion_r1985801827 ## solr/solrj/src/java/org/apache/solr/client/solrj/request/SolrPing.java: ## @@ -53,8 +53,9 @@ public ModifiableSolrParams getParams() { } @Override - public St

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-03-07 Thread via GitHub
sijuv commented on PR #2960: URL: https://github.com/apache/solr/pull/2960#issuecomment-2704572310 Updated the pr to ensure to not mess with the _terminatedEarly_ flag even though it is unused in the current implementation. I think this flag should be removed at some point in time. With thi

[jira] [Commented] (SOLR-17656) Add expert level option to allowe PULL replicas to go ACTIVE w/o RECOVERING

2025-03-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933474#comment-17933474 ] ASF subversion and git services commented on SOLR-17656: Commit b

Re: [PR] SOLR-17309: Enhance certificate based authentication plugin with flexible cert principal resolution [solr]

2025-03-07 Thread via GitHub
epugh commented on PR #3029: URL: https://github.com/apache/solr/pull/3029#issuecomment-2706209133 @laminelam thanks for the ping. I am going to take a look at the precommit error.. Can you check the tests as well? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] SOLR-17638 Some CLI errors not logged when starting prometheus exporter [solr]

2025-03-07 Thread via GitHub
epugh commented on PR #3236: URL: https://github.com/apache/solr/pull/3236#issuecomment-2706368232 Other than some precommit issues, this all looks good @stillalex, do you need anything from me to get this moved forward! I'm looking forward to getting through all the CLI issues ;-) --

Re: [PR] reproducer.. wt=phps incompatibility with /admin/luke still in doubts. .. [solr]

2025-03-07 Thread via GitHub
epugh commented on PR #2114: URL: https://github.com/apache/solr/pull/2114#issuecomment-2706377500 I think this can be closed since we no longer have a `wt=phps`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (SOLR-17691) Request for Patch for Solr 8.4 - Zookeeper Status Error ("For input string: 'null'")

2025-03-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933365#comment-17933365 ] Jan Høydahl commented on SOLR-17691: I can say that when building a 8.x release it is

[jira] [Updated] (SOLR-17693) Upgrade to Apache Curator 5.8.0

2025-03-07 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-17693: -- Summary: Upgrade to Apache Curator 5.8.0 (was: Upgrade to Apache Curator 3.8.0) > Upgrade to

Re: [PR] SOLR-17693: Update apache.curator to v5.8.0 [solr]

2025-03-07 Thread via GitHub
HoustonPutman merged PR #3245: URL: https://github.com/apache/solr/pull/3245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[jira] [Resolved] (SOLR-17693) Upgrade to Apache Curator 5.8.0

2025-03-07 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-17693. --- Fix Version/s: main (10.0) Assignee: Houston Putman Resolution: Done > Upgrad

[jira] [Updated] (SOLR-17693) Upgrade to Apache Curator 5.8.0

2025-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17693: -- Labels: pull-request-available (was: ) > Upgrade to Apache Curator 5.8.0 > ---

[jira] [Commented] (SOLR-17693) Upgrade to Apache Curator 5.8.0

2025-03-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933368#comment-17933368 ] ASF subversion and git services commented on SOLR-17693: Commit 8

[jira] [Commented] (SOLR-17438) releaseWizard: remove refs to people.apache.org/home.apache.org

2025-03-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933283#comment-17933283 ] ASF subversion and git services commented on SOLR-17438: Commit 4

Re: [PR] SOLR-17438 Resolve committer GPG key from other source [solr]

2025-03-07 Thread via GitHub
janhoy merged PR #3145: URL: https://github.com/apache/solr/pull/3145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17438) releaseWizard: remove refs to people.apache.org/home.apache.org

2025-03-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933288#comment-17933288 ] ASF subversion and git services commented on SOLR-17438: Commit 2

Re: [PR] SOLR-17638 Some CLI errors not logged when starting prometheus exporter [solr]

2025-03-07 Thread via GitHub
stillalex commented on PR #3236: URL: https://github.com/apache/solr/pull/3236#issuecomment-2706638595 keeping an eye on https://github.com/apache/solr/pull/3240/files to get some inspiration for this change. I added a similar `zkHost` lookup. unfortunately this module does not have access

[jira] [Resolved] (SOLR-17438) releaseWizard: remove refs to people.apache.org/home.apache.org

2025-03-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-17438. Resolution: Fixed Done in main and branch_9x. If the json file moves away from whimsy later, we'll

Re: [PR] SOLR-17309: Enhance certificate based authentication plugin with flexible cert principal resolution [solr]

2025-03-07 Thread via GitHub
epugh commented on PR #3029: URL: https://github.com/apache/solr/pull/3029#issuecomment-2706364784 @laminelam updating from main fixed things. Can you confirm the `security.hadoop` change? So in main we no longer have Hadoop, so I don't think it's needed. Is it required for backporting t

[jira] [Created] (SOLR-17693) Upgrade to Apache Curator 3.8.0

2025-03-07 Thread Houston Putman (Jira)
Houston Putman created SOLR-17693: - Summary: Upgrade to Apache Curator 3.8.0 Key: SOLR-17693 URL: https://issues.apache.org/jira/browse/SOLR-17693 Project: Solr Issue Type: Sub-task

Re: [PR] SOLR-17547: Collect ZK Metrics via Curator [solr]

2025-03-07 Thread via GitHub
HoustonPutman commented on PR #2850: URL: https://github.com/apache/solr/pull/2850#issuecomment-2707096925 So watch firing events are still not able to be monitored by zookeeper or Curator, so we will have to manage that on our own still using our watcher wrapper. This is probably something

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-03-07 Thread via GitHub
dsmiley commented on code in PR #3238: URL: https://github.com/apache/solr/pull/3238#discussion_r1985660911 ## solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java: ## @@ -210,6 +236,16 @@ public boolean requiresCollection() { return false; } + /** + *

[jira] [Created] (SOLR-17694) LeaderElector not able to parse node ID correctly when it has a leading dash

2025-03-07 Thread Patrick (Jira)
Patrick created SOLR-17694: -- Summary: LeaderElector not able to parse node ID correctly when it has a leading dash Key: SOLR-17694 URL: https://issues.apache.org/jira/browse/SOLR-17694 Project: Solr

[jira] [Commented] (SOLR-17656) Add expert level option to allowe PULL replicas to go ACTIVE w/o RECOVERING

2025-03-07 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933472#comment-17933472 ] Houston Putman commented on SOLR-17656: --- I think this inadvertently created a bug t

Re: [PR] SOLR-17537: Manage ZK Compression through Curator [solr]

2025-03-07 Thread via GitHub
HoustonPutman commented on PR #2849: URL: https://github.com/apache/solr/pull/2849#issuecomment-2707394159 Yeah, I'm not changing how the configuration is done, just how it's handled in the backend. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] SOLR-17547: Collect ZK Metrics via Curator [solr]

2025-03-07 Thread via GitHub
HoustonPutman commented on PR #2850: URL: https://github.com/apache/solr/pull/2850#issuecomment-2706991788 With Curator 5.8 released and now used in Solr, the issues mentioned should be fixed and this should be good to go! -- This is an automated message from the Apache Git Service. To re

Re: [PR] SOLR-17309: Enhance certificate based authentication plugin with flexible cert principal resolution [solr]

2025-03-07 Thread via GitHub
laminelam commented on PR #3029: URL: https://github.com/apache/solr/pull/3029#issuecomment-2707040472 > @laminelam updating from main fixed things. Can you confirm the `security.hadoop` change? So in main we no longer have Hadoop, so I don't think it's needed. Is it required for backportin

[jira] [Commented] (SOLR-17547) Collect ZK Metrics via Curator

2025-03-07 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933395#comment-17933395 ] Houston Putman commented on SOLR-17547: --- So watch firing events are still not able

Re: [PR] SimpleOrderedMap MapWriter constructor [solr]

2025-03-07 Thread via GitHub
dsmiley commented on PR #3235: URL: https://github.com/apache/solr/pull/3235#issuecomment-2707429514 Planning to merge Monday, backporting to 9x. Commit message will be similar to PR description, which is the first commit's message. -- This is an automated message from the Apache Git Ser

Re: [PR] SOLR-17688: Http2SolrClient: use Request.Listener not HttpListenerFactory [solr]

2025-03-07 Thread via GitHub
dsmiley commented on PR #3233: URL: https://github.com/apache/solr/pull/3233#issuecomment-2707447434 Planning to merge Tuesday. Beforehand will look closer at the errors that I did see, which seemed intermittent and unrelated. CHANGES.txt comment proposal in Other: > SolrJ: replaced H

[jira] [Commented] (SOLR-17656) Add expert level option to allowe PULL replicas to go ACTIVE w/o RECOVERING

2025-03-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933481#comment-17933481 ] ASF subversion and git services commented on SOLR-17656: Commit 0