Re: [PR] SOLR-8282: Switch CoreContainer#getSolrHome to return Path instead of String [solr]

2025-02-22 Thread via GitHub
dsmiley commented on PR #3204: URL: https://github.com/apache/solr/pull/3204#issuecomment-2676562570 Excellent! I love how focused this PR is. Can you please edit the JIRA association to be [SOLR-16903](https://issues.apache.org/jira/browse/SOLR-16903) -- PR title & CHANGES.txt. Th

[jira] [Closed] (SOLR-8282) Move Java APIs to NIO2 (Path), and ban use of java.io.File

2025-02-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley closed SOLR-8282. -- > Move Java APIs to NIO2 (Path), and ban use of java.io.File > -

Re: [PR] Feature/solr-17334 Minor bugs in Solr dedicated coordinator mode [solr]

2025-02-22 Thread via GitHub
github-actions[bot] commented on PR #2672: URL: https://github.com/apache/solr/pull/2672#issuecomment-2676457403 This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be fam

Re: [PR] Coordinator: remove SolrQueryRequest.getCloudDescriptor [solr]

2025-02-22 Thread via GitHub
github-actions[bot] commented on PR #2913: URL: https://github.com/apache/solr/pull/2913#issuecomment-2676457368 This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be fam

Re: [PR] SOLR-17518: Deprecate UpdateRequest.getXml() and replace it with XMLRequestWriter [solr]

2025-02-22 Thread via GitHub
dsmiley commented on code in PR #3200: URL: https://github.com/apache/solr/pull/3200#discussion_r1966671050 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/XMLRequestWriter.java: ## @@ -0,0 +1,216 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] SOLR-17518: Deprecate UpdateRequest.getXml() and replace it with XMLRequestWriter [solr]

2025-02-22 Thread via GitHub
dsmiley commented on code in PR #3200: URL: https://github.com/apache/solr/pull/3200#discussion_r198902 ## solr/solrj/src/java/org/apache/solr/client/solrj/request/UpdateRequest.java: ## @@ -368,147 +368,39 @@ public void setDeleteQuery(List deleteQuery) { //

[jira] [Commented] (SOLR-17670) Fix unnecessary memory allocation caused by a large reRankDocs param

2025-02-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929379#comment-17929379 ] ASF subversion and git services commented on SOLR-17670: Commit 1

Re: [PR] SOLR-17670: Fix unnecessary memory allocation caused by a large reRankDocs param [solr]

2025-02-22 Thread via GitHub
gaojiabao1991 commented on PR #3181: URL: https://github.com/apache/solr/pull/3181#issuecomment-2676365101 > I'll be merging this nice fix into 9.8.1 Thanks so much, David! -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] SOLR-17677: Ensure DBQ is safe before running [solr]

2025-02-22 Thread via GitHub
dsmiley commented on PR #3203: URL: https://github.com/apache/solr/pull/3203#issuecomment-2676413619 It is trivial to ensure HashRangeQuery doesn't NEED SolrIndexSearcher: #3206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] SOLR-17677: HashRangeQuery doesn't NEED SolrIndexSearcher [solr]

2025-02-22 Thread via GitHub
dsmiley opened a new pull request, #3206: URL: https://github.com/apache/solr/pull/3206 https://issues.apache.org/jira/browse/SOLR-17677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] SOLR-17631: Upgrade main to Lucene 10.x [solr]

2025-02-22 Thread via GitHub
janhoy commented on PR #3053: URL: https://github.com/apache/solr/pull/3053#issuecomment-2676269144 @chatman review feedback waiting :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] SOLR-17677: HashRangeQuery doesn't NEED SolrIndexSearcher [solr]

2025-02-22 Thread via GitHub
dsmiley commented on PR #3206: URL: https://github.com/apache/solr/pull/3206#issuecomment-2676422679 Tests pass (GHA for Crave is still out-of-commission) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] SOLR-17670: Fix unnecessary memory allocation caused by a large reRankDocs param [solr]

2025-02-22 Thread via GitHub
dsmiley commented on PR #3181: URL: https://github.com/apache/solr/pull/3181#issuecomment-2676315964 I'll be merging this nice fix into 9.8.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Commented] (SOLR-17670) Fix unnecessary memory allocation caused by a large reRankDocs param

2025-02-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929377#comment-17929377 ] ASF subversion and git services commented on SOLR-17670: Commit 7

Re: [PR] SOLR-17670: Fix unnecessary memory allocation caused by a large reRankDocs param [solr]

2025-02-22 Thread via GitHub
dsmiley merged PR #3181: URL: https://github.com/apache/solr/pull/3181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-17670) Fix unnecessary memory allocation caused by a large reRankDocs param

2025-02-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929380#comment-17929380 ] ASF subversion and git services commented on SOLR-17670: Commit 6

[jira] [Updated] (SOLR-17670) Fix unnecessary memory allocation caused by a large reRankDocs param

2025-02-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17670: Fix Version/s: 9.8.1 Resolution: Fixed Status: Resolved (was: Patch Available) T