Re: [I] Basic Auth Bootstrap Not Working In 0.9.0 [solr-operator]

2025-02-06 Thread via GitHub
ibraheemalayan commented on issue #755: URL: https://github.com/apache/solr-operator/issues/755#issuecomment-2639565683 ⭕️ UPDATE: I deleted the SolrCloud, recreated it with Solr `8.11.4` and it worked, then deleted that, and created with `9.6.1` and it also worked. So I deleted it a

[PR] Make PGP signing the release announcement optional [solr]

2025-02-06 Thread via GitHub
janhoy opened a new pull request, #3161: URL: https://github.com/apache/solr/pull/3161 As discussed in slack https://the-asf.slack.com/archives/CEKUCUNE9/p1738760259166169 I opted to keep the instructions in the wizard but clearly mark it as optional, skipping the S/MIME email client

[I] Basic Auth Bootstrap Not Working In 0.9.0 [solr-operator]

2025-02-06 Thread via GitHub
ibraheemalayan opened a new issue, #755: URL: https://github.com/apache/solr-operator/issues/755 Hi, I have a very simple SolrCloud config file as follows ```yaml # specs: https://apache.github.io/solr-operator/docs/solr-cloud/solr-cloud-crd.html apiVersion: solr.apache.org/v1be

Re: [PR] SOLR-17649: Fix Json faceting on multivalue number types [solr]

2025-02-06 Thread via GitHub
thomaswoeckinger commented on code in PR #3158: URL: https://github.com/apache/solr/pull/3158#discussion_r1944322475 ## solr/core/src/test/org/apache/solr/search/facet/TestJsonFacets.java: ## @@ -4907,6 +4907,38 @@ public void testQueryJoinBooksAndPages() throws Exception {

[jira] [Commented] (SOLR-17649) Multivalue facets on enum field type returns empty result when using JsonFacet API

2025-02-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924430#comment-17924430 ] Thomas Wöckinger commented on SOLR-17649: - > Might you surmise how this regressio

Re: [PR] SolrRequest.getParams never null; and clarify mutability [solr]

2025-02-06 Thread via GitHub
dsmiley commented on PR #3140: URL: https://github.com/apache/solr/pull/3140#issuecomment-2640800039 Planning on merging this tomorrow night. LMK if I should hold up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[PR] SOLR-17635: unmarshalling Map to SimpleOrderedMap if key i of type St… [solr]

2025-02-06 Thread via GitHub
renatoh opened a new pull request, #3163: URL: https://github.com/apache/solr/pull/3163 …ring https://issues.apache.org/jira/browse/SOLR-17635 # Description Please provide a short description of the changes you're making with this pull request. # Solut

[jira] [Updated] (SOLR-17635) javabin should deserialize maps as SimpleOrderedMap

2025-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17635: -- Labels: pull-request-available (was: ) > javabin should deserialize maps as SimpleOrderedMap >

Re: [PR] SOLR-17630 Add SolrCloudManager.getSolrClient [solr]

2025-02-06 Thread via GitHub
dsmiley commented on PR #3049: URL: https://github.com/apache/solr/pull/3049#issuecomment-2640821252 Needs a CHANGES.txt but it's otherwise ready. Planning to add in "Other": Added a node-wide CloudSolrClient to ZkController, and accessible via SolrCloudManager too. Uses Jetty HttpClien

Re: [PR] SolrParams.equals implementation [solr]

2025-02-06 Thread via GitHub
dsmiley commented on PR #3141: URL: https://github.com/apache/solr/pull/3141#issuecomment-2640802152 Planning on merging Saturday. No JIRA/CHANGES.txt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] SolrTestCaseJ4: don't reset HttpClient SSL stuff [solr]

2025-02-06 Thread via GitHub
dsmiley commented on PR #3037: URL: https://github.com/apache/solr/pull/3037#issuecomment-2640835751 Planning to merge tomorrow. Pretty straight-forward change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] SOLR-17614: cross-dc deletes can skip an HTTP hop [solr]

2025-02-06 Thread via GitHub
dsmiley commented on PR #2963: URL: https://github.com/apache/solr/pull/2963#issuecomment-2640852205 Needs a CHANGES.txt; perhaps in Optimizations. "Cross-DC delete-by-query optimized to fetch deleted documents with one less HTTP hop per batch of IDs". I plan to merge it this weekend aft

Re: [PR] SOLR-17654: DistribFileStore._getRealPath() has issues on Windows [solr]

2025-02-06 Thread via GitHub
dsmiley commented on PR #3160: URL: https://github.com/apache/solr/pull/3160#issuecomment-2640859643 Thanks Jan for that suggestion! I grabbed that and intend to play with it this weekend. I'll merge this PR shortly. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] SOLR-17635: unmarshalling Map to SimpleOrderedMap if key i of type St… [solr]

2025-02-06 Thread via GitHub
renatoh commented on code in PR #3163: URL: https://github.com/apache/solr/pull/3163#discussion_r1945462495 ## solr/solrj/src/java/org/apache/solr/common/util/JavaBinCodec.java: ## @@ -863,6 +868,26 @@ protected Map readMap(DataInputInputStream dis, int sz) throws I return

Re: [PR] EncryptionRequestHandler supports encryption requests distribution. [solr-sandbox]

2025-02-06 Thread via GitHub
bruno-roustant commented on code in PR #115: URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1944878207 ## encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java: ## @@ -260,12 +339,133 @@ public void handleRequestBody(SolrQueryRequest

[PR] fix the solr zk invocation [solr-operator]

2025-02-06 Thread via GitHub
elangelo opened a new pull request, #756: URL: https://github.com/apache/solr-operator/pull/756 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] SOLR-14115: Allow bin/solr zk commands to have parity with zkcli.sh commands. [solr]

2025-02-06 Thread via GitHub
elangelo commented on PR #2298: URL: https://github.com/apache/solr/pull/2298#issuecomment-2640038554 This PR doesn't work. When using the `solr zk` command you need to provide the `--zk-host $ZK_HOST` argument: https://github.com/apache/solr-operator/pull/756 -- This is an automated

Re: [PR] SOLR-16391: Convert create-core, core-status, /luke to JAX-RS [solr]

2025-02-06 Thread via GitHub
gerlowskija commented on code in PR #3054: URL: https://github.com/apache/solr/pull/3054#discussion_r1945281386 ## solr/core/src/java/org/apache/solr/cli/CLIUtils.java: ## @@ -321,16 +320,15 @@ public static boolean safeCheckCoreExists(String solrUrl, String coreName, Strin

Re: [PR] SOLR-17649: Fix Json faceting on multivalue number types [solr]

2025-02-06 Thread via GitHub
dsmiley commented on code in PR #3158: URL: https://github.com/apache/solr/pull/3158#discussion_r1945285244 ## solr/CHANGES.txt: ## @@ -187,6 +187,8 @@ Bug Fixes * SOLR-17652: Fix a bug that could cause long leader elections to leave PULL replicas in DOWN state forever. (hos

Re: [PR] Make PGP signing the release announcement optional [solr]

2025-02-06 Thread via GitHub
janhoy commented on PR #3161: URL: https://github.com/apache/solr/pull/3161#issuecomment-2640061049 > I'd rather just rip out the section, jsut because it's one more thing and no one uses it. But that's just me. The rest looks good. Though I have never been an RM ;-) Would it be bett

[PR] adding a script on how to calculated the encoded password format with… [solr]

2025-02-06 Thread via GitHub
elangelo opened a new pull request, #3162: URL: https://github.com/apache/solr/pull/3162 … bash https://issues.apache.org/jira/browse/SOLR-X # Description Adding a short bash script in the documentation that illustrates how to calculate the encoded passwo

Re: [PR] adding a script on how to calculated the encoded password format with… [solr]

2025-02-06 Thread via GitHub
epugh commented on code in PR #3162: URL: https://github.com/apache/solr/pull/3162#discussion_r1945053453 ## solr/solr-ref-guide/modules/deployment-guide/pages/basic-authentication-plugin.adoc: ## @@ -56,13 +56,42 @@ There are several options defined in this example: <1> The

Re: [PR] adding a script on how to calculated the encoded password format with… [solr]

2025-02-06 Thread via GitHub
epugh commented on code in PR #3162: URL: https://github.com/apache/solr/pull/3162#discussion_r1945053002 ## solr/solr-ref-guide/modules/deployment-guide/pages/basic-authentication-plugin.adoc: ## @@ -56,13 +56,42 @@ There are several options defined in this example: <1> The

Re: [PR] SOLR-17632: Text to Vector Update Request Processor [solr]

2025-02-06 Thread via GitHub
alessandrobenedetti commented on PR #3151: URL: https://github.com/apache/solr/pull/3151#issuecomment-2639773032 Added one iteration of polishing, should have addressed @cpoerschke concerns on vectorisation failures (I took inspiration from the lang detect update processor). I also r

Re: [PR] SOLR-17635: unmarshalling Map to SimpleOrderedMap if key i of type St… [solr]

2025-02-06 Thread via GitHub
renatoh commented on code in PR #3163: URL: https://github.com/apache/solr/pull/3163#discussion_r1946046611 ## solr/solrj/src/java/org/apache/solr/common/util/JavaBinCodec.java: ## @@ -863,6 +868,26 @@ protected Map readMap(DataInputInputStream dis, int sz) throws I return

[PR] SOLR-17628: Add query quantiles metrics to prometheus endpoint [solr]

2025-02-06 Thread via GitHub
jkmuriithi opened a new pull request, #3164: URL: https://github.com/apache/solr/pull/3164 https://issues.apache.org/jira/browse/SOLR-17628 # Description Modify the implementation of `SolrPrometheusFormatter.exportTimer` to export a Prometheus summary containing qua

[jira] [Updated] (SOLR-17628) Add query quantiles metrics to prometheus endpoint

2025-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17628: -- Labels: pull-request-available (was: ) > Add query quantiles metrics to prometheus endpoint >

[jira] [Commented] (SOLR-12224) there is no API to read collection properties

2025-02-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924724#comment-17924724 ] David Smiley commented on SOLR-12224: - Wasn't this resolved by SOLR-16390 ? > there

[jira] [Updated] (SOLR-17656) Add expert level option to allowe PULL replicas to go ACTIVE w/o RECOVERING

2025-02-06 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-17656: -- Attachment: SOLR-17656.patch Status: Open (was: Open) The attached patch imple

[jira] [Created] (SOLR-17656) Add expert level option to allowe PULL replicas to go ACTIVE w/o RECOVERING

2025-02-06 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-17656: - Summary: Add expert level option to allowe PULL replicas to go ACTIVE w/o RECOVERING Key: SOLR-17656 URL: https://issues.apache.org/jira/browse/SOLR-17656 P

[jira] [Commented] (SOLR-17654) DistribFileStore._getRealPath() has issues on Windows

2025-02-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924722#comment-17924722 ] ASF subversion and git services commented on SOLR-17654: Commit d

Re: [PR] SOLR-17654: DistribFileStore._getRealPath() has issues on Windows [solr]

2025-02-06 Thread via GitHub
dsmiley merged PR #3160: URL: https://github.com/apache/solr/pull/3160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-16390) Cosmetic improvements and migration to JAX-RS (v2 cluster and clusterprop APIs)

2025-02-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924758#comment-17924758 ] David Smiley commented on SOLR-16390: - CHANGES.txt references this issue under 9.8 (d

Re: [PR] SOLR-17635: unmarshalling Map to SimpleOrderedMap if key i of type St… [solr]

2025-02-06 Thread via GitHub
dsmiley commented on code in PR #3163: URL: https://github.com/apache/solr/pull/3163#discussion_r1945550364 ## solr/solrj/src/java/org/apache/solr/common/util/JavaBinCodec.java: ## @@ -863,6 +868,26 @@ protected Map readMap(DataInputInputStream dis, int sz) throws I return

Re: [PR] Make PGP signing the release announcement optional [solr]

2025-02-06 Thread via GitHub
epugh commented on PR #3161: URL: https://github.com/apache/solr/pull/3161#issuecomment-2640149555 Great! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [I] Basic Auth Bootstrap Not Working In 0.9.0 [solr-operator]

2025-02-06 Thread via GitHub
Calcagiara commented on issue #755: URL: https://github.com/apache/solr-operator/issues/755#issuecomment-2639800143 Hey there, having the same problem here. I will add that version 9.7.0 works fine with a fresh new deploy too, so I'm guessing it's an issue related specifically with the 9.8.

Re: [PR] SOLR-17649: Fix Json faceting on multivalue number types [solr]

2025-02-06 Thread via GitHub
dsmiley commented on code in PR #3158: URL: https://github.com/apache/solr/pull/3158#discussion_r1944771535 ## solr/core/src/java/org/apache/solr/search/facet/FacetField.java: ## @@ -152,7 +152,7 @@ public FacetProcessor createFacetProcessor(FacetContext fcontext) { }

[jira] [Commented] (SOLR-17635) javabin should deserialize maps as SimpleOrderedMap

2025-02-06 Thread Renato Haeberli (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924568#comment-17924568 ] Renato Haeberli commented on SOLR-17635: Ah right, my mind was still with the oth

Re: [PR] EncryptionRequestHandler supports encryption requests distribution. [solr-sandbox]

2025-02-06 Thread via GitHub
bruno-roustant commented on code in PR #115: URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1944751369 ## encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java: ## @@ -260,12 +330,116 @@ public void handleRequestBody(SolrQueryRequest

Re: [PR] SOLR-17632: Text to Vector Update Request Processor [solr]

2025-02-06 Thread via GitHub
dsmiley commented on code in PR #3151: URL: https://github.com/apache/solr/pull/3151#discussion_r194470 ## solr/modules/llm/src/java/org/apache/solr/llm/textvectorisation/update/processor/TextToVectorUpdateProcessorFactory.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the A

[jira] [Commented] (SOLR-17635) javabin should deserialize maps as SimpleOrderedMap

2025-02-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924571#comment-17924571 ] David Smiley commented on SOLR-17635: - Default to SimpleOrderedMap. > javabin should

Re: [PR] EncryptionRequestHandler supports encryption requests distribution. [solr-sandbox]

2025-02-06 Thread via GitHub
bruno-roustant commented on code in PR #115: URL: https://github.com/apache/solr-sandbox/pull/115#discussion_r1944888376 ## encryption/src/main/java/org/apache/solr/encryption/EncryptionRequestHandler.java: ## @@ -260,12 +339,133 @@ public void handleRequestBody(SolrQueryRequest

Re: [PR] Make PGP signing the release announcement optional [solr]

2025-02-06 Thread via GitHub
janhoy commented on PR #3161: URL: https://github.com/apache/solr/pull/3161#issuecomment-2640112351 Here is a proposal for how it will look without the detailed instructions, further downplaying PGP: ![Skjermbilde 2025-02-06 kl 16 14 38](https://github.com/user-attachments/assets/8cda35