Re: [PR] SOLR-17310: Configurable LeafSorter to customize segment search order [solr]

2025-02-02 Thread via GitHub
epugh commented on PR #2477: URL: https://github.com/apache/solr/pull/2477#issuecomment-2629393983 Seems like this ticket and https://github.com/apache/solr/pull/313 both have stalled out... Thoughts on a thread on the dev mailing list to see if we think moving forward with this or the #3

Re: [PR] SolrRequest.getParams never null; and clarify mutability [solr]

2025-02-02 Thread via GitHub
dsmiley commented on PR #3140: URL: https://github.com/apache/solr/pull/3140#issuecomment-2629459790 Not thinking a JIRA/CHANGES.txt is worth it but will do if asked. Proposed commit message: > Clarify getParams not null in SolrRequest, SolrQueryRequest, QParser > Clarify mutability

Re: [PR] SolrRequest.getParams never null; and clarify mutability [solr]

2025-02-02 Thread via GitHub
dsmiley commented on code in PR #3140: URL: https://github.com/apache/solr/pull/3140#discussion_r1938528244 ## solr/core/src/java/org/apache/solr/handler/api/V2ApiUtils.java: ## @@ -91,9 +91,6 @@ public static void squashIntoNamedListWithoutHeader( } public static String

Re: [PR] SOLR-17310: Configurable LeafSorter to customize segment search order [solr]

2025-02-02 Thread via GitHub
weiwang19 commented on PR #2477: URL: https://github.com/apache/solr/pull/2477#issuecomment-2629982518 Thanks for bringing this up. Would definitely like to have a discussion about moving this forward. Thanks, Wei On Sun, Feb 2, 2025 at 5:20 AM Eric Pugh ***@***.***> wrot

Re: [PR] SolrRequest.getParams never null; and clarify mutability [solr]

2025-02-02 Thread via GitHub
dsmiley commented on code in PR #3140: URL: https://github.com/apache/solr/pull/3140#discussion_r1938508213 ## solr/core/src/java/org/apache/solr/handler/api/V2ApiUtils.java: ## @@ -91,9 +91,6 @@ public static void squashIntoNamedListWithoutHeader( } public static String