Re: [I] Replica recovery fails after using Solr Encryption Plugin in multi-sharded Solr collection [solr-sandbox]

2025-01-22 Thread via GitHub
bruno-roustant commented on issue #114: URL: https://github.com/apache/solr-sandbox/issues/114#issuecomment-2606927844 Nice investigation @danielsason112.,this seems to be a good lead! It reminds me the file length complexity I had to solve when initially developing the EncryptionDire

[PR] SOLR-16391: Convert create-core, core-status, /luke to JAX-RS [solr]

2025-01-22 Thread via GitHub
gerlowskija opened a new pull request, #3054: URL: https://github.com/apache/solr/pull/3054 https://issues.apache.org/jira/browse/SOLR-16391 # Description Many v2 APIs remain on the legacy v2 API framework, including a number of APIs dealing with core CRUD and status-checking.

Re: [PR] SOLR-16391: Convert create-core, core-status, /luke to JAX-RS [solr]

2025-01-22 Thread via GitHub
gerlowskija commented on PR #3054: URL: https://github.com/apache/solr/pull/3054#issuecomment-2607074917 Still TODO: expand response POJOs usage in tests where appropriate, ref-guide updates for APIs, flag methods-needing-deprecation with PR comments. -- This is an automated message from

[PR] Remove unused 9.7.1 section in CHANGES.txt [solr]

2025-01-22 Thread via GitHub
janhoy opened a new pull request, #3055: URL: https://github.com/apache/solr/pull/3055 Unfortunately this also made it into the 9.8.0 release :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] SOLR-16391: Convert create-core, core-status, /luke to JAX-RS [solr]

2025-01-22 Thread via GitHub
epugh commented on PR #3054: URL: https://github.com/apache/solr/pull/3054#issuecomment-2607239877 As my 13 year old would say, [you are cookin](https://whitestationscroll.net/10380/opinion/are-you-cooked-or-cooking-a-brain-rot-guide/)! Out of curiosity, at this point, do you thin

[jira] [Updated] (SOLR-17631) Upgrade main to Lucene 10.x

2025-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17631: -- Labels: pull-request-available (was: ) > Upgrade main to Lucene 10.x > ---

Re: [PR] SOLR-16391: Convert create-core, core-status, /luke to JAX-RS [solr]

2025-01-22 Thread via GitHub
epugh commented on code in PR #3054: URL: https://github.com/apache/solr/pull/3054#discussion_r1925318212 ## solr/core/src/java/org/apache/solr/cli/CLIUtils.java: ## @@ -321,16 +320,15 @@ public static boolean safeCheckCoreExists(String solrUrl, String coreName, Strin

[jira] [Resolved] (SOLR-17500) Upgrade Lucene to 10.0.0 (on main)

2025-01-22 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya resolved SOLR-17500. - Resolution: Duplicate > Upgrade Lucene to 10.0.0 (on main) >

Re: [PR] SOLR-17631: Upgrade main to Lucene 10.x [solr]

2025-01-22 Thread via GitHub
chatman commented on PR #3053: URL: https://github.com/apache/solr/pull/3053#issuecomment-2607539742 I dealt with the removal of SortedSetDocValues.NO_MORE_ORDS [0] inaccurately in the PR. Will fix now. [0] - https://github.com/apache/lucene/pull/969 -- This is an automated message

[jira] [Commented] (SOLR-17631) Upgrade main to Lucene 10.x

2025-01-22 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916088#comment-17916088 ] Ishan Chattopadhyaya commented on SOLR-17631: - {quote}Please remember to sear

[jira] [Created] (SOLR-17632) Text to Vector Update Request Processor

2025-01-22 Thread Alessandro Benedetti (Jira)
Alessandro Benedetti created SOLR-17632: --- Summary: Text to Vector Update Request Processor Key: SOLR-17632 URL: https://issues.apache.org/jira/browse/SOLR-17632 Project: Solr Issue Type

[jira] [Commented] (SOLR-17619) Generate CHANGELOG.md (formerly CHANGES.txt) via logchange

2025-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916082#comment-17916082 ] Jan Høydahl commented on SOLR-17619: The 9.8.0 release conains an erraneous 9.7.1 sec

[jira] [Commented] (SOLR-17602) Maintain final JAR dependencies in source control to track changes

2025-01-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916083#comment-17916083 ] ASF subversion and git services commented on SOLR-17602: Commit 7

Re: [PR] SOLR-17602: Per-Module Dependency Locking [solr]

2025-01-22 Thread via GitHub
malliaridis merged PR #2925: URL: https://github.com/apache/solr/pull/2925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[jira] [Commented] (SOLR-17342) Comply with ASF website policy - external resources

2025-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916085#comment-17916085 ] Jan Høydahl commented on SOLR-17342: This will soon be enforced by ASF so we should p

[jira] [Commented] (SOLR-17631) Upgrade main to Lucene 10.x

2025-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915976#comment-17915976 ] Jan Høydahl commented on SOLR-17631: Duplicates SOLR-17500. Please remember to search

Re: [PR] SOLR-17519: CloudSolrClient with HTTP ClusterState can forget live nodes and then fail [solr]

2025-01-22 Thread via GitHub
mlbiscoc commented on code in PR #2935: URL: https://github.com/apache/solr/pull/2935#discussion_r1925380385 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java: ## @@ -387,6 +398,19 @@ public String getPolicyNameByCollection(String coll) {

[jira] [Resolved] (SOLR-17629) SQL didn't always close internal resources if it encountered an exception

2025-01-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17629. - Fix Version/s: 9.9 Resolution: Fixed > SQL didn't always close internal resources if it en

[jira] [Commented] (SOLR-17602) Maintain final JAR dependencies in source control to track changes

2025-01-22 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916177#comment-17916177 ] Christos Malliaridis commented on SOLR-17602: - I would consider PR #2925 as p

Re: [PR] SOLR-17631: Upgrade main to Lucene 10.x [solr]

2025-01-22 Thread via GitHub
chatman commented on PR #3053: URL: https://github.com/apache/solr/pull/3053#issuecomment-2607786041 Now, here's the list of failing tests: ```TestRandomDVFaceting TestReversedWildcardFilterFactory TestGroupingSearch BasicFunctionalityTest TestDistributedGrouping TestDis

Re: [PR] chore(deps): update dependency com.google.re2j:re2j to v1.8 - autoclosed [solr]

2025-01-22 Thread via GitHub
solrbot closed pull request #2986: chore(deps): update dependency com.google.re2j:re2j to v1.8 - autoclosed URL: https://github.com/apache/solr/pull/2986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] SOLR-17342 Avoid loading from remote CDN [solr-site]

2025-01-22 Thread via GitHub
janhoy commented on PR #136: URL: https://github.com/apache/solr-site/pull/136#issuecomment-2608096529 > Didn't know about `#}` as a comment pattern. Thanks for this chore. I did not either, so I changed it to `

[jira] [Commented] (SOLR-17602) Maintain final JAR dependencies in source control to track changes

2025-01-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916157#comment-17916157 ] David Smiley commented on SOLR-17602: - That merged PR #2925 is related but doesn't ap

Re: [PR] chore(deps): update fasterxml to v2.18.2 [solr]

2025-01-22 Thread via GitHub
malliaridis merged PR #2950: URL: https://github.com/apache/solr/pull/2950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[jira] [Updated] (SOLR-17342) Comply with ASF website policy - external resources

2025-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17342: -- Labels: pull-request-available (was: ) > Comply with ASF website policy - external resources >

Re: [PR] SOLR-17519: CloudSolrClient with HTTP ClusterState can forget live nodes and then fail [solr]

2025-01-22 Thread via GitHub
dsmiley commented on code in PR #2935: URL: https://github.com/apache/solr/pull/2935#discussion_r1925844451 ## solr/CHANGES.txt: ## @@ -176,6 +176,10 @@ Bug Fixes * SOLR-17629: If SQLHandler failed to open the underlying stream (e.g. Solr returns an error; could be user/syntax

Re: [PR] SOLR-17342 Avoid loading from remote CDN [solr-site]

2025-01-22 Thread via GitHub
janhoy commented on PR #136: URL: https://github.com/apache/solr-site/pull/136#issuecomment-2608368672 I added licensing headers for CSS and LICENSE.txt files for the fonts to be more explicit -- This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Updated] (SOLR-17631) Upgrade main to Lucene 10.x

2025-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-17631: --- Priority: Blocker (was: Major) > Upgrade main to Lucene 10.x > --- > >

Re: [PR] chore(deps): update adobe.testing.s3mock to v3 (major) [solr]

2025-01-22 Thread via GitHub
malliaridis commented on PR #3002: URL: https://github.com/apache/solr/pull/3002#issuecomment-260822 This upgrade contains deprecation warnings for classes that are marked for removal. We may suppress the warnings, but an upgrade to JUnit 5 will be required for the next major upgrade (4

Re: [PR] SOLR-17342 Avoid loading from remote CDN [solr-site]

2025-01-22 Thread via GitHub
janhoy commented on PR #136: URL: https://github.com/apache/solr-site/pull/136#issuecomment-2608272766 Interestingly, the staging site already reports errors due to CSP. https://github.com/user-attachments/assets/fdfcc17e-4de2-4e34-bc1c-e4c46106b06e"; /> So after merge we'll be abl

[PR] Prepare for running a separate Renovate workflow for branch_9x [solr]

2025-01-22 Thread via GitHub
janhoy opened a new pull request, #3057: URL: https://github.com/apache/solr/pull/3057 Now that main branch uses gradle version catalogs, dependency upgrades cannot be easily back ported to branch_9x anymore, unless the version catalogs are back ported as well. Also, many features ar

Re: [PR] chore(deps): update dependency org.carrot2:carrot2-core to v4.6.0 [solr]

2025-01-22 Thread via GitHub
solrbot commented on PR #2983: URL: https://github.com/apache/solr/pull/2983#issuecomment-2608653022 ### Edited/Blocked Notification Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

Re: [PR] chore(deps): update mockito to v5.15.2 [solr]

2025-01-22 Thread via GitHub
solrbot commented on PR #2998: URL: https://github.com/apache/solr/pull/2998#issuecomment-2608656373 ### Edited/Blocked Notification Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

Re: [PR] SOLR-17519: CloudSolrClient with HTTP ClusterState can forget live nodes and then fail [solr]

2025-01-22 Thread via GitHub
mlbiscoc commented on code in PR #2935: URL: https://github.com/apache/solr/pull/2935#discussion_r1925986935 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java: ## @@ -216,38 +236,42 @@ private SimpleOrderedMap submitClusterStateRequest(

Re: [PR] SOLR-17519: CloudSolrClient with HTTP ClusterState can forget live nodes and then fail [solr]

2025-01-22 Thread via GitHub
dsmiley commented on PR #2935: URL: https://github.com/apache/solr/pull/2935#issuecomment-2608306662 I'll merge this in about a day as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-22 Thread via GitHub
sijuv commented on PR #2960: URL: https://github.com/apache/solr/pull/2960#issuecomment-2608004442 @dsmiley can you pls relook when you get a chance ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] chore(deps): update opentelemetry to v1.46.0 [solr]

2025-01-22 Thread via GitHub
janhoy merged PR #2999: URL: https://github.com/apache/solr/pull/2999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Updated] (SOLR-17631) Upgrade main to Lucene 10.x

2025-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-17631: --- Fix Version/s: main (10.0) > Upgrade main to Lucene 10.x > --- > >

[jira] [Updated] (SOLR-17631) Upgrade main to Lucene 10.x

2025-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-17631: --- Component/s: search > Upgrade main to Lucene 10.x > --- > > K

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-22 Thread via GitHub
dsmiley commented on PR #2960: URL: https://github.com/apache/solr/pull/2960#issuecomment-2608897224 note: you force-pushed to this PR. Please don't do that; it resets the review state making it hard for me to see changes since my last review and if I try it's still possible an earlier com

[PR] chore(deps): update dependency com.github.ben-manes.versions to v0.52.0 [solr]

2025-01-22 Thread via GitHub
solrbot opened a new pull request, #3058: URL: https://github.com/apache/solr/pull/3058 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | com.github.ben-manes.versions | plugin | minor | `0.51.0` -> `0.52.0` | --- ### C

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-22 Thread via GitHub
dsmiley commented on code in PR #2960: URL: https://github.com/apache/solr/pull/2960#discussion_r1926430030 ## solr/core/src/java/org/apache/solr/search/QueryResult.java: ## @@ -22,6 +22,7 @@ public class QueryResult { // Object for back compatibility so that we render true n

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-22 Thread via GitHub
dsmiley commented on code in PR #2960: URL: https://github.com/apache/solr/pull/2960#discussion_r1926442325 ## solr/core/src/java/org/apache/solr/response/SolrQueryResponse.java: ## @@ -68,6 +68,7 @@ public class SolrQueryResponse { public static final String RESPONSE_HEADER_

[jira] [Created] (SOLR-17631) Upgrade main to Lucene 10.x

2025-01-22 Thread Ishan Chattopadhyaya (Jira)
Ishan Chattopadhyaya created SOLR-17631: --- Summary: Upgrade main to Lucene 10.x Key: SOLR-17631 URL: https://issues.apache.org/jira/browse/SOLR-17631 Project: Solr Issue Type: Improvemen

[PR] SOLR-17631: Upgrade main to Lucene 10.x [solr]

2025-01-22 Thread via GitHub
chatman opened a new pull request, #3053: URL: https://github.com/apache/solr/pull/3053 [SOLR-17631](https://issues.apache.org/jira/browse/SOLR-17631) Upgrade main to Lucene 10.x Right now, I've fixed all compilation issues with core and test modules. Other modules still don't

[jira] [Commented] (SOLR-17631) Upgrade main to Lucene 10.x

2025-01-22 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915968#comment-17915968 ] Ishan Chattopadhyaya commented on SOLR-17631: - [https://github.com/apache/sol