Re: [I] Mounting a volume to an init container is not clear [solr-operator]

2024-12-19 Thread via GitHub
jamesla commented on issue #736: URL: https://github.com/apache/solr-operator/issues/736#issuecomment-2553089526 Thanks @mcarroll1 I did build that example by reading the full spec and I've read it a second time and I still can't seem to see what I'm doing wrong. Does that example wor

Re: [PR] Deprecate MapWriter.append [solr]

2024-12-19 Thread via GitHub
dsmiley commented on code in PR #2919: URL: https://github.com/apache/solr/pull/2919#discussion_r1892659835 ## solr/solrj/src/java/org/apache/solr/common/MapWriter.java: ## @@ -70,8 +74,7 @@ public MapWriter.EntryWriter put(CharSequence k, Object v) { writer.endObject();

[jira] [Commented] (SOLR-17290) Update SyncStrategy and PeerSyncWithLeader to use the recovery Http2SolrClient

2024-12-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907105#comment-17907105 ] ASF subversion and git services commented on SOLR-17290: Commit 4

[jira] [Commented] (SOLR-17306) Solr Repeater or Slave loses data after restart when replication is not enabled on leader

2024-12-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907106#comment-17907106 ] ASF subversion and git services commented on SOLR-17306: Commit b

[jira] [Commented] (SOLR-17592) Apache->Jetty HttpClient for SolrCloudManager

2024-12-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907104#comment-17907104 ] ASF subversion and git services commented on SOLR-17592: Commit 4

[jira] [Resolved] (SOLR-17306) Solr Repeater or Slave loses data after restart when replication is not enabled on leader

2024-12-19 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17306. -- Fix Version/s: 9.8 Resolution: Fixed Thank you for the fix! > Solr Repeater or Slave loses data

Re: [PR] SOLR-17541: LBSolrClient implementations should agree on 'getClient()' semantics [solr]

2024-12-19 Thread via GitHub
jdyer1 commented on PR #2899: URL: https://github.com/apache/solr/pull/2899#issuecomment-2554671937 I added a CHANGES.txt entry to this PR and plan to merge this early next week. I also will separately add a deprecation on `CloudHttp2SolrClient#withHttpClient` in `branch_9x`, to be release

Re: [PR] Deprecate MapWriter.append [solr]

2024-12-19 Thread via GitHub
epugh commented on code in PR #2919: URL: https://github.com/apache/solr/pull/2919#discussion_r1892383853 ## solr/solrj/src/java/org/apache/solr/common/MapWriter.java: ## @@ -70,8 +74,7 @@ public MapWriter.EntryWriter put(CharSequence k, Object v) { writer.endObject(); }

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-12-19 Thread via GitHub
epugh commented on PR #2918: URL: https://github.com/apache/solr/pull/2918#issuecomment-2554513658 waiting for checks to complete and then will merge! let's hope my nemesis `CHANGES.txt` doesn't get me! -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Created] (SOLR-17601) HttpSolrCall: INVALID_STATE: use an HTTP response header instead

2024-12-19 Thread David Smiley (Jira)
David Smiley created SOLR-17601: --- Summary: HttpSolrCall: INVALID_STATE: use an HTTP response header instead Key: SOLR-17601 URL: https://issues.apache.org/jira/browse/SOLR-17601 Project: Solr

[PR] SOLR-17541: Deprecate `CloudHttp2SolrClient.Builder#withHttpClient` (Solr 9.9) [solr]

2024-12-19 Thread via GitHub
jdyer1 opened a new pull request, #2920: URL: https://github.com/apache/solr/pull/2920 For Solr 9.9, deprecate `CloudHttp2SolrClient.Builder#withHttpClient` in favor of `CloudHttp2SolrClient.Builder#withInternalClientBuilder`. PR #2899 removes this in Solr 10.0. -- This is an automated

Re: [PR] SOLR-17541: Deprecate `CloudHttp2SolrClient.Builder#withHttpClient` (Solr 9.9) [solr]

2024-12-19 Thread via GitHub
jdyer1 closed pull request #2920: SOLR-17541: Deprecate `CloudHttp2SolrClient.Builder#withHttpClient` (Solr 9.9) URL: https://github.com/apache/solr/pull/2920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (SOLR-17306) Solr Repeater or Slave loses data after restart when replication is not enabled on leader

2024-12-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907095#comment-17907095 ] ASF subversion and git services commented on SOLR-17306: Commit 9

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-12-19 Thread via GitHub
epugh merged PR #2918: URL: https://github.com/apache/solr/pull/2918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Updated] (SOLR-17601) HttpSolrCall: INVALID_STATE: use an HTTP response header instead

2024-12-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17601: Description: *Background & problem:*  CloudSolrClient & Solr (HttpSolrCall, specifically) work tog

[jira] [Commented] (SOLR-17306) Solr Repeater or Slave loses data after restart when replication is not enabled on leader

2024-12-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907116#comment-17907116 ] ASF subversion and git services commented on SOLR-17306: Commit 0

Re: [PR] SOLR-17548: Switch all public Java APIs from File to Path [solr]

2024-12-19 Thread via GitHub
epugh merged PR #2907: URL: https://github.com/apache/solr/pull/2907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17587: Prometheus Writer duplicate TYPE information in exposition format [solr]

2024-12-19 Thread via GitHub
dsmiley commented on PR #2902: URL: https://github.com/apache/solr/pull/2902#issuecomment-2555764301 I could say the same thing for dependencies. People add/remove dependencies in build files (Maven/Gradle/Ivy) but ultimately what we want to know is, what JARs changed in the ultimate distr

[jira] [Updated] (SOLR-17605) Umbrella: CloudSolrClient: HTTP ClusterStateProvider

2024-12-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17605: Description: Vision: make the HTTP ClusterStateProvider (Solr URLs) be the primary (only?) way tha

[jira] [Commented] (SOLR-17153) CloudSolrClient should not throw "Collection not found" with an out-dated ClusterState

2024-12-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907229#comment-17907229 ] David Smiley commented on SOLR-17153: - The state of this issue is misleading.  It was

Re: [PR] SOLR-17582 Stream CLUSTERSTATUS API response [solr]

2024-12-19 Thread via GitHub
mlbiscoc commented on code in PR #2916: URL: https://github.com/apache/solr/pull/2916#discussion_r1892947508 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java: ## @@ -185,7 +184,9 @@ private DocCollection fetchCollectionState(SolrClient

Re: [PR] SOLR-17582 Stream CLUSTERSTATUS API response [solr]

2024-12-19 Thread via GitHub
mlbiscoc commented on code in PR #2916: URL: https://github.com/apache/solr/pull/2916#discussion_r1892947219 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -368,4 +341,77 @@ public static Map postProcessCollectionJSON(Map collection.put("heal

Re: [PR] SOLR-15751: Modify v2 `GET /collections/collName` to support full ColStatus response [solr]

2024-12-19 Thread via GitHub
gerlowskija commented on PR #2912: URL: https://github.com/apache/solr/pull/2912#issuecomment-257975 > Will aim to merge this in a few days pending any more feedback Actually - thinking on it a bit - the v1 `/admin/segments` API is used under the hood by COLSTATUS, and has a very

Re: [PR] SOLR-17582 Stream CLUSTERSTATUS API response [solr]

2024-12-19 Thread via GitHub
mlbiscoc commented on code in PR #2916: URL: https://github.com/apache/solr/pull/2916#discussion_r1893059557 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -205,54 +214,32 @@ private void fetchClusterStatusForCollOrAlias( } } -//

Re: [PR] SOLR-17582 Stream CLUSTERSTATUS API response [solr]

2024-12-19 Thread via GitHub
dsmiley commented on code in PR #2916: URL: https://github.com/apache/solr/pull/2916#discussion_r1893056849 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -342,76 +356,47 @@ public static Map postProcessCollectionJSON(Map return collection;

[jira] [Created] (SOLR-17602) Maintain final JAR dependencies in source control to track changes

2024-12-19 Thread David Smiley (Jira)
David Smiley created SOLR-17602: --- Summary: Maintain final JAR dependencies in source control to track changes Key: SOLR-17602 URL: https://issues.apache.org/jira/browse/SOLR-17602 Project: Solr

[jira] [Created] (SOLR-17603) Maintain Solrj transitive dependencies in source control to track changes

2024-12-19 Thread David Smiley (Jira)
David Smiley created SOLR-17603: --- Summary: Maintain Solrj transitive dependencies in source control to track changes Key: SOLR-17603 URL: https://issues.apache.org/jira/browse/SOLR-17603 Project: Solr

Re: [PR] SOLR-17587: Prometheus Writer duplicate TYPE information in exposition format [solr]

2024-12-19 Thread via GitHub
dsmiley commented on code in PR #2902: URL: https://github.com/apache/solr/pull/2902#discussion_r1893230595 ## solr/core/src/java/org/apache/solr/metrics/prometheus/core/SolrCoreCacheMetric.java: ## @@ -38,7 +37,7 @@ public SolrCoreCacheMetric( public SolrCoreMetric parseLabe

Re: [PR] SOLR-17582 Stream CLUSTERSTATUS API response [solr]

2024-12-19 Thread via GitHub
mlbiscoc commented on code in PR #2916: URL: https://github.com/apache/solr/pull/2916#discussion_r1892947285 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -368,4 +341,77 @@ public static Map postProcessCollectionJSON(Map collection.put("heal

[I] Recommended approach for loading a schema and configset using the operator [solr-operator]

2024-12-19 Thread via GitHub
jamesla opened a new issue, #740: URL: https://github.com/apache/solr-operator/issues/740 I'm struggling to load a schema and a configset using the operator. In my docker-compose I do it like this: ```yaml config-loader: image: alpine/curl:latest container_nam

Re: [PR] SOLR-17582 Stream CLUSTERSTATUS API response [solr]

2024-12-19 Thread via GitHub
dsmiley commented on code in PR #2916: URL: https://github.com/apache/solr/pull/2916#discussion_r1893072837 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -205,54 +214,32 @@ private void fetchClusterStatusForCollOrAlias( } } -// T

Re: [PR] Deprecate MapWriter.append [solr]

2024-12-19 Thread via GitHub
dsmiley commented on PR #2919: URL: https://github.com/apache/solr/pull/2919#issuecomment-2555703092 I'm thinking of merging this with removal of the deprecated method, and in 9x & branch_9_8 simply deprecating the method. -- This is an automated message from the Apache Git Service. To re

Re: [PR] SOLR-17587: Prometheus Writer duplicate TYPE information in exposition format [solr]

2024-12-19 Thread via GitHub
mlbiscoc commented on PR #2902: URL: https://github.com/apache/solr/pull/2902#issuecomment-2555793583 > Correct me if I'm wrong, but had you kept the test that you had removed because hossman didn't like it (it was imperfect), a reviewer (like me but you too) would be able to see in this PR

[jira] [Created] (SOLR-17604) Move state caching from CloudSolrClient to ClusterStateProvider

2024-12-19 Thread David Smiley (Jira)
David Smiley created SOLR-17604: --- Summary: Move state caching from CloudSolrClient to ClusterStateProvider Key: SOLR-17604 URL: https://issues.apache.org/jira/browse/SOLR-17604 Project: Solr I

[jira] [Created] (SOLR-17605) Umbrella: CloudSolrClient & ClusterStateProvider

2024-12-19 Thread David Smiley (Jira)
David Smiley created SOLR-17605: --- Summary: Umbrella: CloudSolrClient & ClusterStateProvider Key: SOLR-17605 URL: https://issues.apache.org/jira/browse/SOLR-17605 Project: Solr Issue Type: Impro

[jira] [Updated] (SOLR-17605) Umbrella: CloudSolrClient: HTTP ClusterStateProvider

2024-12-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17605: Summary: Umbrella: CloudSolrClient: HTTP ClusterStateProvider (was: Umbrella: CloudSolrClient & Cl

[jira] [Updated] (SOLR-17153) CloudSolrClient should not throw "Collection not found" with an out-dated ClusterState

2024-12-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17153: -- Labels: pull-request-available (was: ) > CloudSolrClient should not throw "Collection not foun

[jira] [Updated] (SOLR-17153) CloudSolrClient should not throw "Collection not found" with an out-dated ClusterState

2024-12-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17153: Description: _(Present status: reverted / not accomplished.  New issues needed to continue)_ Today

[jira] [Created] (SOLR-17606) ClusterStateProvider.collectionStream

2024-12-19 Thread David Smiley (Jira)
David Smiley created SOLR-17606: --- Summary: ClusterStateProvider.collectionStream Key: SOLR-17606 URL: https://issues.apache.org/jira/browse/SOLR-17606 Project: Solr Issue Type: Improvement

[jira] [Updated] (SOLR-17520) CloudSolrClient with HTTP ClusterState shouldn't time-expire recently used cache entries

2024-12-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17520: Priority: Minor (was: Major) > CloudSolrClient with HTTP ClusterState shouldn't time-expire recent

[jira] [Updated] (SOLR-17606) ClusterStateProvider.collectionStream

2024-12-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17606: Priority: Minor (was: Major) This is a nice-to-have.  A potential caller of this (like the Prometh

[jira] [Resolved] (SOLR-17153) CloudSolrClient should not throw "Collection not found" with an out-dated ClusterState

2024-12-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17153. - Resolution: Incomplete (was: Fixed) > CloudSolrClient should not throw "Collection not found" wi

[jira] [Updated] (SOLR-17153) CloudSolrClient should not throw "Collection not found" with an out-dated ClusterState

2024-12-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17153: Status: Reopened (was: Closed) > CloudSolrClient should not throw "Collection not found" with an o

Re: [PR] SOLR-17153: CloudSolrClient should not throw "Collection not found" with an out-dated ClusterState [solr]

2024-12-19 Thread via GitHub
dsmiley commented on PR #2363: URL: https://github.com/apache/solr/pull/2363#issuecomment-2556137265 @markrmiller , thinking back to your feedback, I have an idea of a solution in several steps: (A) In https://issues.apache.org/jira/browse/SOLR-17601 I propose using HTTP response header

Re: [PR] SOLR-17153: CloudSolrClient should not throw "Collection not found" with an out-dated ClusterState [solr]

2024-12-19 Thread via GitHub
markrmiller commented on PR #2363: URL: https://github.com/apache/solr/pull/2363#issuecomment-2556330775 Yeah, that’s how I would do it. For any command that alters the state, return the version of the modified state and have the client make sure that’s at least the version it’s using for t