dsmiley commented on code in PR #2916:
URL: https://github.com/apache/solr/pull/2916#discussion_r1890699859
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -368,4 +341,77 @@ public static Map
postProcessCollectionJSON(Map
collection.put("healt
[
https://issues.apache.org/jira/browse/SOLR-17598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christos Malliaridis updated SOLR-17598:
Description:
On Windows, when setting the {{SOLR_LOGS_DIR}} in the environment vari
malliaridis commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2551851228
Please note in case this is backported to 9.X that you will have to use the
`/versions.props`for the dependencies and also refactor the gradle file so that
it uses the previous notation,
[
https://issues.apache.org/jira/browse/SOLR-17286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906859#comment-17906859
]
David Smiley commented on SOLR-17286:
-
I also strongly want to rename this. "remoteQ
[
https://issues.apache.org/jira/browse/SOLR-17286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley reassigned SOLR-17286:
---
Assignee: David Smiley
> HttpSolrCall.remoteQuery (proxy) should use Jetty HttpClient
>
[
https://issues.apache.org/jira/browse/SOLR-17414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17414.
-
Fix Version/s: 9.8
Resolution: Fixed
> multiThreaded=true can result in RejectedExecutionE
[
https://issues.apache.org/jira/browse/SOLR-17560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley reassigned SOLR-17560:
---
Assignee: (was: David Smiley)
> DocCollection, don't need getLeaderReplicas(nodeName)
>
dsmiley commented on code in PR #2912:
URL: https://github.com/apache/solr/pull/2912#discussion_r1890892532
##
solr/api/src/java/org/apache/solr/client/api/model/CollectionStatusResponse.java:
##
@@ -82,21 +97,93 @@ public static class LeaderSummary {
// Present with core
dsmiley commented on code in PR #2912:
URL: https://github.com/apache/solr/pull/2912#discussion_r1890899775
##
solr/api/src/java/org/apache/solr/client/api/model/CollectionStatusResponse.java:
##
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
dsmiley commented on code in PR #2899:
URL: https://github.com/apache/solr/pull/2899#discussion_r1890903610
##
solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java:
##
@@ -374,17 +374,13 @@ PublicKey fetchPublicKeyFromRemote(String nodename) {
}
}
-
[
https://issues.apache.org/jira/browse/SOLR-15751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-15751:
--
Labels: V2 newdev pull-request-available (was: V2 newdev)
> Create a v2 equivalent for 'COLSTA
Christos Malliaridis created SOLR-17598:
---
Summary: Windows Script logic that handles SOLR_LOGS_DIR is faulty
Key: SOLR-17598
URL: https://issues.apache.org/jira/browse/SOLR-17598
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-17598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christos Malliaridis updated SOLR-17598:
Affects Version/s: 9.8
> Windows Script logic that handles SOLR_LOGS_DIR is faulty
[
https://issues.apache.org/jira/browse/SOLR-17598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christos Malliaridis updated SOLR-17598:
Affects Version/s: 9x
(was: 9.7)
> Windows Script logic
gerlowskija commented on code in PR #2912:
URL: https://github.com/apache/solr/pull/2912#discussion_r1890632261
##
solr/core/src/java/org/apache/solr/handler/admin/api/CollectionStatus.java:
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
malliaridis commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2551951538
It should be manageable in less than an hour to handle the gradle stuff.
However, in case you make use of JDK >11 fearures, or the dependencies are not
compatible with JDK 11, there may
ds-manzinger opened a new pull request, #2918:
URL: https://github.com/apache/solr/pull/2918
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
ds-manzinger commented on PR #2918:
URL: https://github.com/apache/solr/pull/2918#issuecomment-2552157377
@epugh Sorry for that new Pull Request. Sync with apache/solr broke my
history
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jdyer1 commented on PR #2899:
URL: https://github.com/apache/solr/pull/2899#issuecomment-2552174264
> Can you point me at such so I can appreciate the problem better?
My apologies, I think I misstated what is going on earlier.
`PKIAuthenticationPlugin` on setup injects a `RequestResp
dsmiley commented on PR #2899:
URL: https://github.com/apache/solr/pull/2899#issuecomment-2552178161
Since the direction is SolrClient immutability, I think this auth/PKI setup
method should only the builder (mutable). Is this realistic?
--
This is an automated message from the Apache Gi
alessandrobenedetti commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2551958083
Not at all, let's see first if 9.8 is acceptable as a target and we take it
from there!
Thanks in the meantime for your prompt responses!
--
This is an automated message fro
[
https://issues.apache.org/jira/browse/SOLR-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Salagnac updated SOLR-17471:
---
Summary: upgrade to Lucene 9.12.1 (was: upgrade to Lucene 9.12.x)
> upgrade to Lucene 9.12.1
[
https://issues.apache.org/jira/browse/SOLR-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Salagnac reassigned SOLR-17471:
--
Assignee: Pierre Salagnac
> upgrade to Lucene 9.12.1
>
>
>
[
https://issues.apache.org/jira/browse/SOLR-17405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906816#comment-17906816
]
David Smiley commented on SOLR-17405:
-
> this bug does not exist anymore since the mo
[
https://issues.apache.org/jira/browse/SOLR-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906818#comment-17906818
]
Pierre Salagnac commented on SOLR-17471:
I updated the PR to upgrade to Lucene 9.
[
https://issues.apache.org/jira/browse/SOLR-17405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Salagnac reassigned SOLR-17405:
--
Assignee: Pierre Salagnac
> Zookeeper session can be re-established by multiple thread
jdyer1 commented on PR #2899:
URL: https://github.com/apache/solr/pull/2899#issuecomment-2552304777
> Since the direction is SolrClient immutability, I think this auth/PKI
setup method should only the builder (mutable). Is this realistic?
I fully agree this is the right direction to t
mlbiscoc commented on PR #2902:
URL: https://github.com/apache/solr/pull/2902#issuecomment-2552315416
Going to bump this PR. It's not a blocker for standard Prometheus server
metrics collection but it can potentially block users using other
exporters/collectors.
--
This is an automated m
pvcnt commented on code in PR #2913:
URL: https://github.com/apache/solr/pull/2913#discussion_r1890431876
##
solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java:
##
@@ -160,28 +156,13 @@ protected String getCoreOrColName() {
return collectionName;
}
epugh commented on PR #2908:
URL: https://github.com/apache/solr/pull/2908#issuecomment-2552105680
Thanks for confirming this...Yeah, no test structure sucks. Hopefully
htough, as we work out the set of changes that we introduced in 9.7 and 9.8
that things will calm down
--
Thi
epugh merged PR #2908:
URL: https://github.com/apache/solr/pull/2908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
Mark Robert Miller created SOLR-17599:
-
Summary: CrossDC should not use the MirroringUpdateHandler when
replaying updates from the transaction log or when doing PeerSync.
Key: SOLR-17599
URL: https://issues.ap
ds-manzinger closed pull request #2874: SOLR-17306: fix replication problem on
follower restart
URL: https://github.com/apache/solr/pull/2874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
magibney commented on PR #2917:
URL: https://github.com/apache/solr/pull/2917#issuecomment-2551854131
This is a trivial change with no practical impact on the vast majority of
users. I plan to merge this tomorrow, pending any feedback.
--
This is an automated message from the Apache Git S
alessandrobenedetti commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2551920436
thanks @malliaridis to let me know, I totally forgot about the dependency
hell!
What do you think @anshumg ? In case Anshum is happy to include it, Christos
will you have
psalagnac opened a new pull request, #2914:
URL: https://github.com/apache/solr/pull/2914
https://issues.apache.org/jira/browse/SOLR-17405
# Description
`OnReconnect` can be invoked by several threads concurrently (see Jira for
the explanation).
Same change a
malliaridis merged PR #2911:
URL: https://github.com/apache/solr/pull/2911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
[
https://issues.apache.org/jira/browse/SOLR-17595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906786#comment-17906786
]
ASF subversion and git services commented on SOLR-17595:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-17595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906789#comment-17906789
]
ASF subversion and git services commented on SOLR-17595:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-17595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christos Malliaridis resolved SOLR-17595.
-
Resolution: Fixed
> CLI examples are broken on Windows
>
[
https://issues.apache.org/jira/browse/SOLR-17551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christos Malliaridis resolved SOLR-17551.
-
Fix Version/s: 9.8
Resolution: Resolved
This issue is resolved via the ref
[
https://issues.apache.org/jira/browse/SOLR-17551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906795#comment-17906795
]
Christos Malliaridis edited comment on SOLR-17551 at 12/18/24 4:19 PM:
gerlowskija commented on code in PR #2912:
URL: https://github.com/apache/solr/pull/2912#discussion_r1890512324
##
solr/api/src/java/org/apache/solr/client/api/model/CollectionStatusResponse.java:
##
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
gerlowskija commented on code in PR #2912:
URL: https://github.com/apache/solr/pull/2912#discussion_r1890516257
##
solr/api/src/java/org/apache/solr/client/api/model/CollectionStatusResponse.java:
##
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
gerlowskija commented on code in PR #2912:
URL: https://github.com/apache/solr/pull/2912#discussion_r1890516647
##
solr/core/src/java/org/apache/solr/api/V2HttpCall.java:
##
@@ -188,6 +188,8 @@ public void call(SolrQueryRequest req, SolrQueryResponse
rsp) {
Thread.cur
malliaridis opened a new pull request, #2915:
URL: https://github.com/apache/solr/pull/2915
# Description
After the upgrade to version catalogs there were changes made in the way our
project resolves the dependencies. The new "flow introduced has proven to be
quite confusing and prob
mlbiscoc opened a new pull request, #2916:
URL: https://github.com/apache/solr/pull/2916
https://issues.apache.org/jira/browse/SOLR-17582
# Description
`CLUSTERSTATUS` would aggregate and build the whole response including all
collection properties into an `NamedList` before fi
[
https://issues.apache.org/jira/browse/SOLR-17582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17582:
--
Labels: pull-request-available (was: )
> CLUSTERSTATUS API could stream the response to save m
dsmiley commented on PR #2672:
URL: https://github.com/apache/solr/pull/2672#issuecomment-2551551068
I'm looking at #2527 and #2672 (this one) which seem the same at a glance;
why do we have two PRs?
It's really sad this didn't get merged before 9.8. Contributors sometime
really nee
[
https://issues.apache.org/jira/browse/SOLR-17405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906779#comment-17906779
]
Pierre Salagnac commented on SOLR-17405:
Thanks for pointing this [~janhoy].
Inde
dsmiley opened a new pull request, #2913:
URL: https://github.com/apache/solr/pull/2913
I don't love seeing SolrQueryRequest.getCloudDescriptor -- we should be
conservative of adding more methods to SolrQueryRequest. It only has one
caller.
Tests pass. If it serves a purpose, remov
dsmiley commented on PR #2913:
URL: https://github.com/apache/solr/pull/2913#issuecomment-2551617582
@patsonluk do you know about this?
**If** there's a problem, it's HttpShardHandler (the only caller) who passes
this cloudDescriptor on to
`org.apache.solr.handler.component.HttpShardHand
Michael Gibney created SOLR-17597:
-
Summary: CaffeineCache ramBytes incorrect accounting on `put()`
Key: SOLR-17597
URL: https://issues.apache.org/jira/browse/SOLR-17597
Project: Solr
Issue T
[
https://issues.apache.org/jira/browse/SOLR-17582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906801#comment-17906801
]
Matthew Biscocho commented on SOLR-17582:
-
Took a look at MapWriter like you said
[
https://issues.apache.org/jira/browse/SOLR-17597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17597:
--
Labels: pull-request-available (was: )
> CaffeineCache ramBytes incorrect accounting on `put()
magibney commented on PR #2917:
URL: https://github.com/apache/solr/pull/2917#issuecomment-2551828172
This probably does not warrant a CHANGES.txt entry, since it doesn't impact
any existing/default implementation or invocation of `CaffeineCache`.
NOTE: the second (`V oldValue`) arg t
epugh commented on PR #2874:
URL: https://github.com/apache/solr/pull/2874#issuecomment-2551837349
@ds-manzinger I just went to merge, and of course my old enemy,
`CHANGES.txt` has merge conflict. Would you mine fixing that and then I'll
click the merge button! Lookign forward to getting
[
https://issues.apache.org/jira/browse/SOLR-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906836#comment-17906836
]
David Smiley commented on SOLR-16891:
-
I liked this mostly except for one detail – Ma
gerlowskija commented on PR #2912:
URL: https://github.com/apache/solr/pull/2912#issuecomment-2552199105
Alright - COLSTATUS bug if fixed (see comment above), added some additional
tests for both v1 and v2, and tests+check pass for me locally! Will aim to
merge this in a few days pending a
David Smiley created SOLR-17600:
---
Summary: Deprecate and remove MapSerializable
Key: SOLR-17600
URL: https://issues.apache.org/jira/browse/SOLR-17600
Project: Solr
Issue Type: Task
Securi
[
https://issues.apache.org/jira/browse/SOLR-17600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17600:
Fix Version/s: main (10.0)
Labels: newdev (was: )
> Deprecate and remove MapSerializabl
[
https://issues.apache.org/jira/browse/SOLR-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906890#comment-17906890
]
David Smiley commented on SOLR-16456:
-
Good stuff here but I don't really like MapWri
dsmiley opened a new pull request, #2919:
URL: https://github.com/apache/solr/pull/2919
I don't really like MapWriter.append – undocumented and called in only 2
places. Since MapWriter is implemented by a great many things, we should be
conservative adding methods there. append() is kind
63 matches
Mail list logo
