Re: [PR] doc(volumes): add docs for attaching additional volumes [solr-operator]

2024-12-17 Thread via GitHub
janhoy commented on PR #739: URL: https://github.com/apache/solr-operator/pull/739#issuecomment-2548384419 Thanks for the contribution. I'm not sure if "Data storage" is the best place to describe custom volume mounts as they are NOT used to store index data but configuration or backup.

Re: [PR] doc(volumes): add docs for attaching additional volumes [solr-operator]

2024-12-17 Thread via GitHub
mcarroll1 commented on PR #739: URL: https://github.com/apache/solr-operator/pull/739#issuecomment-2548715360 Sorry, I mean to link https://github.com/apache/solr-operator/blob/main/config/crd/bases/solr.apache.org_solrclouds.yaml#L7869, which appears to very closely mimic the backup volume

[jira] [Updated] (SOLR-17596) Solr 8.11.2 - 9.0 standalone mode nullPointerException when ShardHandlerFactory defined

2024-12-17 Thread Danny (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny updated SOLR-17596: - Description: Same issue as https://issues.apache.org/jira/browse/SOLR-16485 as this was first introduced in vers

[jira] [Created] (SOLR-17596) Solr 8.11.2 - 9.0 standalone mode nullPointerException when ShardHandlerFactory defined

2024-12-17 Thread Danny (Jira)
Danny created SOLR-17596: Summary: Solr 8.11.2 - 9.0 standalone mode nullPointerException when ShardHandlerFactory defined Key: SOLR-17596 URL: https://issues.apache.org/jira/browse/SOLR-17596 Project: Solr

Re: [I] Mounting a volume to an init container is not clear [solr-operator]

2024-12-17 Thread via GitHub
mcarroll1 commented on issue #736: URL: https://github.com/apache/solr-operator/issues/736#issuecomment-2548746117 Turns out you can find the full spec here: https://github.com/apache/solr-operator/blob/main/config/crd/bases/solr.apache.org_solrclouds.yaml#L7038 -- This is an automated me

Re: [PR] SOLR-17579: Refactoring suggested by IDE in ReplicationHandler and tests [solr]

2024-12-17 Thread via GitHub
epugh commented on code in PR #2893: URL: https://github.com/apache/solr/pull/2893#discussion_r1888332909 ## solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java: ## @@ -1532,7 +1518,8 @@ private Long readIntervalNs(String interval) { public static final String

Re: [PR] doc(volumes): add docs for attaching additional volumes [solr-operator]

2024-12-17 Thread via GitHub
mcarroll1 commented on PR #739: URL: https://github.com/apache/solr-operator/pull/739#issuecomment-2548525920 @janhoy I'm happy to move this information and change the example to something like a ConfigMap. Is there anywhere we can add "extended docs/examples" though? I understand not wanti

Re: [PR] SOLR-17579: Refactoring suggested by IDE in ReplicationHandler and tests [solr]

2024-12-17 Thread via GitHub
epugh commented on code in PR #2893: URL: https://github.com/apache/solr/pull/2893#discussion_r1888333804 ## solr/CHANGES.txt: ## @@ -164,7 +164,8 @@ Dependency Upgrades Other Changes - -(No changes) +* SOLR-17579: Remove unused code and other refactoring

[jira] [Resolved] (SOLR-17380) Consolidate Duplicate Unit Tests between ZkSubcommandsTest and SolrCLIZkToolsTest

2024-12-17 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17380. -- Resolution: Abandoned > Consolidate Duplicate Unit Tests between ZkSubcommandsTest and > SolrCLIZkTool

[jira] [Commented] (SOLR-17380) Consolidate Duplicate Unit Tests between ZkSubcommandsTest and SolrCLIZkToolsTest

2024-12-17 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906384#comment-17906384 ] Eric Pugh commented on SOLR-17380: -- Ugh, I took a stab at it, and just not feeling it. 

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-12-17 Thread via GitHub
epugh commented on PR #2874: URL: https://github.com/apache/solr/pull/2874#issuecomment-2548198818 I tried to push latest `main` updates to the branch, but i don't have permissions to push to your branch... Could you update and add a CHANGES.txt entry? Using the "via Eric Pugh" style and

[jira] [Assigned] (SOLR-17306) Solr Repeater or Slave loses data after restart when replication is not enabled on leader

2024-12-17 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-17306: Assignee: Eric Pugh > Solr Repeater or Slave loses data after restart when replication is not > e

Re: [PR] doc(volumes): add docs for attaching additional volumes [solr-operator]

2024-12-17 Thread via GitHub
janhoy commented on PR #739: URL: https://github.com/apache/solr-operator/pull/739#issuecomment-2548641395 > These volume additions are actually part of the solrcloud CRD The `customSolrKubeOptions.podOptions` that this PR is about is just passed on to k8s. The link you just pr

Re: [PR] Reformat comment better [solr]

2024-12-17 Thread via GitHub
epugh merged PR #2910: URL: https://github.com/apache/solr/pull/2910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17595) CLI examples are broken on Windows

2024-12-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906435#comment-17906435 ] ASF subversion and git services commented on SOLR-17595: Commit a

Re: [PR] SOLR-17595: Fix Solr examples for Windows [solr]

2024-12-17 Thread via GitHub
malliaridis merged PR #2909: URL: https://github.com/apache/solr/pull/2909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[PR] SOLR-17595: Backport "Fix Solr examples for Windows" [solr]

2024-12-17 Thread via GitHub
malliaridis opened a new pull request, #2911: URL: https://github.com/apache/solr/pull/2911 https://issues.apache.org/jira/browse/SOLR-17595 # Description This is the backport for the fixes from #2909. # Checklist Please review the following and check all that appl

[jira] [Commented] (SOLR-16909) Collections LIST command should fetch ZK data, not cached state

2024-12-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906616#comment-17906616 ] David Smiley commented on SOLR-16909: - BTW the perf benefit is O(collections) assumin

Re: [PR] SOLR-17541: LBSolrClient implementations should agree on 'getClient()' semantics [solr]

2024-12-17 Thread via GitHub
jdyer1 commented on code in PR #2899: URL: https://github.com/apache/solr/pull/2899#discussion_r1889342889 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -404,23 +400,6 @@ public Builder withCollectionCacheTtl(long timeToLive, TimeUnit

Re: [PR] SOLR-17541: LBSolrClient implementations should agree on 'getClient()' semantics [solr]

2024-12-17 Thread via GitHub
jdyer1 commented on code in PR #2899: URL: https://github.com/apache/solr/pull/2899#discussion_r1889342889 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -404,23 +400,6 @@ public Builder withCollectionCacheTtl(long timeToLive, TimeUnit

Re: [PR] SOLR-17541: LBSolrClient implementations should agree on 'getClient()' semantics [solr]

2024-12-17 Thread via GitHub
dsmiley commented on code in PR #2899: URL: https://github.com/apache/solr/pull/2899#discussion_r1889609307 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -404,23 +400,6 @@ public Builder withCollectionCacheTtl(long timeToLive, TimeUni

Re: [PR] SOLR-17541: LBSolrClient implementations should agree on 'getClient()' semantics [solr]

2024-12-17 Thread via GitHub
dsmiley commented on code in PR #2899: URL: https://github.com/apache/solr/pull/2899#discussion_r1889609800 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -94,35 +97,63 @@ * * @since solr 8.0 */ -public class LBHttp2SolrClient extend

Re: [PR] SOLR-17541: LBSolrClient implementations should agree on 'getClient()' semantics [solr]

2024-12-17 Thread via GitHub
jdyer1 commented on code in PR #2899: URL: https://github.com/apache/solr/pull/2899#discussion_r1889352673 ## solr/core/src/java/org/apache/solr/security/HttpClientBuilderPlugin.java: ## @@ -34,4 +34,8 @@ public interface HttpClientBuilderPlugin { public SolrHttpClientBuilder

Re: [PR] SOLR-17541: LBSolrClient implementations should agree on 'getClient()' semantics [solr]

2024-12-17 Thread via GitHub
jdyer1 commented on code in PR #2899: URL: https://github.com/apache/solr/pull/2899#discussion_r1889354976 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -94,35 +97,63 @@ * * @since solr 8.0 */ -public class LBHttp2SolrClient extends

Re: [PR] SOLR-17541: LBSolrClient implementations should agree on 'getClient()' semantics [solr]

2024-12-17 Thread via GitHub
jdyer1 commented on PR #2899: URL: https://github.com/apache/solr/pull/2899#issuecomment-2549882911 > So this would be Solr 10? Yes. When I read the description on this ticket, it seemed to me a good opportunity to improve our API with the upcoming major release. It seems wrong we

Re: [PR] SOLR-17541: LBSolrClient implementations should agree on 'getClient()' semantics [solr]

2024-12-17 Thread via GitHub
dsmiley commented on code in PR #2899: URL: https://github.com/apache/solr/pull/2899#discussion_r1889612751 ## solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java: ## @@ -374,8 +374,17 @@ PublicKey fetchPublicKeyFromRemote(String nodename) { } } +

[jira] [Commented] (SOLR-17596) Solr 8.11.2 - 9.0 standalone mode nullPointerException when ShardHandlerFactory defined

2024-12-17 Thread Danny (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906470#comment-17906470 ] Danny commented on SOLR-17596: -- Ah! Sorry I will go ahead and do that now. Does it matter if

[jira] [Commented] (SOLR-16485) Solr 9 standalone mode nullPointerException when ShardHandlerFactory defined

2024-12-17 Thread Danny (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906471#comment-17906471 ] Danny commented on SOLR-16485: -- Seeing how this was introduced in 8.11.2 can this be back po

[jira] [Closed] (SOLR-17596) Solr 8.11.2 - 9.0 standalone mode nullPointerException when ShardHandlerFactory defined

2024-12-17 Thread Danny (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny closed SOLR-17596. > Solr 8.11.2 - 9.0 standalone mode nullPointerException when > ShardHandlerFactory defined >

Re: [PR] SOLR-15781: Modify v2 `GET /collections/collName` to support full ColStatus response [solr]

2024-12-17 Thread via GitHub
gerlowskija commented on PR #2912: URL: https://github.com/apache/solr/pull/2912#issuecomment-2549527042 re: impotent COLSTATUS boolean flags previously discussed [here](https://github.com/apache/solr/pull/2912#issuecomment-2548874545) I think I understand this a bit better now. The

[jira] [Commented] (SOLR-16485) Solr 9 standalone mode nullPointerException when ShardHandlerFactory defined

2024-12-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906525#comment-17906525 ] David Smiley commented on SOLR-16485: - This should have been back-ported; it's sad it

[PR] SOLR-15781: Modify v2 `GET /collections/collName` to support full ColStatus response [solr]

2024-12-17 Thread via GitHub
gerlowskija opened a new pull request, #2912: URL: https://github.com/apache/solr/pull/2912 https://issues.apache.org/jira/browse/SOLR-15781 # Description Solr's v1 "/admin/collections?action=COLSTATUS" API is a useful way to get a high level summary of a single collection. Th

Re: [PR] SOLR-15781: Modify v2 `GET /collections/collName` to support full ColStatus response [solr]

2024-12-17 Thread via GitHub
dsmiley commented on code in PR #2912: URL: https://github.com/apache/solr/pull/2912#discussion_r165754 ## solr/api/src/java/org/apache/solr/client/api/model/CollectionStatusResponse.java: ## @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[jira] [Commented] (SOLR-17596) Solr 8.11.2 - 9.0 standalone mode nullPointerException when ShardHandlerFactory defined

2024-12-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906474#comment-17906474 ] David Smiley commented on SOLR-17596: - No. > Solr 8.11.2 - 9.0 standalone mode nullP

[jira] [Commented] (SOLR-17596) Solr 8.11.2 - 9.0 standalone mode nullPointerException when ShardHandlerFactory defined

2024-12-17 Thread Danny (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906494#comment-17906494 ] Danny commented on SOLR-17596: -- Awesome!  I added a comment to the existing issue. Thanks fo

[jira] [Comment Edited] (SOLR-16485) Solr 9 standalone mode nullPointerException when ShardHandlerFactory defined

2024-12-17 Thread Danny (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906471#comment-17906471 ] Danny edited comment on SOLR-16485 at 12/17/24 6:21 PM: Seeing ho

[jira] [Resolved] (SOLR-17596) Solr 8.11.2 - 9.0 standalone mode nullPointerException when ShardHandlerFactory defined

2024-12-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17596. - Resolution: Invalid This JIRA issue is a duplicate (and you know that). Instead, ask on the exis

Re: [PR] SOLR-15781: Modify v2 `GET /collections/collName` to support full ColStatus response [solr]

2024-12-17 Thread via GitHub
epugh commented on PR #2912: URL: https://github.com/apache/solr/pull/2912#issuecomment-2548874545 If you think there are parameters that maybe don't make sense going forward, I would vote for skipping them. Get this in, and then see if folks highlight legit use cases for why they need th

[jira] [Updated] (SOLR-15781) Make v2 APIs more REST-ful and migrate to JAX-RS

2024-12-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-15781: -- Labels: V2 pull-request-available (was: V2) > Make v2 APIs more REST-ful and migrate to JAX-RS

Re: [PR] SOLR-15781: Modify v2 `GET /collections/collName` to support full ColStatus response [solr]

2024-12-17 Thread via GitHub
gerlowskija commented on PR #2912: URL: https://github.com/apache/solr/pull/2912#issuecomment-2548920411 > If you blindly carry them forward, well, then, we probably are stuck with them forever Definitely don't want that. But I also don't have too much trust in my very quick-and-dir