Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-12-05 Thread via GitHub
alessandrobenedetti commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2520803184 Thanks guys, I updated the PR with additional minor changes in response to @dsmiley and other people feedback. I completely agree on merging this and iterate. It's not mean

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-12-05 Thread via GitHub
alessandrobenedetti commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1871650626 ## solr/modules/llm/src/java/org/apache/solr/llm/texttovector/model/SolrTextToVectorModel.java: ## @@ -63,12 +64,21 @@ public static SolrEmbeddingModel getInst

Re: [PR] SOLR-17525: Text Embedder Query Parser [solr]

2024-12-05 Thread via GitHub
epugh commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2520472327 > Eric, you demonstrate how to save some arbitrary file into the cluster to the so-called "file store". But didn't demonstrate how anything in Solr would use it. But that's in a separate world

Re: [PR] chore(deps): update org.apache.logging.log4j:* to v2.24.1 - autoclosed [solr]

2024-12-05 Thread via GitHub
risdenk commented on PR #2047: URL: https://github.com/apache/solr/pull/2047#issuecomment-2520466098 Ah thanks @janhoy not sure how I missed that comment. I'll take a closer look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (SOLR-17585) CodeCache full during Gradle builds

2024-12-05 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis updated SOLR-17585: Description: We are facing again issues similar to SOLR-16103 where we run out of C

Re: [PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-12-05 Thread via GitHub
dsmiley commented on PR #2875: URL: https://github.com/apache/solr/pull/2875#issuecomment-2519697587 > My vote would be to tear it out. +1 I'm glad to hear you suggest this. I thought I might have been alone in this thinking. I don't think we should "support" this idea; it's too

Re: [PR] Solr 12276 angularjs to angular migration [solr]

2024-12-05 Thread via GitHub
NikolaiJDev commented on PR #2818: URL: https://github.com/apache/solr/pull/2818#issuecomment-2520090026 > Yes, what I (and probably others as well) would like to see is how it would integrate into the current project (which is as described above an open TODO), how someone would work an

Re: [PR] chore(deps): update org.apache.logging.log4j:* to v2.24.1 - autoclosed [solr]

2024-12-05 Thread via GitHub
janhoy commented on PR #2047: URL: https://github.com/apache/solr/pull/2047#issuecomment-2520020161 > @janhoy where did you see that log4j requires JDK 17? I don't see that based on https://logging.apache.org/log4j/2.x/release-notes.html > > I found [apache/logging-log4j2#1922](https

[jira] [Created] (SOLR-17585) CodeCache full during Gradle builds

2024-12-05 Thread Christos Malliaridis (Jira)
Christos Malliaridis created SOLR-17585: --- Summary: CodeCache full during Gradle builds Key: SOLR-17585 URL: https://issues.apache.org/jira/browse/SOLR-17585 Project: Solr Issue Type: Im

Re: [I] [Regression] security.json is not uploaded during the first initialization of SolrCloud [solr-operator]

2024-12-05 Thread via GitHub
mcarroll1 commented on issue #720: URL: https://github.com/apache/solr-operator/issues/720#issuecomment-2521532629 This is also blocking an upgrade for our team. Per @erwanval , it does seem like the zkcli returns error code `1` regardless of the issue. Would it be acceptable to rely on the