[PR] SOLR-17574: Move host allow list cache to AllowListUrlChecker. [solr]

2024-12-02 Thread via GitHub
bruno-roustant opened a new pull request, #2892: URL: https://github.com/apache/solr/pull/2892 Remove the host allow list cache from ClusterState and move it to it's only caller AllowListUrlChecker. There it is cached based on live nodes. -- This is an automated message from the Apache Gi

[jira] [Updated] (SOLR-17574) ClusterState getHostAllowList isn't always updated when live nodes change

2024-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17574: -- Labels: pull-request-available (was: ) > ClusterState getHostAllowList isn't always updated wh

[jira] [Created] (SOLR-17581) Less Zookeeper watches in tests

2024-12-02 Thread Pierre Salagnac (Jira)
Pierre Salagnac created SOLR-17581: -- Summary: Less Zookeeper watches in tests Key: SOLR-17581 URL: https://issues.apache.org/jira/browse/SOLR-17581 Project: Solr Issue Type: Improvement

[jira] [Commented] (SOLR-17577) solr.indexfetcher.sotimeout property in tests non used

2024-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902311#comment-17902311 ] ASF subversion and git services commented on SOLR-17577: Commit 5

Re: [PR] SOLR-17574: Move host allow list cache to AllowListUrlChecker. [solr]

2024-12-02 Thread via GitHub
dsmiley commented on code in PR #2892: URL: https://github.com/apache/solr/pull/2892#discussion_r1865912289 ## solr/core/src/test/org/apache/solr/security/AllowListUrlCheckerTest.java: ## @@ -196,6 +200,46 @@ public void testHostParsingNoProtocol() throws Exception { e

Re: [PR] SOLR-17576: Remove deprecated master/slave support in ReplicationHandler [solr]

2024-12-02 Thread via GitHub
epugh merged PR #2887: URL: https://github.com/apache/solr/pull/2887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17577) solr.indexfetcher.sotimeout property in tests non used

2024-12-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902319#comment-17902319 ] ASF subversion and git services commented on SOLR-17577: Commit 9

[jira] [Updated] (SOLR-17579) Remove unused methods in IndexFetcher and ReplicationHandler

2024-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17579: -- Labels: pull-request-available (was: ) > Remove unused methods in IndexFetcher and Replication

Re: [PR] SOLR-17577: Remove dead system property [solr]

2024-12-02 Thread via GitHub
epugh merged PR #2888: URL: https://github.com/apache/solr/pull/2888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[PR] SOLR-16781: Disable by default on 9.x [solr]

2024-12-02 Thread via GitHub
gerlowskija opened a new pull request, #2894: URL: https://github.com/apache/solr/pull/2894 https://issues.apache.org/jira/browse/SOLR-16781 # Description `` usage will now log a warning by default for future 9.x releases. Wary users can re-enabled the feature by specifying a

[jira] [Resolved] (SOLR-17576) Remove deprecated master/slave configuration support from Replication

2024-12-02 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17576. -- Fix Version/s: main (10.0) Assignee: Eric Pugh Resolution: Fixed > Remove deprecated ma

Re: [PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-12-02 Thread via GitHub
HoustonPutman commented on code in PR #2875: URL: https://github.com/apache/solr/pull/2875#discussion_r1866702118 ## solr/core/src/test-files/solr/configsets/upload/with-lib-directive/solrconfig.xml: ## @@ -37,8 +37,6 @@ ${tests.luceneMatchVersion:LATEST} - Review Comm

Re: [PR] SOLR-16781: Disable by default on 9.x [solr]

2024-12-02 Thread via GitHub
HoustonPutman commented on code in PR #2894: URL: https://github.com/apache/solr/pull/2894#discussion_r1866712826 ## solr/core/src/java/org/apache/solr/cli/RunExampleTool.java: ## @@ -620,10 +620,15 @@ protected Map startSolr( if (!isWindows && cwdPath.length() > 1 && solrH

Re: [PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-12-02 Thread via GitHub
gerlowskija commented on PR #2875: URL: https://github.com/apache/solr/pull/2875#issuecomment-2512047561 Alright - I've fixed merge conflicts, and tested out the examples, so this should be good to merge shortly. Thanks for the reviews all! I've created a corresponding change for bra

Re: [PR] SOLR-16781: Disable by default on 9.x [solr]

2024-12-02 Thread via GitHub
HoustonPutman commented on code in PR #2894: URL: https://github.com/apache/solr/pull/2894#discussion_r1866722807 ## solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java: ## @@ -70,6 +72,7 @@ public static void beforeClass() { Paths.get(".").toAbsolutePath(

Re: [PR] SOLR-17568: SolrCloud shouldn't proxy/route a core specific request [solr]

2024-12-02 Thread via GitHub
dsmiley merged PR #2885: URL: https://github.com/apache/solr/pull/2885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Resolved] (SOLR-17568) Remove remote *core* query in SolrCloud mode

2024-12-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17568. - Resolution: Fixed > Remove remote *core* query in SolrCloud mode > --

Re: [PR] SOLR-17310: Configurable LeafSorter to customize segment search order [solr]

2024-12-02 Thread via GitHub
github-actions[bot] commented on PR #2477: URL: https://github.com/apache/solr/pull/2477#issuecomment-2513226182 This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be fam

Re: [PR] SOLR-17574: Move host allow list cache to AllowListUrlChecker. [solr]

2024-12-02 Thread via GitHub
bruno-roustant commented on PR #2892: URL: https://github.com/apache/solr/pull/2892#issuecomment-2513761279 This is already changed. ClusterState.setLiveNodes sets the immutable copy and getLiveNodes gets its reference. -- This is an automated message from the Apache Git Service. To respo