Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-10-16 Thread via GitHub
janhoy commented on code in PR #2712: URL: https://github.com/apache/solr/pull/2712#discussion_r1802537974 ## gradle/testing/randomization/policies/solr-tests.policy: ## @@ -109,6 +109,8 @@ grant { permission java.lang.RuntimePermission "writeFileDescriptor"; // needed by

Re: [PR] Update dependency com.fasterxml.jackson:jackson-bom to v2.18.0 [solr]

2024-10-16 Thread via GitHub
janhoy merged PR #2769: URL: https://github.com/apache/solr/pull/2769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Bump up Java version to 21 [solr]

2024-10-16 Thread via GitHub
iamsanjay commented on PR #2682: URL: https://github.com/apache/solr/pull/2682#issuecomment-2415907145 JDK 14 Release Notes -XX:UseConcMarkSweepGC has been removed. I believe, we still using in solr.cmd.in. Other than that I have gone through the release notes and did'nt find an

Re: [PR] Update io.grpc:grpc-* to v1.68.0 [solr]

2024-10-16 Thread via GitHub
janhoy commented on PR #2639: URL: https://github.com/apache/solr/pull/2639#issuecomment-2416405035 What a mess https://github.com/user-attachments/assets/73683273-0583-4afa-87a0-30f001ba2aeb";> So in reality 1.67.1 is the latest version, but no dependency manager in the world will

[PR] Update dependency com.fasterxml.jackson:jackson-bom to v2.18.0 [solr]

2024-10-16 Thread via GitHub
solrbot opened a new pull request, #2769: URL: https://github.com/apache/solr/pull/2769 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.fasterxml.jackson:jackson-bom](https://redirect.github.com/FasterXML/jackson-bom) | depe

[PR] Update dependency org.semver4j:semver4j to v5.4.0 [solr]

2024-10-16 Thread via GitHub
solrbot opened a new pull request, #2770: URL: https://github.com/apache/solr/pull/2770 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.semver4j:semver4j](https://redirect.github.com/semver4j/semver4j) | dependencies | minor

[PR] Update org.apache.calcite to v1.38.0 [solr]

2024-10-16 Thread via GitHub
solrbot opened a new pull request, #2771: URL: https://github.com/apache/solr/pull/2771 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.calcite:calcite-linq4j](https://calcite.apache.org) ([source](https://redirect.git

[PR] Update org.apache.kafka:* to v3.8.0 [solr]

2024-10-16 Thread via GitHub
solrbot opened a new pull request, #2772: URL: https://github.com/apache/solr/pull/2772 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.kafka:kafka_2.13](https://kafka.apache.org) | dependencies | minor | `3.7.1` -> `3

[PR] Update org.apache.curator:* to v5.7.1 [solr]

2024-10-16 Thread via GitHub
solrbot opened a new pull request, #2768: URL: https://github.com/apache/solr/pull/2768 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.curator:curator-recipes](https://curator.apache.org) ([source](https://redirect.gi

Re: [PR] Bump up Java version to 21 [solr]

2024-10-16 Thread via GitHub
iamsanjay commented on PR #2682: URL: https://github.com/apache/solr/pull/2682#issuecomment-2415956590 Since JDK 14 https://openjdk.org/jeps/363 Concurrent Mark Sweep (CMS) garbage collector is removed. So may be can remove that and whatever is related to it (Which I am not fully aware of

Re: [PR] SOLR-17413: ulog replay should copy SolrQueryRequest [solr]

2024-10-16 Thread via GitHub
gerlowskija commented on code in PR #2765: URL: https://github.com/apache/solr/pull/2765#discussion_r1803271038 ## solr/core/src/java/org/apache/solr/update/UpdateLog.java: ## @@ -2097,10 +2098,19 @@ public void doReplay(TransactionLog translog) { UpdateRequestProcessor

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-10-16 Thread via GitHub
janhoy commented on code in PR #2712: URL: https://github.com/apache/solr/pull/2712#discussion_r1803388476 ## solr/server/etc/security.policy: ## @@ -228,4 +228,7 @@ grant { // expanded to a wildcard if set, allows all networking everywhere permission java.net.SocketPerm

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-10-16 Thread via GitHub
janhoy commented on code in PR #2712: URL: https://github.com/apache/solr/pull/2712#discussion_r1803391559 ## gradle/testing/randomization/policies/solr-tests.policy: ## @@ -109,6 +109,8 @@ grant { permission java.lang.RuntimePermission "writeFileDescriptor"; // needed by

[jira] [Resolved] (SOLR-17158) Terminate distributed processing quickly when query limit is reached

2024-10-16 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck resolved SOLR-17158. - Fix Version/s: main (10.0) 9.8 Resolution: Implemented > Terminate distributed

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-10-16 Thread via GitHub
janhoy commented on PR #2712: URL: https://github.com/apache/solr/pull/2712#issuecomment-2417306791 Did more testing. The output when starting Solr on Win was broken and printed the json status text on Win, while on Linux it still printed `Started Solr server on port (pid=6838). Happy

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-10-16 Thread via GitHub
janhoy commented on code in PR #2712: URL: https://github.com/apache/solr/pull/2712#discussion_r1803440828 ## solr/core/src/java/org/apache/solr/cli/StatusTool.java: ## @@ -65,72 +73,224 @@ public String getName() { .desc("Wait up to the specified number of seconds to

Re: [PR] SOLR-17158 Terminate distributed processing faster when query limits reached and partial results are not needed (#2666) [solr]

2024-10-16 Thread via GitHub
gus-asf merged PR #2773: URL: https://github.com/apache/solr/pull/2773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-17158) Terminate distributed processing quickly when query limit is reached

2024-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890108#comment-17890108 ] ASF subversion and git services commented on SOLR-17158: Commit 6

[jira] [Created] (SOLR-17499) Windows start script should wait 180 secs for Solr start

2024-10-16 Thread Jira
Jan Høydahl created SOLR-17499: -- Summary: Windows start script should wait 180 secs for Solr start Key: SOLR-17499 URL: https://issues.apache.org/jira/browse/SOLR-17499 Project: Solr Issue Type:

[jira] [Updated] (SOLR-17499) Windows start script should wait 180 secs for Solr start

2024-10-16 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-17499: --- Labels: Beginner beginner-friendly newdev (was: ) > Windows start script should wait 180 secs for So

Re: [PR] SOLR-17494: Document deprecation status of language specific writer types [solr]

2024-10-16 Thread via GitHub
gerlowskija commented on PR #2766: URL: https://github.com/apache/solr/pull/2766#issuecomment-2417053569 Should we have a CHANGES.txt entry mentioning the deprecation? That looks like a popular place that deprecations are highlighted... -- This is an automated message from the Apache Git

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-10-16 Thread via GitHub
epugh commented on code in PR #2712: URL: https://github.com/apache/solr/pull/2712#discussion_r1802975213 ## gradle/testing/randomization/policies/solr-tests.policy: ## @@ -109,6 +109,8 @@ grant { permission java.lang.RuntimePermission "writeFileDescriptor"; // needed by h

Re: [PR] SOLR-17413: ulog replay should copy SolrQueryRequest [solr]

2024-10-16 Thread via GitHub
gerlowskija commented on PR #2765: URL: https://github.com/apache/solr/pull/2765#issuecomment-2416735316 > Is the not-anymore-used req object still used somewhere else? Yes, actually! Meant to call this out in a comment here or in the code - the "original" LocalSolrQueryRequest is te

[PR] SOLR-17158 Terminate distributed processing faster when query limits reached and partial results are not needed (#2666) [solr]

2024-10-16 Thread via GitHub
gus-asf opened a new pull request, #2773: URL: https://github.com/apache/solr/pull/2773 backport -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: is

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-10-16 Thread via GitHub
malliaridis commented on PR #2706: URL: https://github.com/apache/solr/pull/2706#issuecomment-2417694767 I think it would be a good idea to first resolve the current solrbot PRs before aligning the versions. I am already looking into some of the PRs to see how they can be resolved. -- Th

Re: [PR] SOLR-17413: ulog replay should copy SolrQueryRequest [solr]

2024-10-16 Thread via GitHub
dsmiley commented on PR #2765: URL: https://github.com/apache/solr/pull/2765#issuecomment-2417910950 I'd like to contribute to this PR to replace the ThreadLocal with a re-using pool that we mostly already have. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] SOLR-17390: EmbeddedSolrServer now considers the ResponseParser [solr]

2024-10-16 Thread via GitHub
epugh commented on code in PR #2774: URL: https://github.com/apache/solr/pull/2774#discussion_r1803997991 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -934,13 +934,7 @@ protected void logAndFlushAdminRequest(SolrQueryResponse solrResp) throws IOExce

Re: [PR] SOLR-17485 Remove CheckLoggingConfiguration; unnecessary [solr]

2024-10-16 Thread via GitHub
dsmiley commented on PR #2763: URL: https://github.com/apache/solr/pull/2763#issuecomment-2418420895 Addressing your nit on renaming `_request` to `request` wasn't fully possible for various reasons at first, so I started pulling on that thread, doing some refactoring that ultimately led to

Re: [PR] Demonstrate a test framework bug [solr]

2024-10-16 Thread via GitHub
github-actions[bot] commented on PR #2242: URL: https://github.com/apache/solr/pull/2242#issuecomment-2418183084 This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. -- This

Re: [PR] Demonstrate a test framework bug [solr]

2024-10-16 Thread via GitHub
github-actions[bot] closed pull request #2242: Demonstrate a test framework bug URL: https://github.com/apache/solr/pull/2242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (SOLR-11872) Refactor test infra to work with a managed SolrClient; ditch TestHarness

2024-10-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890262#comment-17890262 ] David Smiley commented on SOLR-11872: - Note to self/others:  a test that best illustr

Re: [PR] SOLR-17390: EmbeddedSolrServer now considers the ResponseParser [solr]

2024-10-16 Thread via GitHub
dsmiley commented on code in PR #2774: URL: https://github.com/apache/solr/pull/2774#discussion_r1803994463 ## solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java: ## @@ -217,62 +218,18 @@ public NamedList request(SolrRequest request, String coreNam

Re: [PR] SOLR-17390: EmbeddedSolrServer now considers the ResponseParser [solr]

2024-10-16 Thread via GitHub
dsmiley commented on code in PR #2774: URL: https://github.com/apache/solr/pull/2774#discussion_r1804007364 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -934,13 +934,7 @@ protected void logAndFlushAdminRequest(SolrQueryResponse solrResp) throws IOExce

[PR] SOLR-17390: EmbeddedSolrServer now considers the ResponseParser [solr]

2024-10-16 Thread via GitHub
dsmiley opened a new pull request, #2774: URL: https://github.com/apache/solr/pull/2774 * Moved HttpSolrCall.getResponseWriter to SolrQueryRequest * Subtle improvements to make ContentStream work when they might not have https://issues.apache.org/jira/browse/SOLR-17390 -- This is

[jira] [Updated] (SOLR-17390) EmbeddedSolrServer should support a ResponseParser

2024-10-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17390: -- Labels: pull-request-available (was: ) > EmbeddedSolrServer should support a ResponseParser >

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-10-16 Thread via GitHub
epugh commented on code in PR #2712: URL: https://github.com/apache/solr/pull/2712#discussion_r1804003579 ## solr/core/src/java/org/apache/solr/cli/StatusTool.java: ## @@ -65,72 +73,224 @@ public String getName() { .desc("Wait up to the specified number of seconds to