dsmiley commented on PR #2706:
URL: https://github.com/apache/solr/pull/2706#issuecomment-2412356157
I think the next step is just some dependency version alignment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dsmiley opened a new pull request, #2763:
URL: https://github.com/apache/solr/pull/2763
Also note we extend HttpFilter instead of ServletFilter.
https://issues.apache.org/jira/browse/SOLR-17485
--
This is an automated message from the Apache Git Service.
To respond to the message, p
[
https://issues.apache.org/jira/browse/SOLR-17485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17485:
--
Labels: pull-request-available (was: )
> Remove Slf4j ClassNotFoundException avoidance checks
[
https://issues.apache.org/jira/browse/SOLR-17414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889319#comment-17889319
]
ASF subversion and git services commented on SOLR-17414:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889321#comment-17889321
]
ASF subversion and git services commented on SOLR-13350:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889320#comment-17889320
]
ASF subversion and git services commented on SOLR-17298:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-17456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17456:
--
Labels: pull-request-available (was: )
> TransactionLog NPE
> --
>
>
dsmiley opened a new pull request, #2762:
URL: https://github.com/apache/solr/pull/2762
The TransactionLog constructor can't handle an existing file being present;
it shouldn't be there. Should throw an exception in this case, NOT log a
warning, leaving the object in a partially constructe
dsmiley commented on code in PR #2762:
URL: https://github.com/apache/solr/pull/2762#discussion_r1800172613
##
solr/core/src/java/org/apache/solr/update/TransactionLog.java:
##
@@ -238,9 +240,6 @@ protected TransactionLog(
}
success = true;
-
- assert Object
iamsanjay commented on PR #2682:
URL: https://github.com/apache/solr/pull/2682#issuecomment-2412897758
If I set sourceCompatibility at the same level as "--release" flag then It
worked, which is basically set it the package level (main or test) instead of
Project. Now after this, We can use
iamsanjay commented on PR #2682:
URL: https://github.com/apache/solr/pull/2682#issuecomment-2412900492
Documentation from Intellij is very much relevant at package level as well.
For language level it looks at sourceCompatibility.
> Language level: the language level settings are app
dsmiley commented on PR #2682:
URL: https://github.com/apache/solr/pull/2682#issuecomment-2412901338
I see; it works!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
dsmiley commented on PR #2682:
URL: https://github.com/apache/solr/pull/2682#issuecomment-2412845114
As I mentioned, IntelliJ isn't recognizing the language distinction between
tests vs non-tests so I recommend simply using the same language per module.
Other than that, I suppose it's read
iamsanjay commented on PR #2682:
URL: https://github.com/apache/solr/pull/2682#issuecomment-2412913512
We may need to remove some of the compiler options as well. As they may not
be required anymore with the upgrade, also may be two different sets of
compiler options -- one for JDK 17 and a
janhoy commented on PR #2758:
URL: https://github.com/apache/solr/pull/2758#issuecomment-2412422930
Deprecate as notice in ref guide. Also we have a separate deprecation
logging mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
github-actions[bot] commented on PR #2637:
URL: https://github.com/apache/solr/pull/2637#issuecomment-2412549240
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
[
https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889249#comment-17889249
]
ASF subversion and git services commented on SOLR-17298:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-17414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889248#comment-17889248
]
ASF subversion and git services commented on SOLR-17414:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889250#comment-17889250
]
ASF subversion and git services commented on SOLR-13350:
Commit 7
dsmiley merged PR #2701:
URL: https://github.com/apache/solr/pull/2701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
epugh commented on PR #2761:
URL: https://github.com/apache/solr/pull/2761#issuecomment-2411861328
Leaving "tutorial-films.adoc" alone, as it uses `_default` and we wouldn't
want to delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
[
https://issues.apache.org/jira/browse/SOLR-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889281#comment-17889281
]
Jason Gerlowski commented on SOLR-17413:
bq. This should be somewhat straightforw
epugh commented on code in PR #129:
URL: https://github.com/apache/solr-site/pull/129#discussion_r1799876019
##
content/pages/blogposts/2024-10-14-community-over-code-na-birds-of-a-feather.md:
##
@@ -0,0 +1,11 @@
+Title: Community Over Code NA 2024 Apache Lucene/Solr Birds Of A
epugh commented on PR #129:
URL: https://github.com/apache/solr-site/pull/129#issuecomment-2411871664
thanks for feedback..I'd love a +1 or even a merge to get this done and
out the door ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
epugh commented on code in PR #2737:
URL: https://github.com/apache/solr/pull/2737#discussion_r1799884914
##
solr/core/src/test/org/apache/solr/cloud/TestRebalanceLeaders.java:
##
@@ -604,74 +572,61 @@ private void forceUpdateCollectionStatus() {
// Since we have to restart
gerlowskija commented on code in PR #129:
URL: https://github.com/apache/solr-site/pull/129#discussion_r1799405713
##
content/pages/blogposts/2024-10-14-community-over-code-na-birds-of-a-feather.md:
##
@@ -0,0 +1,11 @@
+Title: Community Over Code NA 2024 Apache Lucene/Solr Birds
gerlowskija commented on PR #129:
URL: https://github.com/apache/solr-site/pull/129#issuecomment-2411131166
> I saw the previous BoF blogpost
(https://github.com/apache/solr-site/pull/110) had a build failure as well. Is
it the same as here and not really an issue?
Looks like the "ac
[
https://issues.apache.org/jira/browse/SOLR-17150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrzej Bialecki updated SOLR-17150:
Fix Version/s: 9.8
> Create MemQueryLimit implementation
>
[
https://issues.apache.org/jira/browse/SOLR-17150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrzej Bialecki resolved SOLR-17150.
-
Resolution: Fixed
> Create MemQueryLimit implementation
> ---
malliaridis commented on code in PR #2712:
URL: https://github.com/apache/solr/pull/2712#discussion_r1799446120
##
solr/packaging/test/test_status.bats:
##
@@ -37,18 +37,27 @@ teardown() {
solr stop
run solr status
assert_output --partial "No Solr nodes are running."
+}
malliaridis commented on code in PR #2712:
URL: https://github.com/apache/solr/pull/2712#discussion_r1799446120
##
solr/packaging/test/test_status.bats:
##
@@ -37,18 +37,27 @@ teardown() {
solr stop
run solr status
assert_output --partial "No Solr nodes are running."
+}
epugh commented on code in PR #2761:
URL: https://github.com/apache/solr/pull/2761#discussion_r1799860269
##
solr/core/src/java/org/apache/solr/cli/DeleteTool.java:
##
@@ -198,13 +187,13 @@ protected void deleteCollection(CloudSolrClient
cloudSolrClient, CommandLine cli
dsmiley commented on PR #2737:
URL: https://github.com/apache/solr/pull/2737#issuecomment-2411992713
A line of javadocs on TimeOut recommending waitForState would be good but
perhaps arguably a distraction to a general utility -- :shrug: whatever. I
don't think we'll backslide much if all/
malliaridis commented on code in PR #2761:
URL: https://github.com/apache/solr/pull/2761#discussion_r1799701043
##
solr/core/src/java/org/apache/solr/cli/DeleteTool.java:
##
@@ -198,13 +187,13 @@ protected void deleteCollection(CloudSolrClient
cloudSolrClient, CommandLine cli
34 matches
Mail list logo
