psalagnac commented on code in PR #2278:
URL: https://github.com/apache/solr/pull/2278#discussion_r1624124928
##
solr/CHANGES.txt:
##
@@ -103,6 +103,7 @@ Optimizations
* GITHUB#2217: Scale to 10K+ collections better in
ZkStateReader.refreshCollectionsList (David Smiley)
+*
gus-asf commented on PR #23:
URL: https://github.com/apache/solr-docker/pull/23#issuecomment-2145182055
Removing support for old stuff seems like something that should involve
dev/user list discussion...
--
This is an automated message from the Apache Git Service.
To respond to the messag
alessandrobenedetti commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1624531316
##
solr/core/src/java/org/apache/solr/search/combining/ReciprocalRankFusion.java:
##
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
dsmiley commented on PR #2491:
URL: https://github.com/apache/solr/pull/2491#issuecomment-2145322947
`TestLBHttp2SolrClient.testTwoServers` seemed to fail because Crave was
running slow and hit a somewhat short timeout
--
This is an automated message from the Apache Git Service.
To respon
renatoh commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1624657341
##
solr/core/src/java/org/apache/solr/search/combining/ReciprocalRankFusion.java:
##
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
noblepaul merged PR #2458:
URL: https://github.com/apache/solr/pull/2458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
[
https://issues.apache.org/jira/browse/SOLR-17272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851715#comment-17851715
]
ASF subversion and git services commented on SOLR-17272:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-16654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851733#comment-17851733
]
Michael Gibney commented on SOLR-16654:
---
Thanks for the heads-up. I dug into this a
gerlowskija opened a new pull request, #2492:
URL: https://github.com/apache/solr/pull/2492
# Description
Cursormark can give some funky results if used across multiple replicas in a
SolrCloud collection, if `score` is used as a sort field. But there's not
currently any warning of t
hiteshk25 opened a new pull request, #2493:
URL: https://github.com/apache/solr/pull/2493
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Hitesh Khamesra created SOLR-17320:
--
Summary: HttpShardHandler should obey `timeAllowed` parameter in
query
Key: SOLR-17320
URL: https://issues.apache.org/jira/browse/SOLR-17320
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-17320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hitesh Khamesra updated SOLR-17320:
---
Description:
HttpShardHandler should use `timeAllowed` param in query to timeout for any
sha
gerlowskija commented on PR #2479:
URL: https://github.com/apache/solr/pull/2479#issuecomment-2145825393
A few high-level questions/concerns:
1. `bin/solr` already has an "api" tool, which can be used to invoke
streaming expressions e.g. `bin/solr api -get
"$SOLR_URL/techproducts/str
gerlowskija commented on code in PR #2455:
URL: https://github.com/apache/solr/pull/2455#discussion_r1624867836
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java:
##
@@ -56,6 +63,51 @@ public static Collection toContentStreams(
return streams;
}
gerlowskija commented on code in PR #2455:
URL: https://github.com/apache/solr/pull/2455#discussion_r1624884632
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java:
##
@@ -56,6 +63,51 @@ public static Collection toContentStreams(
return streams;
}
dsmiley opened a new pull request, #2494:
URL: https://github.com/apache/solr/pull/2494
and RequestWriter.getPath
https://issues.apache.org/jira/browse/SOLR-17256
First commit is deprecation; maybe just take this PR now and then follow up
in another PR with replacements and re
[
https://issues.apache.org/jira/browse/SOLR-17320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hitesh Khamesra updated SOLR-17320:
---
Description:
HttpShardHandler should use `timeAllowed` param in query to timeout for any
sha
dsmiley commented on code in PR #2455:
URL: https://github.com/apache/solr/pull/2455#discussion_r1624900136
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java:
##
@@ -56,6 +63,51 @@ public static Collection toContentStreams(
return streams;
}
+
dsmiley commented on PR #2491:
URL: https://github.com/apache/solr/pull/2491#issuecomment-2146223629
`org.apache.solr.cloud.TestLeaderElectionZkExpiry` failed due to leaked
threads in test (that terminated eventually). Also not related to this change.
Will comment on https://issues.apache
[
https://issues.apache.org/jira/browse/SOLR-16122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851833#comment-17851833
]
David Smiley commented on SOLR-16122:
-
This test seems to fail due to thread leaks.
patsonluk commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1625146172
##
solr/core/src/java/org/apache/solr/core/ConfigSetService.java:
##
@@ -391,6 +402,21 @@ protected NamedList
loadConfigSetFlags(SolrResourceLoader loader) throws
*
patsonluk commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1625146698
##
solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java:
##
@@ -105,14 +102,11 @@ public void testSimple() throws Exception {
assertEquals(10, rsl
patsonluk commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1625146698
##
solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java:
##
@@ -105,14 +102,11 @@ public void testSimple() throws Exception {
assertEquals(10, rsl
janhoy commented on PR #23:
URL: https://github.com/apache/solr-docker/pull/23#issuecomment-2146299104
The history here is that right after the 9.6 release I upgraded a cluster on
my M1 Mac to the new version, but got some strange errors, Solr would not
start, but threw some weird low-level
patsonluk commented on PR #2438:
URL: https://github.com/apache/solr/pull/2438#issuecomment-2146314074
@dsmiley @noblepaul Many thanks for the helpful code review!
I have pushed some changes based on the suggestions, would you mind to
review again? 🙏🏼
--
This is an automated messa
dsmiley commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1625218938
##
solr/core/src/java/org/apache/solr/core/ConfigSetService.java:
##
@@ -391,6 +402,21 @@ protected NamedList
loadConfigSetFlags(SolrResourceLoader loader) throws
*/
dsmiley commented on PR #23:
URL: https://github.com/apache/solr-docker/pull/23#issuecomment-2146399330
I'd imagine such a user that expects/required 32 bit would find out
relatively quickly; it's not a subtle thing. It works or it doesn't. So IMO
no need to announce-to/warn users.
--
[
https://issues.apache.org/jira/browse/SOLR-15447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851880#comment-17851880
]
ASF subversion and git services commented on SOLR-15447:
Commit c
dsmiley merged PR #2487:
URL: https://github.com/apache/solr/pull/2487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-15447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851882#comment-17851882
]
ASF subversion and git services commented on SOLR-15447:
Commit 2
[
https://issues.apache.org/jira/browse/SOLR-15447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-15447.
-
Fix Version/s: 9.7
Assignee: David Smiley
Resolution: Fixed
> Reproduce with line
31 matches
Mail list logo