Re: [PR] SOLR-17099: snitch does not return spurious tags [solr]

2024-06-03 Thread via GitHub
psalagnac commented on code in PR #2278: URL: https://github.com/apache/solr/pull/2278#discussion_r1624124928 ## solr/CHANGES.txt: ## @@ -103,6 +103,7 @@ Optimizations * GITHUB#2217: Scale to 10K+ collections better in ZkStateReader.refreshCollectionsList (David Smiley) +*

Re: [PR] Upgrade stackbrew, fix gitCommit, remove 32bit images [solr-docker]

2024-06-03 Thread via GitHub
gus-asf commented on PR #23: URL: https://github.com/apache/solr-docker/pull/23#issuecomment-2145182055 Removing support for old stuff seems like something that should involve dev/user list discussion... -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Introduce support for Reciprocal Rank Fusion (combining queries) [solr]

2024-06-03 Thread via GitHub
alessandrobenedetti commented on code in PR #2489: URL: https://github.com/apache/solr/pull/2489#discussion_r1624531316 ## solr/core/src/java/org/apache/solr/search/combining/ReciprocalRankFusion.java: ## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Refactor duplication in UpdateLog.init [solr]

2024-06-03 Thread via GitHub
dsmiley commented on PR #2491: URL: https://github.com/apache/solr/pull/2491#issuecomment-2145322947 `TestLBHttp2SolrClient.testTwoServers` seemed to fail because Crave was running slow and hit a somewhat short timeout -- This is an automated message from the Apache Git Service. To respon

Re: [PR] Introduce support for Reciprocal Rank Fusion (combining queries) [solr]

2024-06-03 Thread via GitHub
renatoh commented on code in PR #2489: URL: https://github.com/apache/solr/pull/2489#discussion_r1624657341 ## solr/core/src/java/org/apache/solr/search/combining/ReciprocalRankFusion.java: ## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] SOLR-17272: PerReplicaState: Replica "state" and "leader" are still in state.json [solr]

2024-06-03 Thread via GitHub
noblepaul merged PR #2458: URL: https://github.com/apache/solr/pull/2458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-17272) PerReplicaState: Replica "state" and "leader" are still in state.json

2024-06-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851715#comment-17851715 ] ASF subversion and git services commented on SOLR-17272: Commit 7

[jira] [Commented] (SOLR-16654) Add support for node-level caches

2024-06-03 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851733#comment-17851733 ] Michael Gibney commented on SOLR-16654: --- Thanks for the heads-up. I dug into this a

[PR] Add 'score' field caveat to cursormark docs [solr]

2024-06-03 Thread via GitHub
gerlowskija opened a new pull request, #2492: URL: https://github.com/apache/solr/pull/2492 # Description Cursormark can give some funky results if used across multiple replicas in a SolrCloud collection, if `score` is used as a sort field. But there's not currently any warning of t

[PR] Added support for timeAllowed time out in HttpShardHandler [solr]

2024-06-03 Thread via GitHub
hiteshk25 opened a new pull request, #2493: URL: https://github.com/apache/solr/pull/2493 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution

[jira] [Created] (SOLR-17320) HttpShardHandler should obey `timeAllowed` parameter in query

2024-06-03 Thread Hitesh Khamesra (Jira)
Hitesh Khamesra created SOLR-17320: -- Summary: HttpShardHandler should obey `timeAllowed` parameter in query Key: SOLR-17320 URL: https://issues.apache.org/jira/browse/SOLR-17320 Project: Solr

[jira] [Updated] (SOLR-17320) HttpShardHandler should obey `timeAllowed` parameter in query

2024-06-03 Thread Hitesh Khamesra (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Khamesra updated SOLR-17320: --- Description: HttpShardHandler should use `timeAllowed` param in query to timeout for any sha

Re: [PR] SOLR-14673: Add bin/solr stream CLI [solr]

2024-06-03 Thread via GitHub
gerlowskija commented on PR #2479: URL: https://github.com/apache/solr/pull/2479#issuecomment-2145825393 A few high-level questions/concerns: 1. `bin/solr` already has an "api" tool, which can be used to invoke streaming expressions e.g. `bin/solr api -get "$SOLR_URL/techproducts/str

Re: [PR] SOLR-17044: Consolidate SolrJ URL-building logic [solr]

2024-06-03 Thread via GitHub
gerlowskija commented on code in PR #2455: URL: https://github.com/apache/solr/pull/2455#discussion_r1624867836 ## solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java: ## @@ -56,6 +63,51 @@ public static Collection toContentStreams( return streams; }

Re: [PR] SOLR-17044: Consolidate SolrJ URL-building logic [solr]

2024-06-03 Thread via GitHub
gerlowskija commented on code in PR #2455: URL: https://github.com/apache/solr/pull/2455#discussion_r1624884632 ## solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java: ## @@ -56,6 +63,51 @@ public static Collection toContentStreams( return streams; }

[PR] SOLR-17256: Deprecate SolrRequest get/set BasePath [solr]

2024-06-03 Thread via GitHub
dsmiley opened a new pull request, #2494: URL: https://github.com/apache/solr/pull/2494 and RequestWriter.getPath https://issues.apache.org/jira/browse/SOLR-17256 First commit is deprecation; maybe just take this PR now and then follow up in another PR with replacements and re

[jira] [Updated] (SOLR-17320) HttpShardHandler should obey `timeAllowed` parameter in query

2024-06-03 Thread Hitesh Khamesra (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Khamesra updated SOLR-17320: --- Description: HttpShardHandler should use `timeAllowed` param in query to timeout for any sha

Re: [PR] SOLR-17044: Consolidate SolrJ URL-building logic [solr]

2024-06-03 Thread via GitHub
dsmiley commented on code in PR #2455: URL: https://github.com/apache/solr/pull/2455#discussion_r1624900136 ## solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java: ## @@ -56,6 +63,51 @@ public static Collection toContentStreams( return streams; } +

Re: [PR] Refactor duplication in UpdateLog.init [solr]

2024-06-03 Thread via GitHub
dsmiley commented on PR #2491: URL: https://github.com/apache/solr/pull/2491#issuecomment-2146223629 `org.apache.solr.cloud.TestLeaderElectionZkExpiry` failed due to leaked threads in test (that terminated eventually). Also not related to this change. Will comment on https://issues.apache

[jira] [Commented] (SOLR-16122) TestLeaderElectionZkExpiry failing frequently

2024-06-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851833#comment-17851833 ] David Smiley commented on SOLR-16122: - This test seems to fail due to thread leaks.

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-03 Thread via GitHub
patsonluk commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1625146172 ## solr/core/src/java/org/apache/solr/core/ConfigSetService.java: ## @@ -391,6 +402,21 @@ protected NamedList loadConfigSetFlags(SolrResourceLoader loader) throws *

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-03 Thread via GitHub
patsonluk commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1625146698 ## solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java: ## @@ -105,14 +102,11 @@ public void testSimple() throws Exception { assertEquals(10, rsl

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-03 Thread via GitHub
patsonluk commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1625146698 ## solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java: ## @@ -105,14 +102,11 @@ public void testSimple() throws Exception { assertEquals(10, rsl

Re: [PR] Upgrade stackbrew, fix gitCommit, remove 32bit images [solr-docker]

2024-06-03 Thread via GitHub
janhoy commented on PR #23: URL: https://github.com/apache/solr-docker/pull/23#issuecomment-2146299104 The history here is that right after the 9.6 release I upgraded a cluster on my M1 Mac to the new version, but got some strange errors, Solr would not start, but threw some weird low-level

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-03 Thread via GitHub
patsonluk commented on PR #2438: URL: https://github.com/apache/solr/pull/2438#issuecomment-2146314074 @dsmiley @noblepaul Many thanks for the helpful code review! I have pushed some changes based on the suggestions, would you mind to review again? 🙏🏼 -- This is an automated messa

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-03 Thread via GitHub
dsmiley commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1625218938 ## solr/core/src/java/org/apache/solr/core/ConfigSetService.java: ## @@ -391,6 +402,21 @@ protected NamedList loadConfigSetFlags(SolrResourceLoader loader) throws */

Re: [PR] Upgrade stackbrew, fix gitCommit, remove 32bit images [solr-docker]

2024-06-03 Thread via GitHub
dsmiley commented on PR #23: URL: https://github.com/apache/solr-docker/pull/23#issuecomment-2146399330 I'd imagine such a user that expects/required 32 bit would find out relatively quickly; it's not a subtle thing. It works or it doesn't. So IMO no need to announce-to/warn users. --

[jira] [Commented] (SOLR-15447) Reproduce with line inaccurate for class methods

2024-06-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851880#comment-17851880 ] ASF subversion and git services commented on SOLR-15447: Commit c

Re: [PR] Build: report test history via GE [solr]

2024-06-03 Thread via GitHub
dsmiley merged PR #2487: URL: https://github.com/apache/solr/pull/2487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-15447) Reproduce with line inaccurate for class methods

2024-06-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851882#comment-17851882 ] ASF subversion and git services commented on SOLR-15447: Commit 2

[jira] [Resolved] (SOLR-15447) Reproduce with line inaccurate for class methods

2024-06-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15447. - Fix Version/s: 9.7 Assignee: David Smiley Resolution: Fixed > Reproduce with line