[PR] Add `alwaysStopwords` option to `edismax` so its "all stopwords" behaviour can be controlled [solr]

2024-05-31 Thread via GitHub
andywebb1975 opened a new pull request, #2488: URL: https://github.com/apache/solr/pull/2488 _work in progress!_ If anyone sees this and has thoughts on it, please comment below :-) # Description We were surprised by `edismax`'s behaviour for pure-stopword queries, having expe

Re: [PR] SOLR-17137 Add configuration for SSL between Solr and Prometheus exporter. [solr]

2024-05-31 Thread via GitHub
epugh commented on PR #2232: URL: https://github.com/apache/solr/pull/2232#issuecomment-2141971072 @eivinhb this looks great. How do you want to be credited in `solr/CHANGES.txt`. I'm thinking this is an improvement under 9.7... "Enable SSL protected Solr to communicate with Prometheus e

Re: [PR] SOLR-17137 Add configuration for SSL between Solr and Prometheus exporter. [solr]

2024-05-31 Thread via GitHub
eivinhb commented on PR #2232: URL: https://github.com/apache/solr/pull/2232#issuecomment-2142021688 Great! My name is "Eivind Bergstøl". I think that what you suggest is nice. :) I might argue that it is the other way around: `Enable Prometheus exporter to communicate with SSL protec

Re: [PR] SOLR-17137 Add configuration for SSL between Solr and Prometheus exporter. [solr]

2024-05-31 Thread via GitHub
epugh commented on PR #2232: URL: https://github.com/apache/solr/pull/2232#issuecomment-2142048792 I like your edit! Can you confirm I can push to your branch? alternatively, can you add to improvemetns for solr 9.7: ``` * SOLR-17137: Enable Prometheus exporter to communicate w

Re: [PR] SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands [solr]

2024-05-31 Thread via GitHub
janhoy commented on PR #1768: URL: https://github.com/apache/solr/pull/1768#issuecomment-2142070166 1.8.0 is out, will merge the renovate PR https://github.com/apache/solr/pull/2481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Update dependency commons-cli:commons-cli to v1.8.0 [solr]

2024-05-31 Thread via GitHub
janhoy merged PR #2481: URL: https://github.com/apache/solr/pull/2481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands [solr]

2024-05-31 Thread via GitHub
janhoy commented on code in PR #1768: URL: https://github.com/apache/solr/pull/1768#discussion_r1622383331 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -80,30 +83,72 @@ public class SolrCLI implements CLIO { public static final String ZK_HOST = "localhost:9

Re: [PR] SOLR-17137 Add configuration for SSL between Solr and Prometheus exporter. [solr]

2024-05-31 Thread via GitHub
eivinhb commented on PR #2232: URL: https://github.com/apache/solr/pull/2232#issuecomment-2142115625 Since I forked this under an organisation there is no way to give you the permission to the PR. Should I edit the file in a separate commit or the same one? -- This is an automated messag

[PR] Build site with github action [solr-site]

2024-05-31 Thread via GitHub
janhoy opened a new pull request, #99: URL: https://github.com/apache/solr-site/pull/99 Ref email to PMC and instructions at https://cwiki.apache.org/confluence/display/INFRA/Moving+from+Infrastructure-pelican+to+GitHub+Actions -- This is an automated message from the Apache Git Service.

Re: [PR] SOLR-10654: Introduce output of Prometheus metrics for Solr Core registry [solr]

2024-05-31 Thread via GitHub
mlbiscoc commented on PR #2405: URL: https://github.com/apache/solr/pull/2405#issuecomment-2142176578 > What's here looks good to me. Just need to add more; lots more metrics. Maybe it'll evolve a little once you add another category. My interest on this at-work is not the core metrics but

Re: [PR] SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands [solr]

2024-05-31 Thread via GitHub
epugh commented on PR #1768: URL: https://github.com/apache/solr/pull/1768#issuecomment-2142189297 @janhoy I ran a bit out of steam while waiting for 1.8.0, please do feel free to continue to push this PR along ;-). -- This is an automated message from the Apache Git Service. To respond

Re: [PR] SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands [solr]

2024-05-31 Thread via GitHub
janhoy commented on PR #1768: URL: https://github.com/apache/solr/pull/1768#issuecomment-2142193420 I had a thought now that `bin/solr` supports a remote Solr cluster with `--solr-url`. We currently support `solr version` which prints the version from `SolrVersion.java`, i.e. the client ver

Re: [PR] SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands [solr]

2024-05-31 Thread via GitHub
epugh commented on PR #1768: URL: https://github.com/apache/solr/pull/1768#issuecomment-2142200406 > I had a thought now that `bin/solr` supports a remote Solr cluster with `--solr-url`. We currently support `solr version` which prints the version from `SolrVersion.java`, i.e. the client ve

[jira] [Created] (SOLR-17318) bin/solr version should take a -z or -s and return actual version.

2024-05-31 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-17318: Summary: bin/solr version should take a -z or -s and return actual version. Key: SOLR-17318 URL: https://issues.apache.org/jira/browse/SOLR-17318 Project: Solr Issu

[jira] [Created] (SOLR-17319) Introduce support for Reciprocal Rank Fusion (combining queries)

2024-05-31 Thread Alessandro Benedetti (Jira)
Alessandro Benedetti created SOLR-17319: --- Summary: Introduce support for Reciprocal Rank Fusion (combining queries) Key: SOLR-17319 URL: https://issues.apache.org/jira/browse/SOLR-17319 Project:

[jira] [Commented] (SOLR-17319) Introduce support for Reciprocal Rank Fusion (combining queries)

2024-05-31 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851114#comment-17851114 ] Alessandro Benedetti commented on SOLR-17319: - This issue solve an outstandin

[jira] [Assigned] (SOLR-17319) Introduce support for Reciprocal Rank Fusion (combining queries)

2024-05-31 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti reassigned SOLR-17319: --- Assignee: Alessandro Benedetti > Introduce support for Reciprocal Rank Fusio

Re: [PR] SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands [solr]

2024-05-31 Thread via GitHub
janhoy commented on PR #1768: URL: https://github.com/apache/solr/pull/1768#issuecomment-2142276698 Did a few low hanging ones -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Updated] (SOLR-17319) Introduce support for Reciprocal Rank Fusion (combining queries)

2024-05-31 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated SOLR-17319: Description: Reciprocal Rank Fusion (RRF) is an algorithm that takes in input multi

[jira] [Updated] (SOLR-17319) Introduce support for Reciprocal Rank Fusion (combining queries)

2024-05-31 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated SOLR-17319: Description: Reciprocal Rank Fusion (RRF) is an algorithm that takes in input multi

Re: [PR] SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands [solr]

2024-05-31 Thread via GitHub
epugh commented on PR #1768: URL: https://github.com/apache/solr/pull/1768#issuecomment-2142295192 thanks for tackling those.. I would love to get more of the string parsing out of the scripts for solr.. I went back and looked at them, and I think that for the various commands not relat

[jira] [Comment Edited] (SOLR-17319) Introduce support for Reciprocal Rank Fusion (combining queries)

2024-05-31 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851114#comment-17851114 ] Alessandro Benedetti edited comment on SOLR-17319 at 5/31/24 2:12 PM: -

[PR] Introduce support for Reciprocal Rank Fusion (combining queries) [solr]

2024-05-31 Thread via GitHub
alessandrobenedetti opened a new pull request, #2489: URL: https://github.com/apache/solr/pull/2489 https://issues.apache.org/jira/browse/SOLR-17319 # Description Reciprocal Rank Fusion (RRF) is an algorithm that takes in input multiple ranked lists to produce a unified result

Re: [PR] Introduce support for Reciprocal Rank Fusion (combining queries) [solr]

2024-05-31 Thread via GitHub
alessandrobenedetti commented on PR #2489: URL: https://github.com/apache/solr/pull/2489#issuecomment-2142359815 As of today the solution is clean enough to be reviewed and tests are green. The usage is intuitive and it should cover many use cases. Pending activities: - add a new doc

Re: [PR] SOLR-10654: Introduce output of Prometheus metrics for Solr Core registry [solr]

2024-05-31 Thread via GitHub
dsmiley commented on PR #2405: URL: https://github.com/apache/solr/pull/2405#issuecomment-2142527945 It doesn't feel right to merge this PR right now. Needs docs. Also the choice of what metrics are done so far is inverted from the value that would make most sense for this whole approach

Re: [PR] Correct command to reproduce test with a failure in classMethod [solr]

2024-05-31 Thread via GitHub
AndreyBozhko commented on PR #2483: URL: https://github.com/apache/solr/pull/2483#issuecomment-2142615599 Looks like this may be superseded by https://github.com/apache/solr/pull/2487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (SOLR-15447) Reproduce with line inaccurate for class methods

2024-05-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851168#comment-17851168 ] David Smiley commented on SOLR-15447: - Will be fixed by the linked PR https://github.

Re: [PR] Correct command to reproduce test with a failure in classMethod [solr]

2024-05-31 Thread via GitHub
dsmiley commented on PR #2483: URL: https://github.com/apache/solr/pull/2483#issuecomment-2142758098 Yes I think this should be closed as incorporated by #2487 . Feel free to provide any further feedback there! -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] SOLR-17137 Add configuration for SSL between Solr and Prometheus exporter. [solr]

2024-05-31 Thread via GitHub
epugh merged PR #2232: URL: https://github.com/apache/solr/pull/2232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17137) Prometheus-exporter support SSL on Solr standalone

2024-05-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851173#comment-17851173 ] ASF subversion and git services commented on SOLR-17137: Commit 5

Re: [PR] SOLR-17137 Add configuration for SSL between Solr and Prometheus exporter. [solr]

2024-05-31 Thread via GitHub
epugh commented on PR #2232: URL: https://github.com/apache/solr/pull/2232#issuecomment-2142792815 thank you fro this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[jira] [Resolved] (SOLR-17137) Prometheus-exporter support SSL on Solr standalone

2024-05-31 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17137. -- Fix Version/s: 9.7 Assignee: Eric Pugh Resolution: Fixed > Prometheus-exporter support

[jira] [Commented] (SOLR-17137) Prometheus-exporter support SSL on Solr standalone

2024-05-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851176#comment-17851176 ] ASF subversion and git services commented on SOLR-17137: Commit 3

Re: [PR] Build: report test history via GE [solr]

2024-05-31 Thread via GitHub
AndreyBozhko commented on PR #2487: URL: https://github.com/apache/solr/pull/2487#issuecomment-2142819005 LGTM - just echoing the comment from @gus-asf: https://github.com/apache/solr/pull/2483#issuecomment-2138043439 > if we are touching this lets add a ./ on the front of the command

Re: [PR] Correct command to reproduce test with a failure in classMethod [solr]

2024-05-31 Thread via GitHub
AndreyBozhko closed pull request #2483: Correct command to reproduce test with a failure in classMethod URL: https://github.com/apache/solr/pull/2483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Move setShardAttributesToParams [solr]

2024-05-31 Thread via GitHub
dsmiley merged PR #2486: URL: https://github.com/apache/solr/pull/2486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-16093: Tests: don't require IPv6 [solr]

2024-05-31 Thread via GitHub
dsmiley merged PR #2484: URL: https://github.com/apache/solr/pull/2484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-16093) Tests should not require a working IPv6 networking stack

2024-05-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851193#comment-17851193 ] ASF subversion and git services commented on SOLR-16093: Commit 5

[jira] [Commented] (SOLR-16093) Tests should not require a working IPv6 networking stack

2024-05-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851231#comment-17851231 ] ASF subversion and git services commented on SOLR-16093: Commit 8

Re: [PR] SOLR-17271: PerReplicaState: Shard leader elections still impact state.json [solr]

2024-05-31 Thread via GitHub
noblepaul merged PR #2443: URL: https://github.com/apache/solr/pull/2443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-17271) PerReplicaState: Shard leader elections still impact state.json

2024-05-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851233#comment-17851233 ] ASF subversion and git services commented on SOLR-17271: Commit b

[jira] [Commented] (SOLR-17271) PerReplicaState: Shard leader elections still impact state.json

2024-05-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851235#comment-17851235 ] ASF subversion and git services commented on SOLR-17271: Commit c

[PR] Update org.mockito:mockito* to v5.12.0 [solr]

2024-05-31 Thread via GitHub
solrbot opened a new pull request, #2490: URL: https://github.com/apache/solr/pull/2490 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.mockito:mockito-subclass](https://togithub.com/mockito/mockito) | test | minor | `5.11.0`

[jira] [Resolved] (SOLR-16093) Tests should not require a working IPv6 networking stack

2024-05-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-16093. - Fix Version/s: 9.7 Resolution: Fixed > Tests should not require a working IPv6 networking

Re: [PR] fix Lucene[95-->99] typo in SchemaCodecFactory javadocs [solr]

2024-05-31 Thread via GitHub
dsmiley commented on code in PR #2478: URL: https://github.com/apache/solr/pull/2478#discussion_r1623083017 ## solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java: ## @@ -151,7 +151,7 @@ public Codec getCodec() { } /** - * This class exists because Lucene95

Re: [PR] SOLR-17118: Simplify CoreContainerProvider initialization [solr]

2024-05-31 Thread via GitHub
dsmiley merged PR #2474: URL: https://github.com/apache/solr/pull/2474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-17118) Solr deadlock during servlet container start

2024-05-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851239#comment-17851239 ] ASF subversion and git services commented on SOLR-17118: Commit 1

Re: [PR] SOLR-17301: Support all types of requests in rate limiting [solr]

2024-05-31 Thread via GitHub
dsmiley commented on code in PR #2469: URL: https://github.com/apache/solr/pull/2469#discussion_r1623101435 ## solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java: ## @@ -58,7 +59,21 @@ public enum SolrRequestType { SECURITY, ADMIN, STREAMING, -U

[jira] [Commented] (SOLR-15715) Dedicated query coordinator nodes in the solr cluster

2024-05-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851243#comment-17851243 ] David Smiley commented on SOLR-15715: - Gus, without this feature, how does one get a

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-05-31 Thread via GitHub
dsmiley commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1623133317 ## solr/core/src/java/org/apache/solr/core/ConfigSetService.java: ## @@ -391,6 +402,21 @@ protected NamedList loadConfigSetFlags(SolrResourceLoader loader) throws */

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-05-31 Thread via GitHub
dsmiley commented on PR #2438: URL: https://github.com/apache/solr/pull/2438#issuecomment-2143261736 I noticed you tagged nobody for review; it's good to think of one two pertinent people. -- This is an automated message from the Apache Git Service. To respond to the message, please log o