eivinhb commented on PR #2232:
URL: https://github.com/apache/solr/pull/2232#issuecomment-2138874485
@epugh I have amended the commit and added documentation and fixed an error
in the cmd-file as well.
I looked into the .bats tests, and I cant find any tests for the exporter at
all. Did
epugh commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1620568318
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -329,4 +355,8 @@ private static MetricsConfiguration
loadMetricsConfigurat
dsmiley commented on PR #2487:
URL: https://github.com/apache/solr/pull/2487#issuecomment-2139470717
Added fucit.org now like so:
```
Test history:
https://ge.apache.org/scans/tests?search.rootProjectNames=solr-root&tests.container=org.apache.solr.search.TestThinCache&tests.test=testSi
[
https://issues.apache.org/jira/browse/SOLR-17316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-17316:
---
Summary: SolrResponseBase getters should work with all ResponseParsers
(was: SolrResponseBa
Jason Gerlowski created SOLR-17316:
--
Summary: SolrResponseBase getters should work for with all
ResponseParsers
Key: SOLR-17316
URL: https://issues.apache.org/jira/browse/SOLR-17316
Project: Solr
Jason Gerlowski created SOLR-17317:
--
Summary: JAX-RS v2 APIs return XML when wt=json specified
Key: SOLR-17317
URL: https://issues.apache.org/jira/browse/SOLR-17317
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/SOLR-17316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850726#comment-17850726
]
Eric Pugh commented on SOLR-17316:
--
I wonder if we would do better to either fix the iss
gerlowskija commented on PR #2470:
URL: https://github.com/apache/solr/pull/2470#issuecomment-2139638871
I've since noticed two problems with this PR:
1. The generated SolrRequest class for uploading files doesn't handle the
request body correctly, making it largely unusable. We can
epugh commented on PR #2471:
URL: https://github.com/apache/solr/pull/2471#issuecomment-2139655943
@AndreyBozhko give me a ping when this is syned with main!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gerlowskija commented on PR #2471:
URL: https://github.com/apache/solr/pull/2471#issuecomment-2139661307
Hi @AndreyBozhko - sorry for the delay in unblocking this.
The reason your test started failing is that [my recent
commit](https://github.com/apache/solr/commit/8c5ae1bb745869ebd6f
[
https://issues.apache.org/jira/browse/SOLR-17302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850761#comment-17850761
]
ASF subversion and git services commented on SOLR-17302:
Commit f
gerlowskija commented on PR #2471:
URL: https://github.com/apache/solr/pull/2471#issuecomment-2139909782
I've reverted my commit on main to get this unblocked, and merged 'main'
into the PR branch. The test passes for me locally now. Let me know if
there's any other issues @AndreyBozhko /
AndreyBozhko commented on PR #2471:
URL: https://github.com/apache/solr/pull/2471#issuecomment-2140018509
Thanks @gerlowskija, appreciate you looking into this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
markrmiller commented on PR #2461:
URL: https://github.com/apache/solr/pull/2461#issuecomment-2140107187
Leaving Draft state on still on this one, but last commit brings it closer
to what I had in mind. Still have to review it and run tests.
--
This is an automated message from the Apache
eivinhb commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1621089402
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -329,4 +355,8 @@ private static MetricsConfiguration
loadMetricsConfigur
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1621158441
##
solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateRequestProcessor.java:
##
@@ -0,0 +1,257 @@
+/*
+ *
+ * * Licensed to the Apache Software
HoustonPutman opened a new pull request, #23:
URL: https://github.com/apache/solr-docker/pull/23
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
HoustonPutman merged PR #23:
URL: https://github.com/apache/solr-docker/pull/23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.
epugh commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1621236557
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -329,4 +355,8 @@ private static MetricsConfiguration
loadMetricsConfigurat
HoustonPutman commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1621254820
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -329,4 +355,8 @@ private static MetricsConfiguration
loadMetricsCo
epugh commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1621262667
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -329,4 +355,8 @@ private static MetricsConfiguration
loadMetricsConfigurat
epugh commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1621264416
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -329,4 +355,8 @@ private static MetricsConfiguration
loadMetricsConfigurat
dsmiley commented on code in PR #2455:
URL: https://github.com/apache/solr/pull/2455#discussion_r1621361826
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java:
##
@@ -56,6 +63,51 @@ public static Collection toContentStreams(
return streams;
}
+
eivinhb commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1621372850
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -329,4 +355,8 @@ private static MetricsConfiguration
loadMetricsConfigur
eivinhb commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1621372850
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -329,4 +355,8 @@ private static MetricsConfiguration
loadMetricsConfigur
eivinhb commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1621403062
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -329,4 +355,8 @@ private static MetricsConfiguration
loadMetricsConfigur
eivinhb commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1621407173
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -329,4 +355,8 @@ private static MetricsConfiguration
loadMetricsConfigur
epugh commented on PR #2232:
URL: https://github.com/apache/solr/pull/2232#issuecomment-2140952410
I triggered a build, which should pick up the new .bats test. Worth adding
one more test that shows solr doing somethign and prometheus picking up that
data?
--
This is an automated messag
dsmiley commented on PR #2487:
URL: https://github.com/apache/solr/pull/2487#issuecomment-2141245307
Ha... another test failure and now we can see it in action here:
```
ERROR: The following test(s) have failed:
- org.apache.solr.client.solrj.impl.BasicHttpSolrClientTest.classMetho
dsmiley commented on PR #2474:
URL: https://github.com/apache/solr/pull/2474#issuecomment-2141246716
And another hang in another of my PRs:
https://github.com/apache/solr/pull/2487#issuecomment-2141245307
Looking forward to merging this today/Friday :-) and not waiting *that*
long t
dsmiley commented on PR #2405:
URL: https://github.com/apache/solr/pull/2405#issuecomment-2141259126
What's here looks good to me. Just need to add more; lots more metrics.
Maybe it'll evolve a little once you add another category. My interest on this
at-work is not the core metrics but
eivinhb commented on PR #2232:
URL: https://github.com/apache/solr/pull/2232#issuecomment-2141339266
Yeah, I had plans for that, but had to go to bed.
I have now updated the test to make it scrape solr and verify that i does. I
also squashed the commits into one and added the jira id to
32 matches
Mail list logo
