Re: [PR] Alpine as base image [solr-docker]

2024-05-20 Thread via GitHub
manideepgoudparuchuri commented on PR #22: URL: https://github.com/apache/solr-docker/pull/22#issuecomment-2119832785 This is not the duplication of other codes. I have changed **FROM to use alpine as base** image and **changed commands which installs packages ** while it starts building th

[jira] [Created] (SOLR-17300) Copy existing listeners on re-creation of Http2SolrClient

2024-05-20 Thread Sanjay Dutt (Jira)
Sanjay Dutt created SOLR-17300: -- Summary: Copy existing listeners on re-creation of Http2SolrClient Key: SOLR-17300 URL: https://issues.apache.org/jira/browse/SOLR-17300 Project: Solr Issue Type

Re: [PR] SOLR-16505: Add auth listener to RecoveryStrategy SolrClient [solr]

2024-05-20 Thread via GitHub
iamsanjay closed pull request #2462: SOLR-16505: Add auth listener to RecoveryStrategy SolrClient URL: https://github.com/apache/solr/pull/2462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Updated] (SOLR-17300) Copy existing listeners on re-creation of Http2SolrClient

2024-05-20 Thread Sanjay Dutt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjay Dutt updated SOLR-17300: --- Description: For custom settings, such as timeouts, usually a Http2SolrClient is created using the e

[PR] SOLR-17301: Support all types of requests in rate limiting [solr]

2024-05-20 Thread via GitHub
noblepaul opened a new pull request, #2469: URL: https://github.com/apache/solr/pull/2469 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[jira] [Assigned] (SOLR-17301) Support all types of requests in rate limiting

2024-05-20 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul reassigned SOLR-17301: - Assignee: Noble Paul > Support all types of requests in rate limiting >

[jira] [Created] (SOLR-17301) Support all types of requests in rate limiting

2024-05-20 Thread Noble Paul (Jira)
Noble Paul created SOLR-17301: - Summary: Support all types of requests in rate limiting Key: SOLR-17301 URL: https://issues.apache.org/jira/browse/SOLR-17301 Project: Solr Issue Type: Improvement

[jira] [Resolved] (SOLR-17134) Bucketed rate limiting

2024-05-20 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-17134. --- Resolution: Duplicate > Bucketed rate limiting > -- > > Key: SOLR

Re: [PR] SOLR-17300: Copy existing listeners on re-creation of Http2SolrClient [solr]

2024-05-20 Thread via GitHub
dsmiley commented on code in PR #2467: URL: https://github.com/apache/solr/pull/2467#discussion_r1606862270 ## solr/core/src/test/org/apache/solr/cloud/RecoveryZkTestWithAuth.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] SOLR-17300: Copy existing listeners on re-creation of Http2SolrClient [solr]

2024-05-20 Thread via GitHub
dsmiley commented on code in PR #2467: URL: https://github.com/apache/solr/pull/2467#discussion_r1606945391 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -149,10 +149,6 @@ public void addListenerFactory(HttpListenerFactory factory) {

Re: [PR] SOLR-17300: Copy existing listeners on re-creation of Http2SolrClient [solr]

2024-05-20 Thread via GitHub
dsmiley commented on code in PR #2467: URL: https://github.com/apache/solr/pull/2467#discussion_r1606946759 ## solr/core/src/test/org/apache/solr/cloud/RecoveryZkTestWithAuth.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] SOLR-17300: Copy existing listeners on re-creation of Http2SolrClient [solr]

2024-05-20 Thread via GitHub
iamsanjay commented on code in PR #2467: URL: https://github.com/apache/solr/pull/2467#discussion_r1606972242 ## solr/core/src/test/org/apache/solr/cloud/RecoveryZkTestWithAuth.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] SOLR-17300: Copy existing listeners on re-creation of Http2SolrClient [solr]

2024-05-20 Thread via GitHub
epugh commented on code in PR #2467: URL: https://github.com/apache/solr/pull/2467#discussion_r1607025808 ## solr/core/src/test/org/apache/solr/cloud/RecoveryZkTestWithAuth.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] SOLR-17300: Copy existing listeners on re-creation of Http2SolrClient [solr]

2024-05-20 Thread via GitHub
dsmiley commented on code in PR #2467: URL: https://github.com/apache/solr/pull/2467#discussion_r1607134511 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -149,10 +149,6 @@ public void addListenerFactory(HttpListenerFactory factory) {

[jira] [Created] (SOLR-17302) Migrate filestore APIs to JAX-RS

2024-05-20 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-17302: -- Summary: Migrate filestore APIs to JAX-RS Key: SOLR-17302 URL: https://issues.apache.org/jira/browse/SOLR-17302 Project: Solr Issue Type: Sub-task

Re: [PR] SOLR-17300: Copy existing listeners on re-creation of Http2SolrClient [solr]

2024-05-20 Thread via GitHub
dsmiley commented on PR #2467: URL: https://github.com/apache/solr/pull/2467#issuecomment-2121028103 Hmmm [TestInterleavingTransformer](https://ge.apache.org/scans/tests?search.relativeStartTime=P90D&search.rootProjectNames=solr-root&search.timeZoneId=America%2FNew_York&tests.container=org.a

[jira] [Updated] (SOLR-17301) Support all types of requests in rate limiting

2024-05-20 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-17301: -- Description: Rate limiting is now limited to QUERY , it should be possible to  support all types {cod

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-05-20 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847965#comment-17847965 ] Ishan Chattopadhyaya commented on SOLR-13350: - bq. This is caused by breaking

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-05-20 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847967#comment-17847967 ] Ishan Chattopadhyaya commented on SOLR-13350: - bq. Are there other risks/trad

[PR] SOLR-17302: Convert /cluster filestore APIs to JAX-RS [solr]

2024-05-20 Thread via GitHub
gerlowskija opened a new pull request, #2470: URL: https://github.com/apache/solr/pull/2470 https://issues.apache.org/jira/browse/SOLR-17302 # Description Solr has slowly been modifying its v2 APIs to align around a more REST-ful model, implemented using the JAX-RS framework.

Re: [PR] User Behavior Insights implementation for Apache Solr [solr]

2024-05-20 Thread via GitHub
chatman commented on PR #2452: URL: https://github.com/apache/solr/pull/2452#issuecomment-2121233115 Usually, features like these are discussed in the dev@ list, or in JIRA or a SIP. Most important question I have in mind is whether this needs to be in the core search engine? If not, can

Re: [PR] SOLR-10654: Introduce output of Prometheus metrics for Solr Core registry [solr]

2024-05-20 Thread via GitHub
dsmiley commented on code in PR #2405: URL: https://github.com/apache/solr/pull/2405#discussion_r1607222435 ## solr/core/src/java/org/apache/solr/util/stats/MetricUtils.java: ## @@ -165,6 +169,71 @@ public static void toSolrInputDocuments( }); } + /** + * Provid

Re: [PR] SOLR-10654: Introduce output of Prometheus metrics for Solr Core registry [solr]

2024-05-20 Thread via GitHub
dsmiley commented on code in PR #2405: URL: https://github.com/apache/solr/pull/2405#discussion_r1607332586 ## solr/core/src/java/org/apache/solr/metrics/prometheus/SolrPrometheusCoreExporter.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] SOLR-10654: Introduce output of Prometheus metrics for Solr Core registry [solr]

2024-05-20 Thread via GitHub
dsmiley commented on code in PR #2405: URL: https://github.com/apache/solr/pull/2405#discussion_r1607336727 ## solr/core/src/java/org/apache/solr/response/PrometheusResponseWriter.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] SOLR-10654: Introduce output of Prometheus metrics for Solr Core registry [solr]

2024-05-20 Thread via GitHub
dsmiley commented on code in PR #2405: URL: https://github.com/apache/solr/pull/2405#discussion_r1607338383 ## solr/core/src/java/org/apache/solr/core/SolrCore.java: ## @@ -3032,6 +3034,7 @@ public PluginBag getResponseWriters() { m.put("csv", new CSVResponseWriter());

[jira] [Commented] (SOLR-10654) Expose Metrics in Prometheus format DIRECTLY from Solr

2024-05-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847998#comment-17847998 ] David Smiley commented on SOLR-10654: - Overall I wonder what others think about maint

[jira] [Commented] (SOLR-17297) Classloading issue with plugin and modules

2024-05-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848000#comment-17848000 ] David Smiley commented on SOLR-17297: - I believe it's only one classloader across mod

Re: [PR] User Behavior Insights implementation for Apache Solr [solr]

2024-05-20 Thread via GitHub
epugh commented on PR #2452: URL: https://github.com/apache/solr/pull/2452#issuecomment-2121447550 This is definitely draft mode code... I opened it as a PR just to be able to track the work, and once it gets a bit furthur, I plan on opening a proper discussion about it. Module? Solr S

Re: [PR] SOLR-17302: Convert /cluster filestore APIs to JAX-RS [solr]

2024-05-20 Thread via GitHub
epugh commented on code in PR #2470: URL: https://github.com/apache/solr/pull/2470#discussion_r1607425946 ## solr/core/src/java/org/apache/solr/filestore/FileStoreAPI.java: ## Review Comment: I sort of thought maybe `FileStoreAPI.java` would be totally removed in favour of

Re: [PR] SOLR-17302: Convert /cluster filestore APIs to JAX-RS [solr]

2024-05-20 Thread via GitHub
gerlowskija commented on PR #2470: URL: https://github.com/apache/solr/pull/2470#issuecomment-2121513823 Thanks for the quick review Eric! > I tagged some places where it would be nice ot have more descriptive variable names, however I suspect you are trying to minimize change

Re: [PR] SOLR-17302: Convert /cluster filestore APIs to JAX-RS [solr]

2024-05-20 Thread via GitHub
epugh commented on PR #2470: URL: https://github.com/apache/solr/pull/2470#issuecomment-2121526630 If `DistribFileStore` is the lone implementation of `FileStore`, then do we need `FileStore`?I never liked the whole "Let me have an interface for everything" cause it doubles the files to

[jira] [Created] (SOLR-17303) CVE-2023-39410: Upgrade to apache-avro version 1.11.3

2024-05-20 Thread Sujeet-A (Jira)
Sujeet-A created SOLR-17303: --- Summary: CVE-2023-39410: Upgrade to apache-avro version 1.11.3 Key: SOLR-17303 URL: https://issues.apache.org/jira/browse/SOLR-17303 Project: Solr Issue Type: Bug