Re: [PR] EncryptionBackupRepository to back up encrypted files. [solr-sandbox]

2024-05-13 Thread via GitHub
bruno-roustant merged PR #106: URL: https://github.com/apache/solr-sandbox/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

Re: [PR] Fix EncryptionUpdateLog.encryptLog() and its test. [solr-sandbox]

2024-05-13 Thread via GitHub
bruno-roustant merged PR #105: URL: https://github.com/apache/solr-sandbox/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[PR] Update ENCRYPTION.md to describe EncryptionBackupRepository. [solr-sandbox]

2024-05-13 Thread via GitHub
bruno-roustant opened a new pull request, #107: URL: https://github.com/apache/solr-sandbox/pull/107 EncryptionBackupRepository was added in a previous commit, but we missed its description in ENCRYPTION.md. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] SOLR-17044: Expose api "version" on SolrRequest objects [solr]

2024-05-13 Thread via GitHub
gerlowskija commented on PR #2456: URL: https://github.com/apache/solr/pull/2456#issuecomment-2107298420 Yeah - there's a lot, **a lot** of GSR usage that's only there because an API folks want to use isn't covered in SolrJ. IMO there's still some valid usecases for keeping GSR around

Re: [PR] SOLR-17044: Consolidate SolrJ URL-building logic [solr]

2024-05-13 Thread via GitHub
gerlowskija commented on PR #2455: URL: https://github.com/apache/solr/pull/2455#issuecomment-2107307909 Thanks for the review @jdyer1 ! > but do you see end-users calling this directly? Are you sure we want it to be public? I made it public in support of the few SolrJ users wh

Re: [PR] DelegatingBackupRepository extends AbstractBackupRepository. [solr]

2024-05-13 Thread via GitHub
bruno-roustant merged PR #2444: URL: https://github.com/apache/solr/pull/2444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.ap

Re: [PR] SOLR-17284: Remove deprecated BlobRepository [solr]

2024-05-13 Thread via GitHub
gus-asf commented on PR #2447: URL: https://github.com/apache/solr/pull/2447#issuecomment-2107494586 I don't see any restoration of the resource sharing tests with file store? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] SOLR-17284: Remove deprecated BlobRepository [solr]

2024-05-13 Thread via GitHub
gus-asf commented on code in PR #2447: URL: https://github.com/apache/solr/pull/2447#discussion_r1598434860 ## solr/core/src/test/org/apache/solr/core/BlobRepositoryCloudTest.java: ## @@ -1,127 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more -

[jira] [Commented] (SOLR-17271) PerReplicaState: Shard leader elections still impact state.json

2024-05-13 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845993#comment-17845993 ] Noble Paul commented on SOLR-17271: --- [~dsmiley] . This is a separate attribute called "

[jira] [Assigned] (SOLR-17271) PerReplicaState: Shard leader elections still impact state.json

2024-05-13 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul reassigned SOLR-17271: - Assignee: Noble Paul > PerReplicaState: Shard leader elections still impact state.json > ---

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-05-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846029#comment-17846029 ] ASF subversion and git services commented on SOLR-13350: Commit b

Re: [PR] SOLR-17284: Remove deprecated BlobRepository [solr]

2024-05-13 Thread via GitHub
epugh commented on PR #2447: URL: https://github.com/apache/solr/pull/2447#issuecomment-2108430534 I'm not familiar with Resource sharing aspect. Not to put too fine a point on it, but would you be willing to port it over to the right api? I suspect you can migrate it much faster than I

Re: [PR] SOLR-17044: Expose api "version" on SolrRequest objects [solr]

2024-05-13 Thread via GitHub
epugh commented on PR #2456: URL: https://github.com/apache/solr/pull/2456#issuecomment-2108467589 > Yeah - there's a lot, **a lot** of GSR usage that's only there because folks want to us an API that isn't covered in SolrJ. > > IMO there's still some valid usecases for keeping GSR ar

Re: [PR] SOLR-17066 Fix ShardSplitTest & StressHdfsTest [solr]

2024-05-13 Thread via GitHub
dsmiley commented on PR #2457: URL: https://github.com/apache/solr/pull/2457#issuecomment-2108473458 I'm going to merge this even though not all tests are fixed in ShardSplitTest. At least the ones introduced by SOLR-17066 are. Sadly there are still more failures that seemed to hav

[jira] [Commented] (SOLR-17263) HttpJdkSolrClient doesn't encode curly braces etc

2024-05-13 Thread James Dyer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846037#comment-17846037 ] James Dyer commented on SOLR-17263: --- [~andywebb1975] I think you'd be safe following th

Re: [PR] SOLR-17271: PerReplicaState: Shard leader elections still impact state.json [solr]

2024-05-13 Thread via GitHub
dsmiley commented on PR #2443: URL: https://github.com/apache/solr/pull/2443#issuecomment-210856 When creating a PR, instead of deleting absolutely everything in the template, please leave the first tiny bit with a template JIRA URL then edit the URL. It's very convenient to click both

[jira] [Commented] (SOLR-17263) HttpJdkSolrClient doesn't encode curly braces etc

2024-05-13 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846047#comment-17846047 ] Eric Pugh commented on SOLR-17263: -- I *think* that if we know we are doing a 9.6.1, then

[jira] [Resolved] (SOLR-11999) RebalanceLeaders API should not require a preferredLeader property

2024-05-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-11999. - Resolution: Won't Fix This doesn't seem useful. Without preferredLeader, leadership assignment i

[jira] [Commented] (SOLR-10780) A new collection property autoRebalanceLeaders

2024-05-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846106#comment-17846106 ] David Smiley commented on SOLR-10780: - I'd rather see leadership be sticky (e.g. via

[jira] [Created] (SOLR-17288) automatic preferredLeader

2024-05-13 Thread David Smiley (Jira)
David Smiley created SOLR-17288: --- Summary: automatic preferredLeader Key: SOLR-17288 URL: https://issues.apache.org/jira/browse/SOLR-17288 Project: Solr Issue Type: Improvement Security L

[jira] [Updated] (SOLR-17288) automatic preferredLeader

2024-05-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17288: Description: I'd like to have the preferredLeader replica property be assigned automatically by So

Re: [PR] SOLR-17066 Fix ShardSplitTest & StressHdfsTest [solr]

2024-05-13 Thread via GitHub
dsmiley merged PR #2457: URL: https://github.com/apache/solr/pull/2457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-17066) Deprecate and remove core URLs in HttpSolrClient and friends

2024-05-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846138#comment-17846138 ] ASF subversion and git services commented on SOLR-17066: Commit d

[PR] SOLR-17289: OrderedNodePlacementPlugin: optimize don't loop collections [solr]

2024-05-13 Thread via GitHub
dsmiley opened a new pull request, #2459: URL: https://github.com/apache/solr/pull/2459 https://issues.apache.org/jira/browse/SOLR-17289 Not sure if the first version here is right; maybe there are untested issues where this won't work? And maybe with withCollection/withShards can be

[jira] [Commented] (SOLR-16505) Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2

2024-05-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846150#comment-17846150 ] ASF subversion and git services commented on SOLR-16505: Commit 0

[jira] [Commented] (SOLR-17274) atomic update error when using json w/ multiple modifiers

2024-05-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846151#comment-17846151 ] ASF subversion and git services commented on SOLR-17274: Commit 9

[jira] [Resolved] (SOLR-17274) atomic update error when using json w/ multiple modifiers

2024-05-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17274. - Fix Version/s: 9.7 Resolution: Fixed Merged.  Thanks for the PR Calvin! > atomic update e

[jira] [Resolved] (SOLR-16505) Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2

2024-05-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-16505. - Fix Version/s: 9.7 Resolution: Fixed Thanks for contributing to this issue Sanjay!  Defini

[jira] [Commented] (SOLR-17066) Deprecate and remove core URLs in HttpSolrClient and friends

2024-05-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846158#comment-17846158 ] ASF subversion and git services commented on SOLR-17066: Commit 7

Re: [PR] SOLR-16503: Introduce new default Http2SolrClient in UpdateShardHandler [solr]

2024-05-13 Thread via GitHub
dsmiley commented on code in PR #2351: URL: https://github.com/apache/solr/pull/2351#discussion_r1599379143 ## solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java: ## @@ -236,11 +246,17 @@ public SolrMetricsContext getSolrMetricsContext() { return solrMetricsC

Re: [PR] SOLR-17284: Remove deprecated BlobRepository [solr]

2024-05-13 Thread via GitHub
gus-asf commented on PR #2447: URL: https://github.com/apache/solr/pull/2447#issuecomment-2109344780 I'm willing in principal, but I don't really have a ton of time for it right now. I might be faster in coding cycles, but probably not in wall clock. -- This is an automated message from t

[PR] SOLR-16503: Update SyncStrategy and PeerSyncWithLeader to use the recovery Http2SolrClient [solr]

2024-05-13 Thread via GitHub
iamsanjay opened a new pull request, #2460: URL: https://github.com/apache/solr/pull/2460 https://issues.apache.org/jira/browse/SOLR-16503 As per the discussion on this thread [SOLR-16505](https://issues.apache.org/jira/browse/SOLR-16505), It has been identified that `PeerSyncWithLea

Re: [PR] SOLR-17284: Remove deprecated BlobRepository [solr]

2024-05-13 Thread via GitHub
gus-asf commented on PR #2447: URL: https://github.com/apache/solr/pull/2447#issuecomment-2109362867 The ideal thing would be to use it to solve https://issues.apache.org/jira/browse/SOLR-3443 with it at the same time since that's essentially the same problem my client faced. Not sure where

[jira] [Commented] (SOLR-16505) Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2

2024-05-13 Thread Sanjay Dutt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846185#comment-17846185 ] Sanjay Dutt commented on SOLR-16505: Without your support, this PR wouldn't have seen