[jira] [Commented] (SOLR-17065) Migrate Sandbox CrossDC functionality into Solr

2024-05-02 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842861#comment-17842861 ] Mark Robert Miller commented on SOLR-17065: --- https://github.com/markrmiller/sol

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-05-02 Thread via GitHub
epugh commented on PR #2417: URL: https://github.com/apache/solr/pull/2417#issuecomment-2090355350 @laminelam I just merged in the latest, notice the compressor stuff for `ZkCpTool`? I really wish that all happened INSIDE of the zkclient tool.. not when you create it. oh well... Can

[jira] [Created] (SOLR-17268) Solr 9.3-9.6 (JacksonJsonWriter) does not support "json.nl=arrntv"

2024-05-02 Thread Ramsey Haddad (Jira)
Ramsey Haddad created SOLR-17268: Summary: Solr 9.3-9.6 (JacksonJsonWriter) does not support "json.nl=arrntv" Key: SOLR-17268 URL: https://issues.apache.org/jira/browse/SOLR-17268 Project: Solr

[jira] [Updated] (SOLR-17268) Solr 9.3-9.6 (JacksonJsonWriter) does not support "json.nl=arrntv"

2024-05-02 Thread Ramsey Haddad (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramsey Haddad updated SOLR-17268: - Description: Asking for facets and using "json.nl=arrntv" results in the exception: {code:java} a

Re: [PR] SOLR-17265: Fix randomized PRS testing [solr]

2024-05-02 Thread via GitHub
HoustonPutman commented on code in PR #2436: URL: https://github.com/apache/solr/pull/2436#discussion_r1587879478 ## solr/test-framework/src/java/org/apache/solr/cloud/AbstractBasicDistributedZk2TestBase.java: ## @@ -56,6 +58,10 @@ public abstract class AbstractBasicDistributedZ

Re: [PR] SOLR-16825: Generate v2 API SolrRequest bindings [solr]

2024-05-02 Thread via GitHub
HoustonPutman commented on code in PR #1793: URL: https://github.com/apache/solr/pull/1793#discussion_r1588028324 ## solr/solrj/build.gradle: ## @@ -85,3 +94,73 @@ dependencies { testImplementation 'org.apache.commons:commons-lang3' testImplementation 'io.dropwizard.metric

Re: [PR] SOLR-17265: Fix randomized PRS testing [solr]

2024-05-02 Thread via GitHub
HoustonPutman merged PR #2436: URL: https://github.com/apache/solr/pull/2436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[jira] [Commented] (SOLR-17265) Reproducing Failure: OverseerStatusTest after commit 9c9250c6

2024-05-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843028#comment-17843028 ] ASF subversion and git services commented on SOLR-17265: Commit c

Re: [PR] Use a System wide property to enable PRS [solr]

2024-05-02 Thread via GitHub
HoustonPutman commented on PR #2230: URL: https://github.com/apache/solr/pull/2230#issuecomment-2091147056 Why isn't any of this PRS testing logic backported to 9x @noblepaul ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-02 Thread via GitHub
HoustonPutman commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1588046237 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) {

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-02 Thread via GitHub
HoustonPutman commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1588050937 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) {

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-02 Thread via GitHub
dsmiley commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1588078459 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) { * Bes

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-02 Thread via GitHub
HoustonPutman commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1588090034 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) {

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-02 Thread via GitHub
dsmiley commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1588090685 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) { * Bes

Re: [PR] Use a System wide property to enable PRS [solr]

2024-05-02 Thread via GitHub
dsmiley commented on PR #2230: URL: https://github.com/apache/solr/pull/2230#issuecomment-2091201004 The approach seen here is perfect -- bake something risky in main _then_ bring to branch_9x. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-02 Thread via GitHub
HoustonPutman commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1588098873 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) {

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-02 Thread via GitHub
dsmiley commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1588143175 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) { * Bes

Re: [PR] Use a System wide property to enable PRS [solr]

2024-05-02 Thread via GitHub
HoustonPutman commented on PR #2230: URL: https://github.com/apache/solr/pull/2230#issuecomment-2091267170 Fair enough. We will let it bake then backport both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] SOLR-10654: Introduce output of Prometheus metrics for Solr Core registry [solr]

2024-05-02 Thread via GitHub
mlbiscoc commented on code in PR #2405: URL: https://github.com/apache/solr/pull/2405#discussion_r1588295530 ## solr/core/src/java/org/apache/solr/metrics/prometheus/SolrPrometheusRegistry.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-10654: Introduce output of Prometheus metrics for Solr Core registry [solr]

2024-05-02 Thread via GitHub
mlbiscoc commented on PR #2405: URL: https://github.com/apache/solr/pull/2405#issuecomment-209149 Moving this out of draft for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] SOLR-17263: HttpJdkSolrClient doesn't encode curly braces etc (follow-up PR) [solr]

2024-05-02 Thread via GitHub
andywebb1975 commented on code in PR #2435: URL: https://github.com/apache/solr/pull/2435#discussion_r1588398916 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java: ## @@ -238,7 +238,7 @@ private PreparedRequest prepareGet( validateGetRequest(so

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-05-02 Thread via GitHub
laminelam commented on PR #2417: URL: https://github.com/apache/solr/pull/2417#issuecomment-2091767501 > @laminelam I just merged in the latest, notice the compressor stuff for `ZkCpTool`? I really wish that all happened INSIDE of the zkclient tool.. not when you create it. oh well... Can y

[jira] [Created] (SOLR-17269) Don't publish synthetic collection to ZK in solr coordinator nodes

2024-05-02 Thread Patson Luk (Jira)
Patson Luk created SOLR-17269: - Summary: Don't publish synthetic collection to ZK in solr coordinator nodes Key: SOLR-17269 URL: https://issues.apache.org/jira/browse/SOLR-17269 Project: Solr Is

[PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-05-02 Thread via GitHub
patsonluk opened a new pull request, #2438: URL: https://github.com/apache/solr/pull/2438 https://issues.apache.org/jira/browse/SOLR-17269 # Description The synthetic collection/replica introduced in Solr 9 registers such collection to zookeeper. This might cause issues with ot

Re: [PR] Remove the Before SolrCloud section, and expand the supported featureā€¦ [solr]

2024-05-02 Thread via GitHub
github-actions[bot] commented on PR #1138: URL: https://github.com/apache/solr/pull/1138#issuecomment-2091929874 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t

Re: [PR] SOLR-16291 : Decay function queries gauss,linear,exponential [solr]

2024-05-02 Thread via GitHub
github-actions[bot] commented on PR #939: URL: https://github.com/apache/solr/pull/939#issuecomment-2091929894 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

[jira] [Resolved] (SOLR-17264) Reproducible Seed for OverseerStatusTest Failure

2024-05-02 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-17264. --- Fix Version/s: SOLR-17265 Resolution: Duplicate The randomisation logic was wrong. It is fixed

[jira] [Reopened] (SOLR-17264) Reproducible Seed for OverseerStatusTest Failure

2024-05-02 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul reopened SOLR-17264: --- > Reproducible Seed for OverseerStatusTest Failure > > >

[jira] [Updated] (SOLR-17264) Reproducible Seed for OverseerStatusTest Failure

2024-05-02 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-17264: -- Fix Version/s: (was: SOLR-17265) > Reproducible Seed for OverseerStatusTest Failure > -

[jira] [Resolved] (SOLR-17264) Reproducible Seed for OverseerStatusTest Failure

2024-05-02 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-17264. --- Resolution: Duplicate > Reproducible Seed for OverseerStatusTest Failure > --