Re: [PR] SOLR-17243: CloudSolrClient support for req.getBasePath [solr]

2024-04-21 Thread via GitHub
dsmiley commented on PR #2414: URL: https://github.com/apache/solr/pull/2414#issuecomment-2068095416 FYI @iamsanjay this will be useful for the transition to Jetty based clients which also involves less one-off client creations. I have WIP that will use this. -- This is an automated mes

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-04-21 Thread via GitHub
dsmiley commented on code in PR #2276: URL: https://github.com/apache/solr/pull/2276#discussion_r1573856139 ## solr/core/src/test-files/solr/collection1/conf/solrconfig-follower-auth.xml: ## Review Comment: I don't see a reference to this file from the test; am I missing so

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-04-21 Thread via GitHub
dsmiley commented on code in PR #2276: URL: https://github.com/apache/solr/pull/2276#discussion_r1573866976 ## solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java: ## @@ -133,16 +135,25 @@ public UpdateShardHandler(UpdateShardHandlerConfig cfg) { Distr

Re: [PR] SOLR-17194: Fix bug - CloudHttp2SolrClient doesn't preserve the passed httpClient to Http2ClusterStateProvider when using the internalClientBuilder [solr]

2024-04-21 Thread via GitHub
epugh merged PR #2412: URL: https://github.com/apache/solr/pull/2412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-12404) Start using HTTP/2 instead of HTTP/1.1.

2024-04-21 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839438#comment-17839438 ] Gus Heck commented on SOLR-12404: - What's the appropriate fix version? (or should it have

[jira] [Resolved] (SOLR-5514) atomic update throws exception if the schema contains uuid fields: Invalid UUID String: 'java.util.UUID:e26c4d56-e98d-41de-9b7f-f63192089670'

2024-04-21 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck resolved SOLR-5514. Resolution: Duplicate > atomic update throws exception if the schema contains uuid fields: Invalid > UUID S

[jira] [Reopened] (SOLR-5514) atomic update throws exception if the schema contains uuid fields: Invalid UUID String: 'java.util.UUID:e26c4d56-e98d-41de-9b7f-f63192089670'

2024-04-21 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck reopened SOLR-5514: > atomic update throws exception if the schema contains uuid fields: Invalid > UUID String: 'java.util.UUID:e26

[jira] [Updated] (SOLR-17181) Performance degradation matching glob patterns for fields

2024-04-21 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-17181: Fix Version/s: main (10.0) 9.6.0 > Performance degradation matching glob patterns for fi

[jira] [Commented] (SOLR-17181) Performance degradation matching glob patterns for fields

2024-04-21 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839446#comment-17839446 ] Gus Heck commented on SOLR-17181: - [~jsweeney] do you think this should have a CHANGES.tx

[jira] [Updated] (SOLR-17184) PeerSyncTest randomized failures due to result sorting

2024-04-21 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-17184: Fix Version/s: main (10.0) 9.6.0 > PeerSyncTest randomized failures due to result sortin

[jira] [Updated] (SOLR-16879) Throttle concurrent backups/restores per node

2024-04-21 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-16879: Fix Version/s: 9.4 (was: 9.4.) > Throttle concurrent backups/restores per node > ---

Re: [PR] SOLR-17131: Optimize rows=0 since score/sort isn't necessary [solr]

2024-04-21 Thread via GitHub
dsmiley commented on code in PR #2221: URL: https://github.com/apache/solr/pull/2221#discussion_r1574045448 ## solr/benchmark/src/java/org/apache/solr/bench/MiniClusterState.java: ## Review Comment: CC @tflobbe ; you added the setUseHttp1 call 1 year ago. -- This is an

[jira] [Updated] (SOLR-17232) PropertiesOutputStream does not override write(byte[], int, int)

2024-04-21 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-17232: Fix Version/s: 9.6.0 (was: 9.6) > PropertiesOutputStream does not override write(byt

[jira] [Updated] (SOLR-14763) SolrJ Client Async HTTP/2 Requests

2024-04-21 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-14763: Fix Version/s: 9.6.0 (was: 9.6) > SolrJ Client Async HTTP/2 Requests > -

[jira] [Commented] (SOLR-17126) Cut over System.getProperty to EnvUtils.getProperty

2024-04-21 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839457#comment-17839457 ] Gus Heck commented on SOLR-17126: - [~janhoy] What's the status of this? Looks like it mig