Re: [PR] SolrJ HTTP/2 Async API using CompletableFuture (update for 2024) [solr]

2024-04-13 Thread via GitHub
dsmiley commented on code in PR #2402: URL: https://github.com/apache/solr/pull/2402#discussion_r1564233373 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/LBHttp2SolrClientTest.java: ## @@ -51,4 +67,249 @@ public void testLBHttp2SolrClientWithTheseParamNamesInTheUrl()

Re: [PR] SolrJ HTTP/2 Async API using CompletableFuture (update for 2024) [solr]

2024-04-13 Thread via GitHub
dsmiley commented on code in PR #2402: URL: https://github.com/apache/solr/pull/2402#discussion_r1564234192 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientTest.java: ## @@ -299,7 +299,9 @@ public void testAsyncException() throws Exception { public voi

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-04-13 Thread via GitHub
dsmiley commented on PR #2276: URL: https://github.com/apache/solr/pull/2276#issuecomment-2053755426 If there's anything I can do to help here, let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above