epugh commented on code in PR #2330:
URL: https://github.com/apache/solr/pull/2330#discussion_r1509997243
##
solr/core/src/test/org/apache/solr/request/macro/TestMacroExpander.java:
##
@@ -37,8 +37,7 @@ public void testExamples() {
me = new MacroExpander(testParams, failO
epugh commented on code in PR #2330:
URL: https://github.com/apache/solr/pull/2330#discussion_r1509997419
##
solr/solr-ref-guide/modules/indexing-guide/pages/date-formatting-math.adoc:
##
@@ -217,4 +217,117 @@ Unlike most local params, `op` is actually _not_ defined
by any quer
epugh commented on PR #2330:
URL: https://github.com/apache/solr/pull/2330#issuecomment-1974841764
Thank you @AndreyBozhko for following up from the other issue. I bumped the
example up to give it a bit more prominance. Keep the improvements coming.
In the future, I would love to r
epugh merged PR #2330:
URL: https://github.com/apache/solr/pull/2330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on code in PR #2329:
URL: https://github.com/apache/solr/pull/2329#discussion_r1510001348
##
solr/CHANGES.txt:
##
@@ -27,7 +27,8 @@ Optimizations
Bug Fixes
-
-(No changes)
+
+* PR#2329: Fix getting fieldType by its name in FileBasedSpellCh
dsmiley merged PR #2331:
URL: https://github.com/apache/solr/pull/2331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on PR #2328:
URL: https://github.com/apache/solr/pull/2328#issuecomment-1974871824
Just remove it; it's an internal utility with alternatives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
dsmiley commented on PR #1246:
URL: https://github.com/apache/solr/pull/1246#issuecomment-1974872456
I suppose this should be closed; you were merely showing me something? I
suppose this approach of showing somebody something can also be done on one's
personal fork as well; probably better
dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1510019364
##
solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java:
##
@@ -175,24 +175,21 @@ public final void setRecoveringAfterStartup(boolean
recoveringAfterStartup) {
dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1510019464
##
solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java:
##
@@ -175,24 +175,21 @@ public final void setRecoveringAfterStartup(boolean
recoveringAfterStartup) {
dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1510020415
##
solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java:
##
@@ -915,18 +907,15 @@ private final void sendPrepRecoveryCmd(String
leaderBaseUrl, String leaderCore
epugh commented on code in PR #2329:
URL: https://github.com/apache/solr/pull/2329#discussion_r1510124245
##
solr/CHANGES.txt:
##
@@ -27,7 +27,8 @@ Optimizations
Bug Fixes
-
-(No changes)
+
+* PR#2329: Fix getting fieldType by its name in FileBasedSpellCh
epugh commented on PR #2298:
URL: https://github.com/apache/solr/pull/2298#issuecomment-1974971954
Making progress...I *think* I have `bin/solr` done, and I am *hoping* I
got `bin/solr.cmd` done... Now looking at `cloud.sh` cc @gus-asf on
these changes coming up
--
This i
13 matches
Mail list logo
