[jira] [Updated] (SOLR-17103) Add documentation about Hybrid Search with Apache Solr

2024-02-16 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-17103: --- Labels: hybrid-search (was: ) > Add documentation about Hybrid Search with Apache So

[jira] [Updated] (SOLR-17164) Add 2 arg variant of vectorSimilarity() function

2024-02-16 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-17164: --- Labels: vector-based-search (was: ) > Add 2 arg variant of vectorSimilarity() functi

[jira] [Commented] (SOLR-17103) Add documentation about Hybrid Search with Apache Solr

2024-02-16 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817878#comment-17817878 ] Alessandro Benedetti commented on SOLR-17103: - This should be a good starting

Re: [PR] Update dependency commons-codec:commons-codec to v1.16.1 [solr]

2024-02-16 Thread via GitHub
cpoerschke commented on PR #2266: URL: https://github.com/apache/solr/pull/2266#issuecomment-1948008176 > https://commons.apache.org/proper/commons-codec/changes-report.html#a1.16.1 mentions version bumps for these three `commons-parent commons-lang3 commons-io` -- might be worth checking

[jira] [Commented] (SOLR-16810) Under certain situations Solr produces managed schema XML that cannot be loaded

2024-02-16 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817884#comment-17817884 ] Jan Høydahl commented on SOLR-16810: To be honest this is a very corner case - that p

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-02-16 Thread via GitHub
cpoerschke commented on code in PR #2248: URL: https://github.com/apache/solr/pull/2248#discussion_r1492236325 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -1910,6 +1954,190 @@ public ScoreMode scoreMode() { qr.setDocList(new DocSlice(0, sliceL

Re: [PR] GH Labeler action: Category labels [solr]

2024-02-16 Thread via GitHub
janhoy commented on PR #2190: URL: https://github.com/apache/solr/pull/2190#issuecomment-1948121173 @dsmiley WDYT about latest iteration? Should we simplify it into even fewer categories? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] SOLR-17141: Create CpuQueryLimit implementation [solr]

2024-02-16 Thread via GitHub
sigram commented on code in PR #2244: URL: https://github.com/apache/solr/pull/2244#discussion_r1492269713 ## solr/core/src/test/org/apache/solr/search/TestCpuAllowedLimit.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] SOLR-17141: Create CpuQueryLimit implementation [solr]

2024-02-16 Thread via GitHub
sigram commented on code in PR #2244: URL: https://github.com/apache/solr/pull/2244#discussion_r1492271009 ## solr/core/src/test/org/apache/solr/search/TestCpuQueryTimeLimit.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[PR] Update required JTS version [solr]

2024-02-16 Thread via GitHub
ejn opened a new pull request, #2273: URL: https://github.com/apache/solr/pull/2273 Due to API changes a JTS 1.17.x version is currently required. The appropriate JTS version may be determined based on the JTS version used for tests in Lucene, referenced in https://github.com/apache/

[jira] [Commented] (SOLR-16810) Under certain situations Solr produces managed schema XML that cannot be loaded

2024-02-16 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817924#comment-17817924 ] Eric Pugh commented on SOLR-16810: -- I like your suggestion [~janhoy]!If you created

[jira] [Assigned] (SOLR-6572) lineshift in solrconfig.xml is not supported

2024-02-16 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-6572: - Assignee: Jan Høydahl > lineshift in solrconfig.xml is not supported > --

[jira] [Resolved] (SOLR-11587) Support xpointer attribute in xinclude to help reuse/modularization of schema.xml/solrConfig.xml

2024-02-16 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-11587. Resolution: Won't Do I believe we disabled and other fancy XML features due to security issues such

[jira] [Created] (SOLR-17165) Get rid of custom XML parsing

2024-02-16 Thread Jira
Jan Høydahl created SOLR-17165: -- Summary: Get rid of custom XML parsing Key: SOLR-17165 URL: https://issues.apache.org/jira/browse/SOLR-17165 Project: Solr Issue Type: Improvement Security

[jira] [Resolved] (SOLR-16810) Under certain situations Solr produces managed schema XML that cannot be loaded

2024-02-16 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16810. Resolution: Won't Fix See linked issues which are better suited to fix this issue. > Under certain

[jira] [Commented] (SOLR-16810) Under certain situations Solr produces managed schema XML that cannot be loaded

2024-02-16 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817954#comment-17817954 ] Jan Høydahl commented on SOLR-16810: The name enforcing is the good old SOLR-8110. T

Re: [PR] SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands [solr]

2024-02-16 Thread via GitHub
epugh commented on code in PR #1768: URL: https://github.com/apache/solr/pull/1768#discussion_r1492420335 ## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc: ## @@ -42,3 +42,15 @@ has been removed. Please use `-Dsolr.hiddenSysProps` or the envVar `

Re: [PR] SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands [solr]

2024-02-16 Thread via GitHub
epugh commented on PR #1768: URL: https://github.com/apache/solr/pull/1768#issuecomment-1948344050 Pending a good run off all the tests, I think I'm done and would love some review. This is to go into Solr X and not be backported to Solr 9... -- This is an automated message from the

Re: [PR] SOLR-6572: Trim whitespace in XML nodes in solrconfig.xml [solr]

2024-02-16 Thread via GitHub
cpoerschke commented on code in PR #2274: URL: https://github.com/apache/solr/pull/2274#discussion_r1492431063 ## solr/CHANGES.txt: ## @@ -110,6 +110,9 @@ Bug Fixes * SOLR-17148: Fixing Config API overlay property enabling or disabling the cache (Sanjay Dutt, hossman, Eric P

[PR] SOLR-17159: Remove post and postlogs from Solr X [solr]

2024-02-16 Thread via GitHub
epugh opened a new pull request, #2275: URL: https://github.com/apache/solr/pull/2275 https://issues.apache.org/jira/browse/SOLR-17159 # Description This removes bin/post and bin/postlogs in favour of bin/solr equivalents. # Solution Removal.. Still n

Re: [PR] SOLR-6572: Trim whitespace in XML nodes in solrconfig.xml [solr]

2024-02-16 Thread via GitHub
janhoy commented on PR #2274: URL: https://github.com/apache/solr/pull/2274#issuecomment-1948406528 Unfortunately several tests now fail due to the change. Meaning that the `DOMUtil` class is probably also used outside of config parsing. ``` ERROR: The following test(s) have failed

Re: [PR] SOLR-6572: Trim whitespace in XML nodes in solrconfig.xml [solr]

2024-02-16 Thread via GitHub
janhoy commented on PR #2274: URL: https://github.com/apache/solr/pull/2274#issuecomment-1948431295 The failure in `TestFreeTextSuggestions` is due to the need to configure a SPACE as separator, see https://github.com/apache/solr/blob/main/solr/core/src/test-files/solr/collection1/conf/solr

[jira] [Commented] (SOLR-17099) Unsolicited snitch tag warnings from AttributeFetcherImpl

2024-02-16 Thread Pierre Salagnac (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817972#comment-17817972 ] Pierre Salagnac commented on SOLR-17099: We're seeing this too. This is is easy t

Re: [PR] Update required JTS version [solr]

2024-02-16 Thread via GitHub
janhoy commented on PR #2273: URL: https://github.com/apache/solr/pull/2273#issuecomment-1948467690 Question: I see now that Solr already bundles `solr/modules/sql/lib/jts-core-1.19.0.jar`, pulled in by Calcite SQL parser. Is that JAR even used by the SQL parser? Could we coordinate by movi

Re: [PR] SOLR-6572: Trim whitespace in XML nodes in solrconfig.xml [solr]

2024-02-16 Thread via GitHub
cpoerschke commented on PR #2274: URL: https://github.com/apache/solr/pull/2274#issuecomment-1948486231 > ... Leave as is and make code reading config from XML more robust and do a local ... Intuitively I'd prefer that, not for the leave-as-is reason but the parser parsing on an as-i

Re: [PR] Update required JTS version [solr]

2024-02-16 Thread via GitHub
risdenk commented on PR #2273: URL: https://github.com/apache/solr/pull/2273#issuecomment-1948518961 @ejn what errors are you seeing to back up `Due to API changes a JTS 1.17.x version is currently required`? I would recommend that Lucene upgrade. Calcite has been on 1.19.x for ~2yrs

Re: [PR] SOLR-6572: Trim whitespace in XML nodes in solrconfig.xml [solr]

2024-02-16 Thread via GitHub
janhoy commented on PR #2274: URL: https://github.com/apache/solr/pull/2274#issuecomment-1948598593 The spec https://www.w3.org/TR/xml/#sec-white-space seems to suggest that white space handling is configurable, and that trimming leading/trailing whitespace stripping is the default. Again,

Re: [PR] SOLR-6572: Trim whitespace in XML nodes in solrconfig.xml [solr]

2024-02-16 Thread via GitHub
janhoy closed pull request #2274: SOLR-6572: Trim whitespace in XML nodes in solrconfig.xml URL: https://github.com/apache/solr/pull/2274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (SOLR-6572) lineshift in solrconfig.xml is not supported

2024-02-16 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818000#comment-17818000 ] Jan Høydahl commented on SOLR-6572: --- [~anuragsharma] I tested your patch in the attached

Re: [PR] Update required JTS version [solr]

2024-02-16 Thread via GitHub
jdyer1 commented on PR #2273: URL: https://github.com/apache/solr/pull/2273#issuecomment-1948635119 With JTS on a compatible license is there any reason not to distribute it in the WEB-INF folder, making this documentation moot? -- This is an automated message from the Apache Git Service.

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-02-16 Thread via GitHub
cpoerschke commented on code in PR #2248: URL: https://github.com/apache/solr/pull/2248#discussion_r1492900283 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -1979,36 +2226,84 @@ public ScoreMode scoreMode() { // no docs on this page, so cursor

[jira] [Commented] (SOLR-16139) [Regression] JSON stat facet functions not working on analysed String (SortableTextField)

2024-02-16 Thread Robet Olson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818090#comment-17818090 ] Robet Olson commented on SOLR-16139: Our project ran into this same issue when portin

Re: [PR] GH Labeler action: Category labels [solr]

2024-02-16 Thread via GitHub
dsmiley commented on PR #2190: URL: https://github.com/apache/solr/pull/2190#issuecomment-1949268032 LGTM @janhoy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] SOLR-17141: Create CpuQueryLimit implementation [solr]

2024-02-16 Thread via GitHub
dsmiley commented on code in PR #2244: URL: https://github.com/apache/solr/pull/2244#discussion_r1492951008 ## solr/core/src/test/org/apache/solr/search/TestCpuAllowedLimit.java: ## @@ -20,32 +20,61 @@ import java.nio.file.Files; import java.nio.file.Path; import java.util.co

Re: [PR] Build: ge.gradle add tags & projectId=solr [solr]

2024-02-16 Thread via GitHub
dsmiley merged PR #2264: URL: https://github.com/apache/solr/pull/2264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] solr.xml: honor plugin enable=true|false [solr]

2024-02-16 Thread via GitHub
dsmiley merged PR #2260: URL: https://github.com/apache/solr/pull/2260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] GH Labeler action: Category labels [solr]

2024-02-16 Thread via GitHub
janhoy merged PR #2190: URL: https://github.com/apache/solr/pull/2190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17156) BJQParserTest failure

2024-02-16 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818105#comment-17818105 ] Mikhail Khludnev commented on SOLR-17156: - pushed main with a few debug output in