[jira] [Commented] (SOLR-16691) Use Jackson for JSON serialization

2023-08-10 Thread Ovidiu Mihalcea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752675#comment-17752675 ] Ovidiu Mihalcea commented on SOLR-16691: I'm seeing some very weird formatting us

[GitHub] [solr] renatoh opened a new pull request, #1834: Cleaning up old code to prevent warnings

2023-08-10 Thread via GitHub
renatoh opened a new pull request, #1834: URL: https://github.com/apache/solr/pull/1834 Reading through the code in org.apache.solr.cli, I realized there are quite some warnings, which can be easily cleaned up -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (SOLR-16691) Use Jackson for JSON serialization

2023-08-10 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752776#comment-17752776 ] Noble Paul commented on SOLR-16691: --- Indent is a property of the serializing library. J

[GitHub] [solr] epugh commented on a diff in pull request #1834: Cleaning up old code to prevent warnings

2023-08-10 Thread via GitHub
epugh commented on code in PR #1834: URL: https://github.com/apache/solr/pull/1834#discussion_r1290029229 ## solr/core/src/java/org/apache/solr/cli/AssertTool.java: ## @@ -30,6 +30,7 @@ import org.apache.solr.client.solrj.SolrClient; import org.apache.solr.client.solrj.SolrSer

[GitHub] [solr] renatoh commented on a diff in pull request #1834: Cleaning up old code to prevent warnings

2023-08-10 Thread via GitHub
renatoh commented on code in PR #1834: URL: https://github.com/apache/solr/pull/1834#discussion_r1290046082 ## solr/core/src/java/org/apache/solr/cli/SimplePostTool.java: ## @@ -544,14 +537,20 @@ public int postFiles(File[] files, int startIndexInArgs, OutputStream out, Strin

[GitHub] [solr] janhoy commented on pull request #1832: SOLR-16733: Toggle Sec Manager when OSX+JDK20 used

2023-08-10 Thread via GitHub
janhoy commented on PR #1832: URL: https://github.com/apache/solr/pull/1832#issuecomment-1673136120 Personally I switch to JDK11 or 17 when running tests on my Mac. The alternative is to fail loudly and ask the dev to choose JDK17. There's a tiny risk that if more committers start usi

[jira] [Commented] (SOLR-15771) bin/solr auth enable should model best practices for security.json

2023-08-10 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752792#comment-17752792 ] Eric Pugh commented on SOLR-15771: -- [~janhoy] would you be interested in picking this on

[GitHub] [solr] epugh commented on pull request #1768: SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands

2023-08-10 Thread via GitHub
epugh commented on PR #1768: URL: https://github.com/apache/solr/pull/1768#issuecomment-1673183998 I think this branch has definitly had some bit rot, and there is a lot of work to update it Thanks for looking @mkhludnev at this branch, glad to get some input on this! -- This is an

[jira] [Commented] (SOLR-16691) Use Jackson for JSON serialization

2023-08-10 Thread Ovidiu Mihalcea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752800#comment-17752800 ] Ovidiu Mihalcea commented on SOLR-16691: [~noble.paul] I believe it's a bug from

[jira] [Comment Edited] (SOLR-16691) Use Jackson for JSON serialization

2023-08-10 Thread Ovidiu Mihalcea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752800#comment-17752800 ] Ovidiu Mihalcea edited comment on SOLR-16691 at 8/10/23 1:06 PM: --

[jira] [Commented] (SOLR-16691) Use Jackson for JSON serialization

2023-08-10 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752802#comment-17752802 ] Noble Paul commented on SOLR-16691: --- {{ }}   If just specifying the above does not wo

[jira] [Created] (SOLR-16924) Restore: Have RESTORECORE set the UpdateLog state

2023-08-10 Thread David Smiley (Jira)
David Smiley created SOLR-16924: --- Summary: Restore: Have RESTORECORE set the UpdateLog state Key: SOLR-16924 URL: https://issues.apache.org/jira/browse/SOLR-16924 Project: Solr Issue Type: Imp

[jira] [Commented] (SOLR-16691) Use Jackson for JSON serialization

2023-08-10 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752825#comment-17752825 ] Ishan Chattopadhyaya commented on SOLR-16691: - Even without that workaround,

[GitHub] [solr] HoustonPutman commented on pull request #1826: SOLR-16920: Test full package lifecycle

2023-08-10 Thread via GitHub
HoustonPutman commented on PR #1826: URL: https://github.com/apache/solr/pull/1826#issuecomment-1673359375 > One more idea, what if we comment out the test, so at least we have it someone wants to run it, but it isn't in the regular path? I'm +1 to this with a comment stating why the

[jira] [Created] (SOLR-16925) Broken JSON indentation using JacksonJsonWriter

2023-08-10 Thread Ovidiu Mihalcea (Jira)
Ovidiu Mihalcea created SOLR-16925: -- Summary: Broken JSON indentation using JacksonJsonWriter Key: SOLR-16925 URL: https://issues.apache.org/jira/browse/SOLR-16925 Project: Solr Issue Type:

[jira] [Updated] (SOLR-16925) Broken JSON indentation using JacksonJsonWriter

2023-08-10 Thread Ovidiu Mihalcea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ovidiu Mihalcea updated SOLR-16925: --- Security: (was: Public) > Broken JSON indentation using JacksonJsonWriter > -

[jira] [Comment Edited] (SOLR-16691) Use Jackson for JSON serialization

2023-08-10 Thread Ovidiu Mihalcea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752836#comment-17752836 ] Ovidiu Mihalcea edited comment on SOLR-16691 at 8/10/23 2:59 PM: --

[jira] [Commented] (SOLR-16691) Use Jackson for JSON serialization

2023-08-10 Thread Ovidiu Mihalcea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752836#comment-17752836 ] Ovidiu Mihalcea commented on SOLR-16691: I've open a new issue: [SOLR-16925|http

[GitHub] [solr] renatoh commented on a diff in pull request #1834: Cleaning up old code to prevent warnings

2023-08-10 Thread via GitHub
renatoh commented on code in PR #1834: URL: https://github.com/apache/solr/pull/1834#discussion_r1290046082 ## solr/core/src/java/org/apache/solr/cli/SimplePostTool.java: ## @@ -544,14 +537,20 @@ public int postFiles(File[] files, int startIndexInArgs, OutputStream out, Strin

[jira] [Commented] (SOLR-16644) Entropy warning thresholds need to be revisited

2023-08-10 Thread Raghavan Muthuregunathan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752863#comment-17752863 ] Raghavan Muthuregunathan commented on SOLR-16644: - I am working on a PR f

[jira] [Commented] (SOLR-16925) Broken JSON indentation using JacksonJsonWriter

2023-08-10 Thread Raghavan Muthuregunathan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752862#comment-17752862 ] Raghavan Muthuregunathan commented on SOLR-16925: - I am working on a PR f

[jira] [Commented] (SOLR-16920) Add Full Lifecycle Bats test for installing a Package

2023-08-10 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752876#comment-17752876 ] Eric Pugh commented on SOLR-16920: -- The attached PR goes part way, but because we don't

[GitHub] [solr] epugh merged pull request #1826: SOLR-16920: Test full package lifecycle

2023-08-10 Thread via GitHub
epugh merged PR #1826: URL: https://github.com/apache/solr/pull/1826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-16920) Add Full Lifecycle Bats test for installing a Package

2023-08-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752882#comment-17752882 ] ASF subversion and git services commented on SOLR-16920: Commit 8

[jira] [Comment Edited] (SOLR-16920) Add Full Lifecycle Bats test for installing a Package

2023-08-10 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752876#comment-17752876 ] Eric Pugh edited comment on SOLR-16920 at 8/10/23 4:52 PM: --- The

[jira] [Commented] (SOLR-16920) Add Full Lifecycle Bats test for installing a Package

2023-08-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752883#comment-17752883 ] ASF subversion and git services commented on SOLR-16920: Commit 8

[GitHub] [solr] laminelam commented on pull request #1798: Add/fix wrong/missing "solr.home" to zkcli scripts

2023-08-10 Thread via GitHub
laminelam commented on PR #1798: URL: https://github.com/apache/solr/pull/1798#issuecomment-1673715418 > Thanks for looking at this.. one thought, would you want to add some BATS test to confirm these fixes? They have been great for verifying a lot of the SolrCLI things... Down the road, I

[GitHub] [solr-operator] sarkaramrit2 opened a new issue, #599: Solr 9.2.1 K8s issue

2023-08-10 Thread via GitHub
sarkaramrit2 opened a new issue, #599: URL: https://github.com/apache/solr-operator/issues/599 Solr 9.2.1 facing two issues: * except solr home dir, read/write permissions are needed and hence fails ``` "solrClientTLS": { "mountedTLS

[GitHub] [solr] iamsanjay commented on pull request #1119: [SOLR-16461] Create v2 equivalent of v1 ReplicationHandler 'BACKUP'

2023-08-10 Thread via GitHub
iamsanjay commented on PR #1119: URL: https://github.com/apache/solr/pull/1119#issuecomment-1673749396 > @iamsanjay are you ok with me pushing some changes to this PR's branch to get things goin again? Yes @stillalex go ahead. Let me know if you have any questions. -- This is an au

[jira] [Created] (SOLR-16926) Embedded ZK not reachable via docker v9.2.1

2023-08-10 Thread Amrit Sarkar (Jira)
Amrit Sarkar created SOLR-16926: --- Summary: Embedded ZK not reachable via docker v9.2.1 Key: SOLR-16926 URL: https://issues.apache.org/jira/browse/SOLR-16926 Project: Solr Issue Type: Bug

[jira] [Updated] (SOLR-16926) Embedded ZK not reachable via docker v9.2.1

2023-08-10 Thread Amrit Sarkar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amrit Sarkar updated SOLR-16926: Description: Embedded ZK running within Solr docker image for v9.2.1 is not reachable. ZK running:

[jira] [Updated] (SOLR-16926) Embedded ZK not reachable via docker v9.2.1

2023-08-10 Thread Amrit Sarkar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amrit Sarkar updated SOLR-16926: Description: Embedded ZK running within Solr docker image for v9.2.1 is not reachable. ZK running:

[jira] [Commented] (SOLR-16926) Embedded ZK not reachable via docker v9.2.1

2023-08-10 Thread Amrit Sarkar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752914#comment-17752914 ] Amrit Sarkar commented on SOLR-16926: - CC [~houston], team: let me know if need more

[jira] [Updated] (SOLR-16926) Embedded ZK not reachable via docker v9.2.1

2023-08-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-16926: -- Affects Version/s: 9.0 (was: 9.2.1) > Embedded ZK not reachable via

[GitHub] [solr] epugh commented on pull request #1798: Add/fix wrong/missing "solr.home" to zkcli scripts

2023-08-10 Thread via GitHub
epugh commented on PR #1798: URL: https://github.com/apache/solr/pull/1798#issuecomment-1673843170 i had no idea that behind the zkcli scripts was a Java class! I think we should only have one variable name, whichever we have been using the most. One more thought... I've been slow

[GitHub] [solr] epugh commented on pull request #1798: Add/fix wrong/missing "solr.home" to zkcli scripts

2023-08-10 Thread via GitHub
epugh commented on PR #1798: URL: https://github.com/apache/solr/pull/1798#issuecomment-1673847349 Might be worth a grep thorugh the ref guide re "solrHome" versus "solr.home" too! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [solr] laminelam commented on pull request #1798: Add/fix wrong/missing "solr.home" to zkcli scripts

2023-08-10 Thread via GitHub
laminelam commented on PR #1798: URL: https://github.com/apache/solr/pull/1798#issuecomment-1673852267 > One more thought... I've been slowly moving various scripts under the "bin/solr" SolrCLI as tools. Once this get's merged, would you be interested in migrating this over to "bin/solr

[GitHub] [solr] laminelam commented on pull request #1798: Add/fix wrong/missing "solr.home" to zkcli scripts

2023-08-10 Thread via GitHub
laminelam commented on PR #1798: URL: https://github.com/apache/solr/pull/1798#issuecomment-1673869102 > Might be worth a grep thorugh the ref guide re "solrHome" versus "solr.home" too! The only place where "solr.home" is used is [here](https://github.com/apache/solr/blob/707043872b

[GitHub] [solr] stillalex commented on pull request #1779: SOLR-16859 Missing Proxy support for Http2SolrClient

2023-08-10 Thread via GitHub
stillalex commented on PR #1779: URL: https://github.com/apache/solr/pull/1779#issuecomment-1673926139 > I noticed that we have a test_ssl.bats test that exercises Solr. I wonder if extending those tests would help validate this fix? no, we'd need a proxy server for testing ...unless

[jira] [Created] (SOLR-16927) Allow SolrClientCache clients to use Jetty HTTP2 clients

2023-08-10 Thread Alex Deparvu (Jira)
Alex Deparvu created SOLR-16927: --- Summary: Allow SolrClientCache clients to use Jetty HTTP2 clients Key: SOLR-16927 URL: https://issues.apache.org/jira/browse/SOLR-16927 Project: Solr Issue Typ

[GitHub] [solr] stillalex opened a new pull request, #1835: SOLR-16927 Allow SolrClientCache clients to use Jetty HTTP2 clients

2023-08-10 Thread via GitHub
stillalex opened a new pull request, #1835: URL: https://github.com/apache/solr/pull/1835 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution

[GitHub] [solr] stillalex commented on pull request #1835: SOLR-16927 Allow SolrClientCache clients to use Jetty HTTP2 clients

2023-08-10 Thread via GitHub
stillalex commented on PR #1835: URL: https://github.com/apache/solr/pull/1835#issuecomment-1674002231 looking for a review on this. @dsmiley, @epugh @joel-bernstein I hope you don't mind I added you. looking forward to your thoughts! -- This is an automated message from the Apache Git Se

[jira] [Commented] (SOLR-14201) some SolrCore are not released after being removed

2023-08-10 Thread Diego Estrada (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752987#comment-17752987 ] Diego Estrada commented on SOLR-14201: -- Using solr 8.11.2 we were able to stop the m

[GitHub] [solr] risdenk commented on a diff in pull request #1835: SOLR-16927 Allow SolrClientCache clients to use Jetty HTTP2 clients

2023-08-10 Thread via GitHub
risdenk commented on code in PR #1835: URL: https://github.com/apache/solr/pull/1835#discussion_r1290795542 ## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/CommitStream.java: ## @@ -55,6 +55,7 @@ public class CommitStream extends TupleStream implements E

[GitHub] [solr] stillalex commented on a diff in pull request #1835: SOLR-16927 Allow SolrClientCache clients to use Jetty HTTP2 clients

2023-08-10 Thread via GitHub
stillalex commented on code in PR #1835: URL: https://github.com/apache/solr/pull/1835#discussion_r1290830940 ## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/CommitStream.java: ## @@ -55,6 +55,7 @@ public class CommitStream extends TupleStream implements