[GitHub] [solr] Willdotwhite commented on pull request #1759: SOLR-16870: remove now dead lines of code

2023-07-16 Thread via GitHub
Willdotwhite commented on PR #1759: URL: https://github.com/apache/solr/pull/1759#issuecomment-1637154270 Not sure this is ready to go yet; either my testing is flawed (below), or we're not catching the new flags: ```powershell PS C:\Users\Will\Projects\solr\solr\packaging\build\de

[GitHub] [solr] Willdotwhite commented on pull request #1759: SOLR-16870: remove now dead lines of code

2023-07-16 Thread via GitHub
Willdotwhite commented on PR #1759: URL: https://github.com/apache/solr/pull/1759#issuecomment-1637155939 Pull request mentioned - FYI @epugh: https://github.com/epugh/solr/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [solr] Willdotwhite commented on pull request #1786: SOLR-16883: Use postlogs tool from windows and unix via solr cli infrastructure.

2023-07-16 Thread via GitHub
Willdotwhite commented on PR #1786: URL: https://github.com/apache/solr/pull/1786#issuecomment-1637161645 Tested @epugh 👍🏻 - I've no idea _what_ I just did, but it certainly did it: ```powershell PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> .\solr.cmd postlogs -url

[GitHub] [solr] Willdotwhite commented on pull request #1786: SOLR-16883: Use postlogs tool from windows and unix via solr cli infrastructure.

2023-07-16 Thread via GitHub
Willdotwhite commented on PR #1786: URL: https://github.com/apache/solr/pull/1786#issuecomment-1637161832 The `-help` command prints the following, but doesn't actually explain **what** the command does - should that live in the help output, or do we expect people to check the online docs?

[GitHub] [solr] Willdotwhite commented on pull request #1784: SOLR-16842: Make "version" just another Tool.

2023-07-16 Thread via GitHub
Willdotwhite commented on PR #1784: URL: https://github.com/apache/solr/pull/1784#issuecomment-1637162578 LGTM ✅ ```powershell PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> .\solr.cmd -v Solr version is: 10.0.0 PS C:\Users\Will\Projects\solr\solr\packagi

[jira] [Commented] (SOLR-16894) Configurable doc freq: Allow StatsCache instances to be ResourceLoaderAware

2023-07-16 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743596#comment-17743596 ] Noble Paul commented on SOLR-16894: --- Instead of blindly adding ResourceLoader support,