[GitHub] [solr] murblanc commented on a diff in pull request #1691: SOLR-16717: Join multiple distributed shards

2023-07-03 Thread via GitHub
murblanc commented on code in PR #1691: URL: https://github.com/apache/solr/pull/1691#discussion_r1250853774 ## solr/core/src/java/org/apache/solr/search/join/ScoreJoinQParserPlugin.java: ## @@ -355,43 +375,163 @@ private static String resolveAlias(String fromIndex, ZkControlle

[jira] [Commented] (SOLR-16717) Joining collocated shards

2023-07-03 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739621#comment-17739621 ] Ilan Ginzburg commented on SOLR-16717: -- Left a few comments on the [PR|http://examp

[GitHub] [solr] stillalex opened a new pull request, #1749: SOLR-16853 Upgrade Lucene to 9.7.0

2023-07-03 Thread via GitHub
stillalex opened a new pull request, #1749: URL: https://github.com/apache/solr/pull/1749 https://issues.apache.org/jira/browse/SOLR-16853 # Description Upgrade Lucene to 9.7.0 # Solution Please provide a short description of the approach taken to imple

[jira] [Commented] (SOLR-16853) Upgrade Lucene to 9.7.0

2023-07-03 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739673#comment-17739673 ] Alex Deparvu commented on SOLR-16853: - PR up for review https://github.com/apache/sol

[GitHub] [solr] stillalex commented on pull request #1749: SOLR-16853 Upgrade Lucene to 9.7.0

2023-07-03 Thread via GitHub
stillalex commented on PR #1749: URL: https://github.com/apache/solr/pull/1749#issuecomment-1618773053 running the tests again for good measure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [solr] stillalex commented on pull request #1749: SOLR-16853 Upgrade Lucene to 9.7.0

2023-07-03 Thread via GitHub
stillalex commented on PR #1749: URL: https://github.com/apache/solr/pull/1749#issuecomment-1618814814 this is failing but due to unrelated changes ``` > Task :solr:core:compileTestJava /home/runner/work/solr/solr/solr/core/src/test/org/apache/solr/handler/admin/api/CoreReplication

[GitHub] [solr] stillalex commented on pull request #1748: Update org.apache.lucene:* to v9.7.0

2023-07-03 Thread via GitHub
stillalex commented on PR #1748: URL: https://github.com/apache/solr/pull/1748#issuecomment-1618817655 the lucene upgrade should have been ignored, I aded the exception myself https://github.com/apache/solr/blob/main/.github/renovate.json#L46 maybe I got the incantation wrong? -- This

[GitHub] [solr] stillalex commented on pull request #1748: Update org.apache.lucene:* to v9.7.0

2023-07-03 Thread via GitHub
stillalex commented on PR #1748: URL: https://github.com/apache/solr/pull/1748#issuecomment-1618818779 the real upgrade PR is here https://github.com/apache/solr/pull/1749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Commented] (SOLR-15819) spurious failures from TestCircuitBreaker.testResponseWithCBTiming

2023-07-03 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739706#comment-17739706 ] Alex Deparvu commented on SOLR-15819: - [~hossman] I took a look at this failing test

[jira] [Comment Edited] (SOLR-15819) spurious failures from TestCircuitBreaker.testResponseWithCBTiming

2023-07-03 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739706#comment-17739706 ] Alex Deparvu edited comment on SOLR-15819 at 7/3/23 6:05 PM: -

[jira] [Commented] (SOLR-16717) Joining collocated shards

2023-07-03 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739729#comment-17739729 ] Mikhail Khludnev commented on SOLR-16717: - Thanks for review [~ilan]. I think I'v

[GitHub] [solr] eliaporciani opened a new pull request, #1750: Feature/solr 16675 dense vector function queries

2023-07-03 Thread via GitHub
eliaporciani opened a new pull request, #1750: URL: https://github.com/apache/solr/pull/1750 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution

[jira] [Commented] (SOLR-16675) Introduce the possibility to rerank topK results with vector similarity functions using DenseVectorField

2023-07-03 Thread Elia Porciani (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739730#comment-17739730 ] Elia Porciani commented on SOLR-16675: -- Function queries for knn vectors have been i

[GitHub] [solr] mkhludnev commented on a diff in pull request #1691: SOLR-16717: Join multiple distributed shards

2023-07-03 Thread via GitHub
mkhludnev commented on code in PR #1691: URL: https://github.com/apache/solr/pull/1691#discussion_r1251567956 ## solr/core/src/java/org/apache/solr/search/join/ScoreJoinQParserPlugin.java: ## @@ -355,43 +375,163 @@ private static String resolveAlias(String fromIndex, ZkControll

[jira] [Created] (SOLR-16859) Missing Proxy support for Http2SolrClient

2023-07-03 Thread Rainer Koschnick (Jira)
Rainer Koschnick created SOLR-16859: --- Summary: Missing Proxy support for Http2SolrClient Key: SOLR-16859 URL: https://issues.apache.org/jira/browse/SOLR-16859 Project: Solr Issue Type: Bug