psalagnac commented on PR #1465:
URL: https://github.com/apache/solr/pull/1465#issuecomment-1486416452
Hi @markrmiller,
Thanks for looking into this.
Is this change good to be merged? Is something else required?
Thanks
--
This is an automated message from the Apache Git Service.
T
[
https://issues.apache.org/jira/browse/SOLR-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705878#comment-17705878
]
Jan Høydahl commented on SOLR-16465:
FYI: https://lists.apache.org/thread/nfm6jj41bop
[
https://issues.apache.org/jira/browse/SOLR-16601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705935#comment-17705935
]
Eric Pugh commented on SOLR-16601:
--
This is ready for review! Can removing the depreca
[
https://issues.apache.org/jira/browse/SOLR-16601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-16601:
Assignee: Eric Pugh
> Remove Deprecated Methods from Solr Clients
> --
risdenk opened a new pull request, #1498:
URL: https://github.com/apache/solr/pull/1498
https://issues.apache.org/jira/browse/SOLR-X
This is NOT ready for review yet. This just works down the list of commons
lang3 usages and tries to replace them with JDK methods where possible.
epugh opened a new pull request, #1499:
URL: https://github.com/apache/solr/pull/1499
https://issues.apache.org/jira/browse/SOLR-16604
# Description
Swap to using Builder directly.
# Solution
Using the non deprecated version of the Builders where possible,
epugh commented on PR #1499:
URL: https://github.com/apache/solr/pull/1499#issuecomment-1486887898
@dsmiley starting the migration ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
HoustonPutman commented on PR #343:
URL: https://github.com/apache/solr-operator/pull/343#issuecomment-1487014768
@piotrrybicki Please open your own PR. We'd love to support as many globals
as possible, to make setup easy for everyone!
As for my comment above it would be great if the
HoustonPutman commented on issue #534:
URL: https://github.com/apache/solr-operator/issues/534#issuecomment-1487027991
Ahh so it looks like the zookeeper operator does support additional volumes,
but the solr operator doesn't allow that functionality. We should make a PR to
add the addition
HoustonPutman commented on issue #533:
URL: https://github.com/apache/solr-operator/issues/533#issuecomment-1487041283
Under `authentication` I think you need to add `"blockUnknown": false`. You
are authorized for those endpoints, but since you are not providing the basic
auth header, you a
HoustonPutman opened a new issue, #535:
URL: https://github.com/apache/solr-operator/issues/535
Kubernetes ClusterIP Services allow for sessionAffinity, and customization
of the max session stickiness timeout.
More information can be found here:
https://kubernetes.io/docs/reference/n
GiuseppeCSI commented on issue #533:
URL: https://github.com/apache/solr-operator/issues/533#issuecomment-1487088565
I think i misinterpreted this part
> First, the probesRequireAuth setting (defaults to false) governs the value
for blockUnknown (under authentication) and whether the
solrbot closed pull request #1492: Update dependency
io.swagger.core.v3:swagger-annotations to v2.2.9 - autoclosed
URL: https://github.com/apache/solr/pull/1492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
[
https://issues.apache.org/jira/browse/SOLR-16601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706061#comment-17706061
]
Jan Høydahl commented on SOLR-16601:
All public facing SolrJ code deprecated after 9.
sonatype-lift[bot] commented on code in PR #1498:
URL: https://github.com/apache/solr/pull/1498#discussion_r1150808170
##
solr/core/src/java/org/apache/solr/cloud/ExclusiveSliceProperty.java:
##
@@ -76,13 +77,13 @@ class ExclusiveSliceProperty {
ExclusiveSliceProperty(Cluster
HoustonPutman commented on issue #529:
URL: https://github.com/apache/solr-operator/issues/529#issuecomment-1487136250
@janhoy we should also create a Solr JIRA issue for this, to fix Cloud-aware
clients and internal shard requests.
More info: We can fix this for simple use cases wher
janhoy commented on code in PR #1496:
URL: https://github.com/apache/solr/pull/1496#discussion_r1150844208
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrClient.java:
##
@@ -116,12 +114,23 @@ protected ConcurrentUpdateSolrClient(Builder builder) {
HoustonPutman closed issue #532: Updating Solr Document Results Duplicate
Versions
URL: https://github.com/apache/solr-operator/issues/532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
HoustonPutman commented on issue #532:
URL: https://github.com/apache/solr-operator/issues/532#issuecomment-1487210778
I'd post this question to the [solr users
list](https://solr.apache.org/community.html#mailing-lists-chat), since this
question is purely about Solr and not about interacti
HoustonPutman commented on issue #533:
URL: https://github.com/apache/solr-operator/issues/533#issuecomment-1487217238
Did you try to update an existing cluster or create a new one?
Also even if you deleted and recreated, you need to make sure that Zookeeper
didn't use the same persis
janhoy commented on code in PR #530:
URL: https://github.com/apache/solr-operator/pull/530#discussion_r1150958026
##
controllers/util/solr_update_util_test.go:
##
@@ -180,6 +205,26 @@ func TestPickPodsToUpgrade(t *testing.T) {
solrCloud.Spec.Replicas = Replicas(4)
janhoy commented on issue #529:
URL: https://github.com/apache/solr-operator/issues/529#issuecomment-1487367447
> @janhoy we should also create a Solr JIRA issue for this, to fix
Cloud-aware clients and internal shard requests.
Sure, I can create one. Do you have a clear idea of how
risdenk opened a new pull request, #1500:
URL: https://github.com/apache/solr/pull/1500
https://issues.apache.org/jira/browse/SOLR-X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
janhoy commented on code in PR #1500:
URL: https://github.com/apache/solr/pull/1500#discussion_r115011
##
solr/core/src/java/org/apache/solr/search/SolrDocumentFetcher.java:
##
@@ -762,7 +761,7 @@ private boolean returnStoredFields() {
}
private boolean returnDVF
janhoy merged PR #1489:
URL: https://github.com/apache/solr/pull/1489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
sonatype-lift[bot] commented on code in PR #1500:
URL: https://github.com/apache/solr/pull/1500#discussion_r1151031492
##
solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java:
##
@@ -307,15 +303,14 @@ public Map
getPackagesDeployedAsClusterLevelPlugins
i
HoustonPutman commented on issue #529:
URL: https://github.com/apache/solr-operator/issues/529#issuecomment-1487463171
Not a clear idea yet.
> Would we need some new per-node-state znode in Zookeeper to flag a node as
"draining", and then let SolrJ act on that?
That would work,
risdenk opened a new pull request, #1501:
URL: https://github.com/apache/solr/pull/1501
https://issues.apache.org/jira/browse/SOLR-X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
[
https://issues.apache.org/jira/browse/SOLR-16668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706116#comment-17706116
]
Shawn Heisey commented on SOLR-16668:
-
{quote}Huh, I thought one of our drivers for u
HoustonPutman commented on PR #14:
URL: https://github.com/apache/solr-docker/pull/14#issuecomment-1487473448
Ok so Solr 9.2 officially has jattach 2.0 built in:
```
❯ docker run -it --rm solr:9.2 jattach --version
jattach 2.0 built on Aug 16 2021
```
So we can put jatt
[
https://issues.apache.org/jira/browse/SOLR-16668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706118#comment-17706118
]
Shawn Heisey commented on SOLR-16668:
-
{quote}you might also need to upgrade Spring b
janhoy opened a new pull request, #1502:
URL: https://github.com/apache/solr/pull/1502
https://issues.apache.org/jira/browse/SOLR-16721
Simple fix. Removing the `head` filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
[
https://issues.apache.org/jira/browse/SOLR-16721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-16721:
--
Assignee: Jan Høydahl
> Java version detection fails when `_JAVA_OPTIONS` is set
> ---
[
https://issues.apache.org/jira/browse/SOLR-16721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706133#comment-17706133
]
Jan Høydahl commented on SOLR-16721:
[~zhongruoyu]
I reproduced the issue by setting
sonatype-lift[bot] commented on code in PR #1501:
URL: https://github.com/apache/solr/pull/1501#discussion_r1151106048
##
solr/core/src/java/org/apache/solr/logging/jul/JulWatcher.java:
##
@@ -157,7 +158,9 @@ public SolrDocument toSolrDocument(LogRecord event) {
doc.setFiel
risdenk commented on code in PR #1496:
URL: https://github.com/apache/solr/pull/1496#discussion_r1151109774
##
solr/core/src/test/org/apache/solr/cloud/TestRandomFlRTGCloud.java:
##
@@ -147,6 +148,7 @@ public class TestRandomFlRTGCloud extends SolrCloudTestCase
{
new
Jan Høydahl created SOLR-16722:
--
Summary: API to flag a solr node NOT READY for requests
Key: SOLR-16722
URL: https://issues.apache.org/jira/browse/SOLR-16722
Project: Solr
Issue Type: New Featu
janhoy commented on issue #529:
URL: https://github.com/apache/solr-operator/issues/529#issuecomment-1487551816
https://issues.apache.org/jira/browse/SOLR-16722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
[
https://issues.apache.org/jira/browse/SOLR-16722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706145#comment-17706145
]
Jan Høydahl commented on SOLR-16722:
One simple option is to create a new top-level z
risdenk commented on code in PR #1407:
URL: https://github.com/apache/solr/pull/1407#discussion_r1151134327
##
solr/solrj/src/java/org/noggit/JSONUtil.java:
##
@@ -17,11 +17,19 @@
package org.noggit;
public class JSONUtil {
+ @SuppressWarnings("MutablePublicArray")
publi
Kevin Risden created SOLR-16723:
---
Summary: Http2SolrClient should not use Apache Http client classes
Key: SOLR-16723
URL: https://issues.apache.org/jira/browse/SOLR-16723
Project: Solr
Issue Ty
[
https://issues.apache.org/jira/browse/SOLR-16723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16723:
Description:
https://lists.apache.org/thread/vz6gldbdq0gylncpwsoshfvlvns4kqv8
> Http2SolrClient
[
https://issues.apache.org/jira/browse/SOLR-16723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16723:
Affects Version/s: 9.2
> Http2SolrClient should not use Apache Http client classes
> --
[
https://issues.apache.org/jira/browse/SOLR-16723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16723:
Description:
@elyograg pointed out that Http2SolrClient has Apache Http Client class in use
and it
[
https://issues.apache.org/jira/browse/SOLR-16723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16723:
Priority: Minor (was: Major)
> Http2SolrClient should not use Apache Http client classes
> ---
risdenk opened a new pull request, #1503:
URL: https://github.com/apache/solr/pull/1503
https://issues.apache.org/jira/browse/SOLR-16723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
[
https://issues.apache.org/jira/browse/SOLR-16723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16723:
Status: Patch Available (was: Open)
> Http2SolrClient should not use Apache Http client classes
>
[
https://issues.apache.org/jira/browse/SOLR-16722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706151#comment-17706151
]
Jan Høydahl commented on SOLR-16722:
Another obvious option would be for the Solr Ope
hmontesdeoca commented on issue #534:
URL: https://github.com/apache/solr-operator/issues/534#issuecomment-1487639416
thank you for the information, I will relay this to my team.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
noblepaul commented on PR #1485:
URL: https://github.com/apache/solr/pull/1485#issuecomment-1487748631
LGTM , `snitch` must be removed anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
[
https://issues.apache.org/jira/browse/SOLR-16723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706204#comment-17706204
]
David Smiley commented on SOLR-16723:
-
SOLR-16079 -- once we modularize the HttpClien
[
https://issues.apache.org/jira/browse/SOLR-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706228#comment-17706228
]
Marcus Eagan commented on SOLR-16465:
-
Thanks [~janhoy] that's helpful.
[~gus] regar
52 matches
Mail list logo
