MarcusSorealheis opened a new pull request, #1479:
URL: https://github.com/apache/solr/pull/1479
[SOLR-16465](https://issues.apache.org/jira/browse/SOLR-16465)
# Description
This PR will replace the login screen functionality with new, modern
technologies.
#
MarcusSorealheis commented on PR #1479:
URL: https://github.com/apache/solr/pull/1479#issuecomment-1479031217
Obviously a lot of work still to do, some of it really obvious, but I see
light at the end of the tunnel. Forgive me if there are any silly mistakes that
pop out. I'm mostly a data
[
https://issues.apache.org/jira/browse/SOLR-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703522#comment-17703522
]
Marcus Eagan commented on SOLR-16465:
-
I started the effort here. Made more progress
[
https://issues.apache.org/jira/browse/SOLR-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703526#comment-17703526
]
Marcus Eagan commented on SOLR-16465:
-
Wow Jira bot? 10 minutes? Much more banging my
bruno-roustant commented on code in PR #1466:
URL: https://github.com/apache/solr/pull/1466#discussion_r1144360207
##
solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java:
##
@@ -1265,15 +1260,13 @@ protected Elevation mergeWith(Elevation elevation)
bruno-roustant commented on code in PR #1466:
URL: https://github.com/apache/solr/pull/1466#discussion_r1144355359
##
solr/core/src/java/org/apache/solr/cloud/SizeLimitedDistributedMap.java:
##
@@ -77,7 +77,7 @@ protected boolean lessThan(Long a, Long b) {
}
mkhludnev opened a new pull request, #1480:
URL: https://github.com/apache/solr/pull/1480
https://issues.apache.org/jira/browse/SOLR-16707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/SOLR-16714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-16714:
--
Assignee: Jan Høydahl
> ReleaseWizard to add dependency upgrades to CHANGES
>
[
https://issues.apache.org/jira/browse/SOLR-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703548#comment-17703548
]
Jan Høydahl commented on SOLR-16465:
I'd start with a Proof Of Concept without Auth,
[
https://issues.apache.org/jira/browse/SOLR-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703567#comment-17703567
]
Mikhail Khludnev commented on SOLR-16707:
-
band aid [https://github.com/apache/so
[
https://issues.apache.org/jira/browse/SOLR-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703570#comment-17703570
]
Mikhail Khludnev commented on SOLR-1:
-
The question risen in scope of SOLR-16
magibney opened a new pull request, #1481:
URL: https://github.com/apache/solr/pull/1481
an alternative to #1480
See: SOLR-16707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
dsmiley commented on code in PR #1466:
URL: https://github.com/apache/solr/pull/1466#discussion_r1144811614
##
solr/core/src/java/org/apache/solr/cloud/SizeLimitedDistributedMap.java:
##
@@ -77,7 +77,7 @@ protected boolean lessThan(Long a, Long b) {
}
};
[
https://issues.apache.org/jira/browse/SOLR-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703668#comment-17703668
]
Michael Gibney commented on SOLR-16707:
---
I opened an alternative PR:
[apache/solr#
risdenk commented on code in PR #1466:
URL: https://github.com/apache/solr/pull/1466#discussion_r1144816158
##
solr/core/src/java/org/apache/solr/cloud/SizeLimitedDistributedMap.java:
##
@@ -77,7 +77,7 @@ protected boolean lessThan(Long a, Long b) {
}
};
risdenk commented on code in PR #1466:
URL: https://github.com/apache/solr/pull/1466#discussion_r1144820135
##
solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java:
##
@@ -1558,7 +1556,7 @@ Solution is q(k) = 1/2 (k^2+k+2)
public Builder addSu
bruno-roustant commented on code in PR #1466:
URL: https://github.com/apache/solr/pull/1466#discussion_r1144821047
##
solr/core/src/java/org/apache/solr/cloud/SizeLimitedDistributedMap.java:
##
@@ -77,7 +77,7 @@ protected boolean lessThan(Long a, Long b) {
}
gerlowskija commented on code in PR #1458:
URL: https://github.com/apache/solr/pull/1458#discussion_r1144825350
##
solr/core/src/java/org/apache/solr/handler/admin/api/InstallCoreDataAPI.java:
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
risdenk commented on code in PR #1466:
URL: https://github.com/apache/solr/pull/1466#discussion_r1144829541
##
solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java:
##
@@ -1265,15 +1260,13 @@ protected Elevation mergeWith(Elevation elevation) {
risdenk commented on code in PR #1466:
URL: https://github.com/apache/solr/pull/1466#discussion_r1144830743
##
solr/core/src/java/org/apache/solr/cloud/SizeLimitedDistributedMap.java:
##
@@ -77,7 +77,7 @@ protected boolean lessThan(Long a, Long b) {
}
};
risdenk commented on code in PR #1466:
URL: https://github.com/apache/solr/pull/1466#discussion_r1144831967
##
solr/core/src/java/org/apache/solr/cloud/SizeLimitedDistributedMap.java:
##
@@ -77,7 +77,7 @@ protected boolean lessThan(Long a, Long b) {
}
};
Kevin Risden created SOLR-16715:
---
Summary: Replace new HashMap(int) and new HashSet(int) with
CollectionUtil.newHashMap / CollectionUtil.newHashSet
Key: SOLR-16715
URL: https://issues.apache.org/jira/browse/SOLR-167
risdenk commented on code in PR #1466:
URL: https://github.com/apache/solr/pull/1466#discussion_r1144836611
##
solr/core/src/java/org/apache/solr/cloud/SizeLimitedDistributedMap.java:
##
@@ -77,7 +77,7 @@ protected boolean lessThan(Long a, Long b) {
}
};
risdenk merged PR #1466:
URL: https://github.com/apache/solr/pull/1466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-16713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703690#comment-17703690
]
ASF subversion and git services commented on SOLR-16713:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-16713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16713:
Fix Version/s: main (10.0)
> Replace Guava usages with pure Java
> ---
[
https://issues.apache.org/jira/browse/SOLR-16713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703691#comment-17703691
]
Kevin Risden commented on SOLR-16713:
-
merged to main - going to give it a day or two
magibney commented on PR #1481:
URL: https://github.com/apache/solr/pull/1481#issuecomment-1479685970
I'm thinking this warrants a "bugfix" CHANGES.txt entry?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
epugh commented on PR #1476:
URL: https://github.com/apache/solr/pull/1476#issuecomment-1479771420
> Getting to done on this... A question, should I move SolrCLI.java into the
`.utils.cli` package and update the scripts etc? Any other changes that folks
think need doing to call this "done"
bszabo97 commented on code in PR #1182:
URL: https://github.com/apache/solr/pull/1182#discussion_r1145069656
##
solr/core/src/java/org/apache/solr/packagemanager/DefaultPackageRepository.java:
##
@@ -101,16 +106,21 @@ public Path download(String artifactName) throws
SolrExcepti
bszabo97 commented on code in PR #1182:
URL: https://github.com/apache/solr/pull/1182#discussion_r1145069656
##
solr/core/src/java/org/apache/solr/packagemanager/DefaultPackageRepository.java:
##
@@ -101,16 +106,21 @@ public Path download(String artifactName) throws
SolrExcepti
bszabo97 commented on code in PR #1182:
URL: https://github.com/apache/solr/pull/1182#discussion_r1145083082
##
solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java:
##
@@ -228,20 +230,20 @@ public List
fetchInstalledPackageInstances() throws SolrExc
public
bszabo97 commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1479921161
I am right now working on a bigger cleanup because there is plenty to do and
afterwards if you are also happy with how this looks I am all in for starting
the testing.
--
This is an auto
[
https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703746#comment-17703746
]
Andrzej Bialecki commented on SOLR-16507:
-
bq. Do you think there's a point to Sp
[
https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703753#comment-17703753
]
David Smiley commented on SOLR-16507:
-
Solr talks to Solr all the time and it's not h
[
https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703755#comment-17703755
]
David Smiley commented on SOLR-16507:
-
[~vinayakhegde] I think you had some WIP for t
risdenk opened a new pull request, #1482:
URL: https://github.com/apache/solr/pull/1482
https://issues.apache.org/jira/browse/SOLR-16715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
risdenk commented on code in PR #1482:
URL: https://github.com/apache/solr/pull/1482#discussion_r1145376884
##
solr/solrj/src/java/org/apache/solr/common/util/CommandOperation.java:
##
@@ -223,7 +223,7 @@ public static List parse(InputStream in,
Set singleton
List operatio
[
https://issues.apache.org/jira/browse/SOLR-16715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16715:
Status: Patch Available (was: Open)
> Replace new HashMap(int) and new HashSet(int) with Collectio
epugh commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1145394388
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -332,6 +335,11 @@ public Builder withRetryExpiryTime(long expiryTime,
TimeUnit uni
[
https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703794#comment-17703794
]
Eric Pugh commented on SOLR-10466:
--
We have NO MORE setDefaultCollection usage in the te
Kevin Risden created SOLR-16716:
---
Summary: Convert commons-io to pure Java
Key: SOLR-16716
URL: https://issues.apache.org/jira/browse/SOLR-16716
Project: Solr
Issue Type: Task
Security Le
[
https://issues.apache.org/jira/browse/SOLR-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703799#comment-17703799
]
Kevin Risden commented on SOLR-16716:
-
PR https://github.com/apache/solr/pull/1478
>
[
https://issues.apache.org/jira/browse/SOLR-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16716:
Status: Patch Available (was: Open)
> Convert commons-io to pure Java
> --
[
https://issues.apache.org/jira/browse/SOLR-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16716:
Summary: Replace commons-io usages with pure Java (was: Convert commons-io
to pure Java)
> Replac
dsmiley commented on code in PR #1481:
URL: https://github.com/apache/solr/pull/1481#discussion_r1145419650
##
solr/core/src/java/org/apache/solr/search/CaffeineCache.java:
##
@@ -250,26 +249,35 @@ public V computeIfAbsent(K key, IOFunction mappingFuncti
return computeAsy
magibney commented on code in PR #1481:
URL: https://github.com/apache/solr/pull/1481#discussion_r1145441657
##
solr/core/src/java/org/apache/solr/search/CaffeineCache.java:
##
@@ -250,26 +249,35 @@ public V computeIfAbsent(K key, IOFunction mappingFuncti
return computeAs
HoustonPutman commented on PR #1273:
URL: https://github.com/apache/solr/pull/1273#issuecomment-1480308993
The nightly build works for me! Feel free to backport to branch_9_2!
And it would be great to get this spread across the rest of the guide as
well! (not volunteering you though 😉
noblepaul commented on PR #1440:
URL: https://github.com/apache/solr/pull/1440#issuecomment-1480379384
`TestRandomFlRTGCloud` is failing in this PR. @magibney Can you give me any
hint as to why it is failing ?
--
This is an automated message from the Apache Git Service.
To respon
dsmiley commented on code in PR #1478:
URL: https://github.com/apache/solr/pull/1478#discussion_r1145439820
##
solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java:
##
@@ -93,14 +93,14 @@ private Properties makeCoreProperties(
}
private void addCoreWithProps(Pr
janhoy opened a new pull request, #1483:
URL: https://github.com/apache/solr/pull/1483
https://issues.apache.org/jira/browse/SOLR-16714
Here is a python script that runs `git log` to find all `solrbot` commits
since last release.
--
This is an automated message from the Apache Git
janhoy commented on code in PR #1483:
URL: https://github.com/apache/solr/pull/1483#discussion_r114914
##
dev-tools/scripts/addDepsToChanges.py:
##
@@ -0,0 +1,139 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8 -*-
+# Licensed to the Apache Software Foundation (ASF) under on
janhoy commented on code in PR #1483:
URL: https://github.com/apache/solr/pull/1483#discussion_r1145557521
##
dev-tools/scripts/addDepsToChanges.py:
##
@@ -0,0 +1,139 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8 -*-
+# Licensed to the Apache Software Foundation (ASF) under on
dsmiley commented on code in PR #1482:
URL: https://github.com/apache/solr/pull/1482#discussion_r1145571433
##
solr/core/src/java/org/apache/solr/request/SimpleFacets.java:
##
@@ -595,7 +595,7 @@ private NamedList getTermCounts(String field,
Integer mincount, ParsedP
[
https://issues.apache.org/jira/browse/SOLR-16713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703831#comment-17703831
]
ASF subversion and git services commented on SOLR-16713:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-16713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16713:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Replace Guava usages with pure
[
https://issues.apache.org/jira/browse/SOLR-16713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16713:
Fix Version/s: 9.3
> Replace Guava usages with pure Java
>
>
magibney commented on PR #1440:
URL: https://github.com/apache/solr/pull/1440#issuecomment-1480492475
I can take a closer look tomorrow, but (esp. based on the fact that you
tagged me) I suspect this will be around handling of the "json" raw doc
transformer ... just have to figure out how t
risdenk commented on code in PR #1482:
URL: https://github.com/apache/solr/pull/1482#discussion_r1145629125
##
solr/core/src/java/org/apache/solr/request/SimpleFacets.java:
##
@@ -595,7 +595,7 @@ private NamedList getTermCounts(String field,
Integer mincount, ParsedP
[
https://issues.apache.org/jira/browse/SOLR-11685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703853#comment-17703853
]
David Smiley commented on SOLR-11685:
-
This issue was created as specific to
Collect
dsmiley opened a new pull request, #1484:
URL: https://github.com/apache/solr/pull/1484
https://issues.apache.org/jira/browse/SOLR-16693
RE infamous error: "ClusterState says we are the leader ... but locally we
don't think so." from DistributedZkUpdateProcessor.
As it happens,
risdenk commented on code in PR #1478:
URL: https://github.com/apache/solr/pull/1478#discussion_r1145640212
##
solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java:
##
@@ -93,14 +93,14 @@ private Properties makeCoreProperties(
}
private void addCoreWithProps(Pr
risdenk commented on code in PR #1478:
URL: https://github.com/apache/solr/pull/1478#discussion_r1145654825
##
solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java:
##
@@ -251,7 +251,7 @@ public void writeResults(ResultContext ctx, JavaBinCodec
codec
vinayakphegde opened a new pull request, #1485:
URL: https://github.com/apache/solr/pull/1485
use metric API instead of NodeStateProvider in SplitShardCmd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
[
https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703918#comment-17703918
]
Vinayak Hegde commented on SOLR-16507:
--
Sure [~dsmiley]
draft PR: https://github.co
65 matches
Mail list logo
