[GitHub] [solr] HoustonPutman commented on a diff in pull request #1361: SOLR-16660 Deprecate analytics component

2023-02-22 Thread via GitHub
HoustonPutman commented on code in PR #1361: URL: https://github.com/apache/solr/pull/1361#discussion_r1114042387 ## solr/solr-ref-guide/modules/query-guide/pages/analytics-mapping-functions.adoc: ## @@ -18,6 +18,8 @@ Mapping functions map values for each Solr Document or Red

[GitHub] [solr] janhoy merged pull request #1361: SOLR-16660 Deprecate analytics component

2023-02-22 Thread via GitHub
janhoy merged PR #1361: URL: https://github.com/apache/solr/pull/1361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-16660) Deprecate analytics component

2023-02-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692085#comment-17692085 ] ASF subversion and git services commented on SOLR-16660: Commit e

[jira] [Commented] (SOLR-16660) Deprecate analytics component

2023-02-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692087#comment-17692087 ] ASF subversion and git services commented on SOLR-16660: Commit 0

[jira] [Resolved] (SOLR-16660) Deprecate analytics component

2023-02-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16660. Fix Version/s: 9.2 Resolution: Fixed > Deprecate analytics component > -

[GitHub] [solr] janhoy merged pull request #1362: SOLR-15959 Deprecate loading of solr.xml from ZK

2023-02-22 Thread via GitHub
janhoy merged PR #1362: URL: https://github.com/apache/solr/pull/1362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-15959) Deprecate loading of solr.xml from ZK

2023-02-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692091#comment-17692091 ] ASF subversion and git services commented on SOLR-15959: Commit 5

[jira] [Commented] (SOLR-15959) Deprecate loading of solr.xml from ZK

2023-02-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692092#comment-17692092 ] ASF subversion and git services commented on SOLR-15959: Commit 1

[jira] [Resolved] (SOLR-15959) Deprecate loading of solr.xml from ZK

2023-02-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-15959. Fix Version/s: 9.2 Resolution: Fixed > Deprecate loading of solr.xml from ZK > -

[jira] [Created] (SOLR-16678) Collection API v2 CREATE does not handle user-defined properties

2023-02-22 Thread Julien Massiera (Jira)
Julien Massiera created SOLR-16678: -- Summary: Collection API v2 CREATE does not handle user-defined properties Key: SOLR-16678 URL: https://issues.apache.org/jira/browse/SOLR-16678 Project: Solr

[GitHub] [solr] janhoy merged pull request #1342: SOLR-16650, SOLR-16532: OTEL tracer additional tags

2023-02-22 Thread via GitHub
janhoy merged PR #1342: URL: https://github.com/apache/solr/pull/1342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-16650) OTEL tracer additional tags

2023-02-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692111#comment-17692111 ] ASF subversion and git services commented on SOLR-16650: Commit 7

[jira] [Commented] (SOLR-16532) New OpenTelemetry module with OTLP trace exporter

2023-02-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692112#comment-17692112 ] ASF subversion and git services commented on SOLR-16532: Commit 7

[jira] [Resolved] (SOLR-16650) OTEL tracer additional tags

2023-02-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16650. Fix Version/s: 9.2 Resolution: Fixed > OTEL tracer additional tags > ---

[jira] [Commented] (SOLR-16650) OTEL tracer additional tags

2023-02-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692113#comment-17692113 ] ASF subversion and git services commented on SOLR-16650: Commit 8

[jira] [Commented] (SOLR-16532) New OpenTelemetry module with OTLP trace exporter

2023-02-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692114#comment-17692114 ] ASF subversion and git services commented on SOLR-16532: Commit 8

[GitHub] [solr] HoustonPutman commented on pull request #1367: SOLR-16669: Fix default checkPeerName in Http2SolrClient

2023-02-22 Thread via GitHub
HoustonPutman commented on PR #1367: URL: https://github.com/apache/solr/pull/1367#issuecomment-1439796112 Ok @janhoy , checking the logs message. Main with #1366 included: ``` 2023-02-22 09:28:49.232 WARN (main) [] o.e.j.u.s.S.config Trusting all certificates configured fo

[jira] [Commented] (SOLR-13931) Decommission Analytics component/handler

2023-02-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-13931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692121#comment-17692121 ] Jan Høydahl commented on SOLR-13931: The module is now deprecated in 9.2 with a call

[jira] [Updated] (SOLR-16661) Remove analytics component in 10.0

2023-02-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16661: --- Fix Version/s: main (10.0) > Remove analytics component in 10.0 > --

[jira] [Updated] (SOLR-16661) Remove analytics component in 10.0

2023-02-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16661: --- Priority: Blocker (was: Major) > Remove analytics component in 10.0 > --

[GitHub] [solr] alessandrobenedetti commented on pull request #1260: SOLR-788: transfer mlt query for component right

2023-02-22 Thread via GitHub
alessandrobenedetti commented on PR #1260: URL: https://github.com/apache/solr/pull/1260#issuecomment-1439846587 Back in the days, in 2017 when I was not a committer yet, I did a massive refactor of the Lucene More Like This code (https://www.slideshare.net/SeaseLtd/how-the-lucene-more-like

[GitHub] [solr] janhoy opened a new pull request, #1375: Enable renovatebot for the project

2023-02-22 Thread via GitHub
janhoy opened a new pull request, #1375: URL: https://github.com/apache/solr/pull/1375 This PR adds automatic dependency housekeeping to the project through [Renovatebot](https://github.com/renovatebot/renovate), which is an alternative to dependabot. See [slack discussion here](https://th

[GitHub] [solr] janhoy commented on a diff in pull request #1375: Enable renovatebot for the project

2023-02-22 Thread via GitHub
janhoy commented on code in PR #1375: URL: https://github.com/apache/solr/pull/1375#discussion_r1114226413 ## .github/renovate.json: ## @@ -0,0 +1,30 @@ +{ + "$schema": "https://docs.renovatebot.com/renovate-schema.json";, + "dependencyDashboard": false, + "enabledManagers":

[GitHub] [solr] janhoy commented on pull request #1375: Enable renovatebot for the project

2023-02-22 Thread via GitHub
janhoy commented on PR #1375: URL: https://github.com/apache/solr/pull/1375#issuecomment-1439920945 As of now, the git author for the PRs will be `SolrBot `. I used an email address on my own downain, the same I used to create the github account. The git commit message could of course be a

[GitHub] [solr] cpoerschke commented on a diff in pull request #1234: SOLR-15981: Add logExcludedParamsList parameter to support specifying params not to log

2023-02-22 Thread via GitHub
cpoerschke commented on code in PR #1234: URL: https://github.com/apache/solr/pull/1234#discussion_r1114215511 ## solr/core/src/java/org/apache/solr/core/SolrCore.java: ## @@ -2902,35 +2902,43 @@ public static void preDecorateResponse(SolrQueryRequest req, SolrQueryResponse r

[GitHub] [solr] janhoy commented on pull request #1375: Enable renovatebot for the project

2023-02-22 Thread via GitHub
janhoy commented on PR #1375: URL: https://github.com/apache/solr/pull/1375#issuecomment-1439979338 > I remember there is a private svn repo per PMC, but could not find it. I found https://svn.apache.org/repos/private/pmc/lucene/ for Lucene, but there is no equivalent for Solr at htt

[GitHub] [solr] risdenk merged pull request #1363: SOLR-16664: TestCoordinatorRole fails docs is null

2023-02-22 Thread via GitHub
risdenk merged PR #1363: URL: https://github.com/apache/solr/pull/1363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-16664) TestCoordinatorRole fails docs is null

2023-02-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692213#comment-17692213 ] ASF subversion and git services commented on SOLR-16664: Commit 0

[jira] [Updated] (SOLR-16664) TestCoordinatorRole fails docs is null

2023-02-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16664: Assignee: Kevin Risden Resolution: Fixed Status: Resolved (was: Patch Available) I'm

[jira] [Commented] (SOLR-16664) TestCoordinatorRole fails docs is null

2023-02-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692217#comment-17692217 ] ASF subversion and git services commented on SOLR-16664: Commit b

[jira] [Updated] (SOLR-16664) TestCoordinatorRole fails docs is null

2023-02-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16664: Fix Version/s: main (10.0) 9.2 > TestCoordinatorRole fails docs is null > --

[GitHub] [solr] risdenk commented on pull request #1367: SOLR-16669: Fix default checkPeerName in Http2SolrClient

2023-02-22 Thread via GitHub
risdenk commented on PR #1367: URL: https://github.com/apache/solr/pull/1367#issuecomment-1440146823 Oooo thanks for digging @HoustonPutman agree that ``` sslContextFactory.setEndpointIdentificationAlgorithm( System.getProperty("solr.jetty.ssl.verifyClientHostName"));

[jira] [Created] (SOLR-16679) Fix solr.jetty.ssl.verifyClientHostName logging

2023-02-22 Thread Kevin Risden (Jira)
Kevin Risden created SOLR-16679: --- Summary: Fix solr.jetty.ssl.verifyClientHostName logging Key: SOLR-16679 URL: https://issues.apache.org/jira/browse/SOLR-16679 Project: Solr Issue Type: Task

[jira] [Updated] (SOLR-16669) Http2SolrClient defaults checkPeerName incorrectly

2023-02-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16669: Status: Patch Available (was: Open) > Http2SolrClient defaults checkPeerName incorrectly > ---

[GitHub] [solr] risdenk opened a new pull request, #1376: SOLR-16679: Fix solr.jetty.ssl.verifyClientHostName logging

2023-02-22 Thread via GitHub
risdenk opened a new pull request, #1376: URL: https://github.com/apache/solr/pull/1376 https://issues.apache.org/jira/browse/SOLR-16679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Updated] (SOLR-16679) Fix solr.jetty.ssl.verifyClientHostName logging

2023-02-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16679: Status: Patch Available (was: Open) > Fix solr.jetty.ssl.verifyClientHostName logging > --

[jira] [Assigned] (SOLR-16664) TestCoordinatorRole fails docs is null

2023-02-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-16664: --- Assignee: (was: Kevin Risden) > TestCoordinatorRole fails docs is null > ---

[jira] [Reopened] (SOLR-16664) TestCoordinatorRole fails docs is null

2023-02-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reopened SOLR-16664: - Here is a failure with the new logging: {code:java} 2> 465235 INFO (TEST-TestCoordinatorRole.tes

[jira] [Comment Edited] (SOLR-16664) TestCoordinatorRole fails docs is null

2023-02-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692236#comment-17692236 ] Kevin Risden edited comment on SOLR-16664 at 2/22/23 3:17 PM: -

[jira] [Commented] (SOLR-16664) TestCoordinatorRole fails docs is null

2023-02-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692239#comment-17692239 ] Kevin Risden commented on SOLR-16664: - I went back to recent Jenkins failures to see

[jira] [Commented] (SOLR-16664) TestCoordinatorRole fails docs is null

2023-02-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692246#comment-17692246 ] Kevin Risden commented on SOLR-16664: - It looks like the failure parsing the message

[jira] [Commented] (SOLR-15493) Feature extraction for learning to rank not arising any error if the feature store doesn't exists

2023-02-22 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692257#comment-17692257 ] Alessandro Benedetti commented on SOLR-15493: - We are finalising a draft pull

[GitHub] [solr] cpoerschke commented on a diff in pull request #937: SOLR-16289: Null check in transformers of ltr module

2023-02-22 Thread via GitHub
cpoerschke commented on code in PR #937: URL: https://github.com/apache/solr/pull/937#discussion_r1114576195 ## solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java: ## @@ -362,9 +363,13 @@ private void implTransform(SolrDocume

[GitHub] [solr] cpoerschke commented on a diff in pull request #937: SOLR-16289: Null check in transformers of ltr module

2023-02-22 Thread via GitHub
cpoerschke commented on code in PR #937: URL: https://github.com/apache/solr/pull/937#discussion_r1114582258 ## solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java: ## @@ -362,9 +363,13 @@ private void implTransform(SolrDocume

[GitHub] [solr] gerlowskija commented on pull request #1224: [SOLR-16490] Create a v2 equivalent for /admin/cores BACKUPCORE+RESTORECORE

2023-02-22 Thread via GitHub
gerlowskija commented on PR #1224: URL: https://github.com/apache/solr/pull/1224#issuecomment-1440345064 Hi @iamsanjay , sorry for the delay in getting to this. I've been mostly attending to a blocker for the JAX-RS and v2 API work, SOLR-16531. But with that recently cleared away I'm turn

[GitHub] [solr] cpoerschke commented on a diff in pull request #937: SOLR-16289: Null check in transformers of ltr module

2023-02-22 Thread via GitHub
cpoerschke commented on code in PR #937: URL: https://github.com/apache/solr/pull/937#discussion_r1114585921 ## solr/modules/ltr/src/java/org/apache/solr/ltr/interleaving/LTRInterleavingScoringQuery.java: ## @@ -25,7 +26,7 @@ public class LTRInterleavingScoringQuery extends LTR

[GitHub] [solr] janhoy commented on pull request #1375: Enable renovatebot for the project

2023-02-22 Thread via GitHub
janhoy commented on PR #1375: URL: https://github.com/apache/solr/pull/1375#issuecomment-1440398151 > I can file an INFRA ticket to create a private `solr-pmc` git repo, PMC only, where we can share secrets We now got a private repo `solr-private`, and Infra suggests storing encrypte

[GitHub] [solr-operator] coolstim opened a new issue, #526: Update the default solr.xml to include maxBooleanClauses

2023-02-22 Thread via GitHub
coolstim opened a new issue, #526: URL: https://github.com/apache/solr-operator/issues/526 The default solr.xml does not contain a default entry for maxBooleanClauses. This prevents the value to be set via javaOpts and forces uses to implement a custom config map with a custom solr.xml;

[GitHub] [solr] alessandrobenedetti commented on pull request #937: SOLR-16289: Null check in transformers of ltr module

2023-02-22 Thread via GitHub
alessandrobenedetti commented on PR #937: URL: https://github.com/apache/solr/pull/937#issuecomment-1440410507 My bad, it seems this information is not in the documentation (I may have just put it in the original blog post telling the story of the contribution). If these changes don't mak

[GitHub] [solr] dsmiley commented on pull request #1374: SOLR-16623:SolrClientTestRule for JettySolrRunnerV2

2023-02-22 Thread via GitHub
dsmiley commented on PR #1374: URL: https://github.com/apache/solr/pull/1374#issuecomment-1440449203 FYI Eric/others this is a re-do PR to reduce the scope of change to JettySolrTestBase & subclasses. Too much work to fix/improve them in greater detail. From our online review today:

[GitHub] [solr] gerlowskija commented on a diff in pull request #1224: [SOLR-16490] Create a v2 equivalent for /admin/cores BACKUPCORE+RESTORECORE

2023-02-22 Thread via GitHub
gerlowskija commented on code in PR #1224: URL: https://github.com/apache/solr/pull/1224#discussion_r1114647260 ## solr/core/src/java/org/apache/solr/handler/admin/api/BackupCoreAPI.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [solr] epugh commented on pull request #1374: SOLR-16623:SolrClientTestRule for JettySolrRunnerV2

2023-02-22 Thread via GitHub
epugh commented on PR #1374: URL: https://github.com/apache/solr/pull/1374#issuecomment-1440473853 Thanks for sharing the summary from the review... I think you answered some questions I had! Really looking forward to seeing this land ;-). -- This is an automated message from the Ap

[GitHub] [solr] gerlowskija commented on pull request #1160: SOLR-16458: Implement GET allLevels endpoint

2023-02-22 Thread via GitHub
gerlowskija commented on PR #1160: URL: https://github.com/apache/solr/pull/1160#issuecomment-1440488697 My schedule is a little inflexible at this point to set up anything formal, but I'm more than happy to help out as I can! Do you have particular questions about this PR, or APIs in Solr

[jira] [Commented] (SOLR-16664) TestCoordinatorRole fails docs is null

2023-02-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692300#comment-17692300 ] Kevin Risden commented on SOLR-16664: - I was able to capture a failure in IDE debugg

[jira] [Commented] (SOLR-16664) TestCoordinatorRole fails docs is null

2023-02-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692301#comment-17692301 ] Kevin Risden commented on SOLR-16664: - Well this is definitely where the message bein

[jira] (SOLR-16664) TestCoordinatorRole fails docs is null

2023-02-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16664 ] Kevin Risden deleted comment on SOLR-16664: - was (Author: risdenk): I was able to capture a failure in IDE debugger and the message that can't be decoded was: {code:java} Error 404 Can

[jira] (SOLR-16664) TestCoordinatorRole fails docs is null

2023-02-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16664 ] Kevin Risden deleted comment on SOLR-16664: - was (Author: risdenk): Well this is definitely where the message being generated before trying to process it with javabin... https://github.com/a

[GitHub] [solr] dsmiley commented on a diff in pull request #1375: Enable renovatebot for the project

2023-02-22 Thread via GitHub
dsmiley commented on code in PR #1375: URL: https://github.com/apache/solr/pull/1375#discussion_r1114753773 ## .github/renovate.json: ## @@ -0,0 +1,30 @@ +{ + "$schema": "https://docs.renovatebot.com/renovate-schema.json";, + "dependencyDashboard": false, + "enabledManagers":

[GitHub] [solr] joshgog commented on a diff in pull request #1374: SOLR-16623:SolrClientTestRule for JettySolrRunnerV2

2023-02-22 Thread via GitHub
joshgog commented on code in PR #1374: URL: https://github.com/apache/solr/pull/1374#discussion_r1114780615 ## solr/test-framework/src/java/org/apache/solr/util/SolrJettyTestRule.java: ## @@ -52,13 +53,18 @@ protected void after() { try { jetty.stop(); } c

[GitHub] [solr] joshgog commented on a diff in pull request #1374: SOLR-16623:SolrClientTestRule for JettySolrRunnerV2

2023-02-22 Thread via GitHub
joshgog commented on code in PR #1374: URL: https://github.com/apache/solr/pull/1374#discussion_r1114796900 ## solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java: ## @@ -136,7 +136,7 @@ public synchronized SolrClient getSolrClient() { * options. */ pu

[jira] [Created] (SOLR-16680) Add JMH benchmark for Solr Startup

2023-02-22 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-16680: -- Summary: Add JMH benchmark for Solr Startup Key: SOLR-16680 URL: https://issues.apache.org/jira/browse/SOLR-16680 Project: Solr Issue Type: Improvement

[GitHub] [solr] justinrsweeney commented on pull request #1348: Adding support for compression within the ZkCLI tool

2023-02-22 Thread via GitHub
justinrsweeney commented on PR #1348: URL: https://github.com/apache/solr/pull/1348#issuecomment-1440676642 > This looks like it does the job. However, I was sort of thinking that compression would be more of a wrapper around the underlying data structure? Kind of like a `ZipInputStream` mi

[GitHub] [solr] gerlowskija opened a new pull request, #1377: SOLR-16680: Add JMH benchmark for Solr startup

2023-02-22 Thread via GitHub
gerlowskija opened a new pull request, #1377: URL: https://github.com/apache/solr/pull/1377 https://issues.apache.org/jira/browse/SOLR-16680 # Description Solr has a benchmarking module built around an integration with JMH. But it doesn't have a ton of benchmarks to run quite

[GitHub] [solr] risdenk commented on a diff in pull request #1377: SOLR-16680: Add JMH benchmark for Solr startup

2023-02-22 Thread via GitHub
risdenk commented on code in PR #1377: URL: https://github.com/apache/solr/pull/1377#discussion_r1114861555 ## solr/benchmark/src/java/org/apache/solr/bench/lifecycle/SolrStartup.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [solr] gerlowskija commented on a diff in pull request #1377: SOLR-16680: Add JMH benchmark for Solr startup

2023-02-22 Thread via GitHub
gerlowskija commented on code in PR #1377: URL: https://github.com/apache/solr/pull/1377#discussion_r1114897492 ## solr/benchmark/src/java/org/apache/solr/bench/lifecycle/SolrStartup.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [solr] risdenk commented on a diff in pull request #1377: SOLR-16680: Add JMH benchmark for Solr startup

2023-02-22 Thread via GitHub
risdenk commented on code in PR #1377: URL: https://github.com/apache/solr/pull/1377#discussion_r1114900274 ## solr/benchmark/src/java/org/apache/solr/bench/lifecycle/SolrStartup.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [solr] gerlowskija commented on pull request #1377: SOLR-16680: Add JMH benchmark for Solr startup

2023-02-22 Thread via GitHub
gerlowskija commented on PR #1377: URL: https://github.com/apache/solr/pull/1377#issuecomment-1440732740 FYI @noblepaul , I know you'd expressed interest in this following the last virtual meetup. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [solr] risdenk commented on a diff in pull request #1377: SOLR-16680: Add JMH benchmark for Solr startup

2023-02-22 Thread via GitHub
risdenk commented on code in PR #1377: URL: https://github.com/apache/solr/pull/1377#discussion_r1114901342 ## solr/benchmark/src/java/org/apache/solr/bench/lifecycle/SolrStartup.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[jira] [Comment Edited] (SOLR-16488) Migrate ZookeeperReadAPI to JAX-RS

2023-02-22 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689195#comment-17689195 ] Jason Gerlowski edited comment on SOLR-16488 at 2/22/23 9:07 PM: --

[GitHub] [solr] janhoy commented on a diff in pull request #1375: Enable renovatebot for the project

2023-02-22 Thread via GitHub
janhoy commented on code in PR #1375: URL: https://github.com/apache/solr/pull/1375#discussion_r1114973119 ## .github/renovate.json: ## @@ -0,0 +1,30 @@ +{ + "$schema": "https://docs.renovatebot.com/renovate-schema.json";, + "dependencyDashboard": false, + "enabledManagers":

[GitHub] [solr] chatman commented on pull request #1375: Enable renovatebot for the project

2023-02-22 Thread via GitHub
chatman commented on PR #1375: URL: https://github.com/apache/solr/pull/1375#issuecomment-1440972336 > I changed teh commit email to SolrBot , see [renovate config](https://github.com/solrbot/renovate-github-action/blob/main/solr/renovate-config.js). Who controls that email address?

[GitHub] [solr] chatman commented on a diff in pull request #1375: Enable renovatebot for the project

2023-02-22 Thread via GitHub
chatman commented on code in PR #1375: URL: https://github.com/apache/solr/pull/1375#discussion_r1115092683 ## .github/renovate.json: ## @@ -0,0 +1,33 @@ +{ Review Comment: Does this file need to be in solr repository for the entire integration to work? Can't it be added to

[GitHub] [solr] chatman commented on a diff in pull request #1375: Enable renovatebot for the project

2023-02-22 Thread via GitHub
chatman commented on code in PR #1375: URL: https://github.com/apache/solr/pull/1375#discussion_r1115092683 ## .github/renovate.json: ## @@ -0,0 +1,33 @@ +{ Review Comment: Does this file need to be in solr repository for the entire integration to work? Can't it be added to

[jira] [Commented] (SOLR-16664) TestCoordinatorRole fails docs is null

2023-02-22 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692421#comment-17692421 ] Noble Paul commented on SOLR-16664: --- lemme investigate > TestCoordinatorRole fails doc

[jira] [Commented] (SOLR-16556) Solr stream expression: Implement Page Streaming Decorator to allow results to be displayed with pagination.

2023-02-22 Thread Maulin (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692422#comment-17692422 ] Maulin commented on SOLR-16556: --- Hi [~epugh]  Sorry for late reply..  I am working on your

[GitHub] [solr] dsmiley commented on a diff in pull request #1375: Enable renovatebot for the project

2023-02-22 Thread via GitHub
dsmiley commented on code in PR #1375: URL: https://github.com/apache/solr/pull/1375#discussion_r1115164201 ## .github/renovate.json: ## @@ -0,0 +1,33 @@ +{ Review Comment: If it can live elsewhere easily then cool. But I think it's inclusion isn't a blocker either. I bel

[jira] [Commented] (SOLR-16676) Http2SolrClient loss of MDC context

2023-02-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692443#comment-17692443 ] David Smiley commented on SOLR-16676: - I'd be happy to review! > Http2SolrClient los