cpoerschke commented on code in PR #1324:
URL: https://github.com/apache/solr/pull/1324#discussion_r680488
##
solr/core/src/java/org/apache/solr/search/ReRankOperator.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * con
janhoy commented on PR #1371:
URL: https://github.com/apache/solr/pull/1371#issuecomment-1436859444
> LGTM.. canEditCollection() maybe?
Yea, just tried to get a shorter version of
`isPermitted(permissions.COLL_EDIT_PERM)`, but perhaps it is just as good to
spell the permission out in
chatman commented on PR #1371:
URL: https://github.com/apache/solr/pull/1371#issuecomment-1436869396
It might be confusing as to why everything is disabled. How about changing
the mouse cursor to not allowed one on hover?
https://www.w3schools.com/cssref/pr_class_cursor.php
--
This is an
mkhludnev commented on code in PR #1260:
URL: https://github.com/apache/solr/pull/1260#discussion_r871573
##
solr/core/src/java/org/apache/solr/handler/component/MoreLikeThisComponent.java:
##
@@ -127,6 +128,53 @@ public void process(ResponseBuilder rb) throws IOException
{
epugh commented on PR #1372:
URL: https://github.com/apache/solr/pull/1372#issuecomment-1436915316
This turns out to not be an unused config, but instead appears to be used
inside of healthcheck, but sort of deeply nested. By moving to an explicit
collection parameter, it removes a bit of
mkhludnev commented on PR #1324:
URL: https://github.com/apache/solr/pull/1324#issuecomment-1436951521
> > ok. @andywebb1975 I noticed your contributor label! Can you squash-merge
it on your own?
>
> Sure, have just squashed it. I'm just a contributor - don't have committer
rights, i
janhoy commented on PR #1371:
URL: https://github.com/apache/solr/pull/1371#issuecomment-1437043479
> It might be confusing as to why everything is disabled. How about changing
the mouse cursor to not allowed one on hover?
https://www.w3schools.com/cssref/pr_class_cursor.php
That's e
risdenk commented on code in PR #1363:
URL: https://github.com/apache/solr/pull/1363#discussion_r1112218270
##
solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java:
##
@@ -389,6 +390,7 @@ private String getHostCoreName(
SolrQuery q = new SolrQuery("*:*");
magibney commented on PR #1351:
URL: https://github.com/apache/solr/pull/1351#issuecomment-1437385040
It just depends on what one considers "the feature" to be. Option 1
considers the feature to be "standard hooks to support the implementation of
pluggable node-level caches". That's no smal
[
https://issues.apache.org/jira/browse/SOLR-13942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691284#comment-17691284
]
Jason Gerlowski commented on SOLR-13942:
The scarcity of JS familiarity in the co
[
https://issues.apache.org/jira/browse/SOLR-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh updated SOLR-16672:
-
Description: While looking at SOLR-10466, discovered a setDefaultCollection
that isn't needed in SolrCLI.
[
https://issues.apache.org/jira/browse/SOLR-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh updated SOLR-16672:
-
Summary: Remove use of setDefaultCollection in SolrCLI (was: Unused
setDefaultCollection in SolrCLI)
>
Cesar Delgado created SOLR-16673:
Summary: Strange error when using Schema Designer
Key: SOLR-16673
URL: https://issues.apache.org/jira/browse/SOLR-16673
Project: Solr
Issue Type: Bug
S
noblepaul commented on code in PR #1363:
URL: https://github.com/apache/solr/pull/1363#discussion_r1112485860
##
solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java:
##
@@ -389,6 +390,7 @@ private String getHostCoreName(
SolrQuery q = new SolrQuery("*:*");
[
https://issues.apache.org/jira/browse/SOLR-13942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691356#comment-17691356
]
Ishan Chattopadhyaya commented on SOLR-13942:
-
bq. Which is the sad story of
[
https://issues.apache.org/jira/browse/SOLR-13942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691357#comment-17691357
]
Ishan Chattopadhyaya commented on SOLR-13942:
-
bq. what do you mean by "non-s
noblepaul commented on code in PR #1363:
URL: https://github.com/apache/solr/pull/1363#discussion_r1112485860
##
solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java:
##
@@ -389,6 +390,7 @@ private String getHostCoreName(
SolrQuery q = new SolrQuery("*:*");
[
https://issues.apache.org/jira/browse/SOLR-16636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691371#comment-17691371
]
ASF subversion and git services commented on SOLR-16636:
Commit 2
[
https://issues.apache.org/jira/browse/SOLR-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691375#comment-17691375
]
ASF subversion and git services commented on SOLR-16573:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-16636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691386#comment-17691386
]
ASF subversion and git services commented on SOLR-16636:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-16595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691378#comment-17691378
]
ASF subversion and git services commented on SOLR-16595:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-16639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691377#comment-17691377
]
ASF subversion and git services commented on SOLR-16639:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691382#comment-17691382
]
ASF subversion and git services commented on SOLR-16665:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-16593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691385#comment-17691385
]
ASF subversion and git services commented on SOLR-16593:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691381#comment-17691381
]
ASF subversion and git services commented on SOLR-15733:
Commit 2
[
https://issues.apache.org/jira/browse/SOLR-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691370#comment-17691370
]
ASF subversion and git services commented on SOLR-16648:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691373#comment-17691373
]
ASF subversion and git services commented on SOLR-16457:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-16671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691384#comment-17691384
]
ASF subversion and git services commented on SOLR-16671:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-16658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691379#comment-17691379
]
ASF subversion and git services commented on SOLR-16658:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-9698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691380#comment-17691380
]
ASF subversion and git services commented on SOLR-9698:
---
Commit 84b5
[
https://issues.apache.org/jira/browse/SOLR-16628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691372#comment-17691372
]
ASF subversion and git services commented on SOLR-16628:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691376#comment-17691376
]
ASF subversion and git services commented on SOLR-16573:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691374#comment-17691374
]
ASF subversion and git services commented on SOLR-16573:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691383#comment-17691383
]
ASF subversion and git services commented on SOLR-15733:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-16659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691394#comment-17691394
]
def onion commented on SOLR-16659:
--
[~ichattopadhyaya] Thanks! i'll give it a try.
> Di
HoustonPutman commented on code in PR #1363:
URL: https://github.com/apache/solr/pull/1363#discussion_r1112612047
##
solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java:
##
@@ -389,6 +390,7 @@ private String getHostCoreName(
SolrQuery q = new SolrQuery("*:*")
[ https://issues.apache.org/jira/browse/SOLR-16593 ]
Noble Paul deleted comment on SOLR-16593:
---
was (Author: jira-bot):
Commit ad5a4e8c286d2461e4cab11a59e6265c132211c6 in solr's branch
refs/heads/jira/SOLR-16636_revert from Noble Paul
[ https://g
[ https://issues.apache.org/jira/browse/SOLR-16636 ]
Noble Paul deleted comment on SOLR-16636:
---
was (Author: jira-bot):
Commit 0b3199684de912ea4162f8510fc19c1f1b7e0985 in solr's branch
refs/heads/jira/SOLR-16636_revert from Noble Paul
[ https://g
[ https://issues.apache.org/jira/browse/SOLR-16636 ]
Noble Paul deleted comment on SOLR-16636:
---
was (Author: jira-bot):
Commit 2bc3df65a5857f6915fd09f040e4f70eaf846980 in solr's branch
refs/heads/jira/SOLR-16636_revert from Noble Paul
[ https://g
[
https://issues.apache.org/jira/browse/SOLR-16636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691411#comment-17691411
]
Ishan Chattopadhyaya commented on SOLR-16636:
-
[~noble.paul], the revert bran
[ https://issues.apache.org/jira/browse/SOLR-16671 ]
Noble Paul deleted comment on SOLR-16671:
---
was (Author: jira-bot):
Commit d8dbca65ca809fe9a045a1a9f086a6e8b0271e68 in solr's branch
refs/heads/jira/SOLR-16636_revert from Houston Putman
[ https
[ https://issues.apache.org/jira/browse/SOLR-16665 ]
Noble Paul deleted comment on SOLR-16665:
---
was (Author: jira-bot):
Commit 43d757371d3599ca544d8478c501c02babd79b25 in solr's branch
refs/heads/jira/SOLR-16636_revert from Houston Putman
[ https
[ https://issues.apache.org/jira/browse/SOLR-16595 ]
Noble Paul deleted comment on SOLR-16595:
---
was (Author: jira-bot):
Commit f40b35c3d9ff7e6f4dd314d8fce64ceee2604952 in solr's branch
refs/heads/jira/SOLR-16636_revert from Eric Pugh
[ https://gi
[
https://issues.apache.org/jira/browse/SOLR-16673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691421#comment-17691421
]
Houston Putman commented on SOLR-16673:
---
So I am currently playing a bit of wack-a-
44 matches
Mail list logo
