[GitHub] [solr] epugh commented on a diff in pull request #1371: SOLR-15928 Dim add collection buttons in Admin UI when no permission

2023-02-18 Thread via GitHub
epugh commented on code in PR #1371: URL: https://github.com/apache/solr/pull/1371#discussion_r012558 ## solr/webapp/web/partials/collections.html: ## @@ -84,7 +84,9 @@ - Add Collection + Review Comment: the `{ }` syntax is new to

[GitHub] [solr] epugh commented on a diff in pull request #1371: SOLR-15928 Dim add collection buttons in Admin UI when no permission

2023-02-18 Thread via GitHub
epugh commented on code in PR #1371: URL: https://github.com/apache/solr/pull/1371#discussion_r013066 ## solr/webapp/web/partials/collections.html: ## @@ -122,8 +124,8 @@ - Delete collection - Delete alias + Delete collection + Delete alias Re

[GitHub] [solr] epugh commented on pull request #1336: what happens if we remove SSL annotation?

2023-02-18 Thread via GitHub
epugh commented on PR #1336: URL: https://github.com/apache/solr/pull/1336#issuecomment-1435670947 I noticed that we think that SSL Annotation support should be working again And that if Crave works well, then it's easy to test if removing the annotation doesn't change that all the te

[GitHub] [solr] Jdurham2843 commented on pull request #1126: SOLR-16462: Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

2023-02-18 Thread via GitHub
Jdurham2843 commented on PR #1126: URL: https://github.com/apache/solr/pull/1126#issuecomment-1435794483 From what I can tell, the injection exception isn't making it into any logs. Instead its being spat out into the terminal where I ran the solr start command. I'm only seeing this error w

[GitHub] [solr] dsmiley commented on pull request #760: SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions

2023-02-18 Thread via GitHub
dsmiley commented on PR #760: URL: https://github.com/apache/solr/pull/760#issuecomment-1435796671 I propose we make the loss of the reconnect boolean its own PR, plus the methods that shielded use of ZkCmdExecutor. That will make this effort here more independently reviewable and would be