[GitHub] [solr] mkhludnev commented on pull request #1274: SOLR-16611: fix collapse hint=top_fc bug

2023-01-08 Thread GitBox
mkhludnev commented on PR #1274: URL: https://github.com/apache/solr/pull/1274#issuecomment-1374786401 Hi, @metapox I run tests myself. Failures seem unrelated to the change. Please confirm I put your name correctly in CHANGES. I'll merge then. -- This is an automated message from the

[GitHub] [solr] metapox commented on pull request #1274: SOLR-16611: fix collapse hint=top_fc bug

2023-01-08 Thread GitBox
metapox commented on PR #1274: URL: https://github.com/apache/solr/pull/1274#issuecomment-1374826848 @mkhludnev Hi, @mkhludnev My name you put in CHANGES is correct. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

2023-01-08 Thread GitBox
risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1064168669 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -250,7 +251,7 @@ public FileVisitResult visitFile(Path file, BasicFileAttributes attrs)

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

2023-01-08 Thread GitBox
risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1064168704 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -259,6 +260,14 @@ public FileVisitResult postVisitDirectory(Path dir, IOException ioExce

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

2023-01-08 Thread GitBox
risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1064168758 ## solr/core/src/test/org/apache/solr/core/TestConfigSetService.java: ## @@ -77,24 +72,31 @@ public void testConfigSetServiceOperations() throws IOException { byte[]

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

2023-01-08 Thread GitBox
risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1064168782 ## solr/core/src/test/org/apache/solr/core/TestConfigSetService.java: ## @@ -108,16 +110,14 @@ public void testConfigSetServiceOperations() throws IOException { ass

[GitHub] [solr] mkhludnev merged pull request #1274: SOLR-16611: fix collapse hint=top_fc bug

2023-01-08 Thread GitBox
mkhludnev merged PR #1274: URL: https://github.com/apache/solr/pull/1274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-16611) When there are no segments, using hint=top_fc in collapse results in NPE.

2023-01-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655810#comment-17655810 ] ASF subversion and git services commented on SOLR-16611: Commit 0

[GitHub] [solr] mkhludnev opened a new pull request, #1280: SOLR-16611: fix collapse hint=top_fc bug (#1274)

2023-01-08 Thread GitBox
mkhludnev opened a new pull request, #1280: URL: https://github.com/apache/solr/pull/1280 * fixed collapse top_fc getSorted Co-authored-by: Mikhail Khludnev https://issues.apache.org/jira/browse/SOLR-16611 cc @metapox , fyi -- This is an automated message from the Apa

[GitHub] [solr] mkhludnev merged pull request #1280: SOLR-16611: fix collapse hint=top_fc bug (#1274)

2023-01-08 Thread GitBox
mkhludnev merged PR #1280: URL: https://github.com/apache/solr/pull/1280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-16611) When there are no segments, using hint=top_fc in collapse results in NPE.

2023-01-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655815#comment-17655815 ] ASF subversion and git services commented on SOLR-16611: Commit 9

[jira] [Commented] (SOLR-16532) New OpenTelemetry module with OTLP trace exporter

2023-01-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655841#comment-17655841 ] Mikhail Khludnev commented on SOLR-16532: - Hello, Jan. May I ask you if https:

[jira] [Commented] (SOLR-16532) New OpenTelemetry module with OTLP trace exporter

2023-01-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655850#comment-17655850 ] Jan Høydahl commented on SOLR-16532: Yes, had the same thread leak locally at first,

[jira] [Commented] (SOLR-6312) CloudSolrServer doesn't honor updatesToLeaders constructor argument

2023-01-08 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655860#comment-17655860 ] Eric Pugh commented on SOLR-6312: - Thanks for pushing this up...It looks like it makes

[jira] [Commented] (SOLR-16532) New OpenTelemetry module with OTLP trace exporter

2023-01-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655876#comment-17655876 ] David Smiley commented on SOLR-16532: - I like OTEL_TRACES_EXPORTER=logging best. Are

[GitHub] [solr] noblepaul merged pull request #1276: A transformer that appends the core name

2023-01-08 Thread GitBox
noblepaul merged PR #1276: URL: https://github.com/apache/solr/pull/1276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-16557) Solr 9.0.0 - Not able to install 3rd party DIH plugin

2023-01-08 Thread Rajesh Kumar C (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655908#comment-17655908 ] Rajesh Kumar C commented on SOLR-16557: --- Hi Team, It's been more than a month, but

[GitHub] [solr] noblepaul commented on pull request #1267: SOLR-16608: Ability to compress the collection state

2023-01-08 Thread GitBox
noblepaul commented on PR #1267: URL: https://github.com/apache/solr/pull/1267#issuecomment-1375118428 > This would be a pretty scary feature to use for me.. It's an opt-in feature. So, a user would not get an unpleasant surprise -- This is an automated message from the Apache Git

[GitHub] [solr] dsmiley commented on a diff in pull request #1218: SOLR-16573:SolrClientTestRule for EmbeddedSolrServer

2023-01-08 Thread GitBox
dsmiley commented on code in PR #1218: URL: https://github.com/apache/solr/pull/1218#discussion_r1064307372 ## solr/solrj/src/test/org/apache/solr/client/solrj/request/TestCoreAdmin.java: ## @@ -46,20 +51,73 @@ import org.apache.solr.core.SolrCore; import org.apache.solr.metri

[jira] [Resolved] (SOLR-16611) When there are no segments, using hint=top_fc in collapse results in NPE.

2023-01-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev resolved SOLR-16611. - Assignee: Mikhail Khludnev Resolution: Fixed > When there are no segments, using hi

[jira] [Updated] (SOLR-16611) When there are no segments, using hint=top_fc in collapse results in NPE.

2023-01-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-16611: Fix Version/s: 9.2 > When there are no segments, using hint=top_fc in collapse results in N

[jira] [Commented] (SOLR-16611) When there are no segments, using hint=top_fc in collapse results in NPE.

2023-01-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655927#comment-17655927 ] Mikhail Khludnev commented on SOLR-16611: - [~taku], thank you! > When there are