[GitHub] [solr-operator] johgoe commented on pull request #453: Add app-protocol for all services

2022-07-06 Thread GitBox
johgoe commented on PR #453: URL: https://github.com/apache/solr-operator/pull/453#issuecomment-1175933340 lgfm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [solr] epugh commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type

2022-07-06 Thread GitBox
epugh commented on PR #753: URL: https://github.com/apache/solr/pull/753#issuecomment-1176127063 I like how you nested the drop down inside of it! checking it out todya! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (SOLR-16221) Solr Jenkins CI - s390x support

2022-07-06 Thread Nayana Thorat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563199#comment-17563199 ] Nayana Thorat commented on SOLR-16221: -- [~uschindler] Thank you. Please letme know o

[GitHub] [solr] epugh commented on a diff in pull request #929: SOLR-16280: simplify for-loops in tests

2022-07-06 Thread GitBox
epugh commented on code in PR #929: URL: https://github.com/apache/solr/pull/929#discussion_r914776978 ## solr/core/src/test/org/apache/solr/update/processor/SignatureUpdateProcessorFactoryTest.java: ## @@ -179,20 +179,20 @@ public void run() { threads2[i].setName("testTh

[GitHub] [solr] epugh commented on pull request #929: SOLR-16280: simplify for-loops in tests

2022-07-06 Thread GitBox
epugh commented on PR #929: URL: https://github.com/apache/solr/pull/929#issuecomment-1176164427 @cpoerschke based on the changes, do you think this is ready? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (SOLR-15781) Cosmetic and consistency improvements to v2 API

2022-07-06 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563238#comment-17563238 ] Jason Gerlowski commented on SOLR-15781: Following some preliminary discussion on

[jira] [Commented] (SOLR-16245) Make DenseVectorField codec agnostic

2022-07-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563240#comment-17563240 ] ASF subversion and git services commented on SOLR-16245: Commit f

[GitHub] [solr] gerlowskija commented on a diff in pull request #932: SOLR-15182: Remove remaining apispec files

2022-07-06 Thread GitBox
gerlowskija commented on code in PR #932: URL: https://github.com/apache/solr/pull/932#discussion_r914874464 ## solr/core/src/test/org/apache/solr/handler/admin/V2ApiMappingTest.java: ## @@ -204,11 +204,12 @@ public String getHttpMethod() { return queryRequestCaptor.getValu

[GitHub] [solr] gerlowskija commented on a diff in pull request #932: SOLR-15182: Remove remaining apispec files

2022-07-06 Thread GitBox
gerlowskija commented on code in PR #932: URL: https://github.com/apache/solr/pull/932#discussion_r914878254 ## solr/core/src/java/org/apache/solr/api/ApiBag.java: ## @@ -17,37 +17,14 @@ package org.apache.solr.api; -import static org.apache.solr.client.solrj.SolrRequest.SU

[GitHub] [solr] alessandrobenedetti merged pull request #910: SOLR-16245: make DenseVectorField codec agnostic

2022-07-06 Thread GitBox
alessandrobenedetti merged PR #910: URL: https://github.com/apache/solr/pull/910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr

[GitHub] [solr] gerlowskija commented on a diff in pull request #932: SOLR-15182: Remove remaining apispec files

2022-07-06 Thread GitBox
gerlowskija commented on code in PR #932: URL: https://github.com/apache/solr/pull/932#discussion_r914883795 ## solr/core/src/java/org/apache/solr/handler/BlobHandler.java: ## @@ -22,6 +22,7 @@ import static org.apache.solr.common.params.CommonParams.SORT; import static org.ap

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #904: SOLR-16246: Introduced pre-filtering in KnnQParser

2022-07-06 Thread GitBox
alessandrobenedetti commented on code in PR #904: URL: https://github.com/apache/solr/pull/904#discussion_r914902058 ## solr/core/src/java/org/apache/solr/search/QueryUtils.java: ## @@ -215,4 +221,38 @@ public static Query combineQueryAndFilter(Query scoreQuery, Query filterQue

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #904: SOLR-16246: Introduced pre-filtering in KnnQParser

2022-07-06 Thread GitBox
alessandrobenedetti commented on code in PR #904: URL: https://github.com/apache/solr/pull/904#discussion_r914906892 ## solr/core/src/java/org/apache/solr/search/neural/KnnQParser.java: ## @@ -72,7 +78,41 @@ public Query parse() { DenseVectorField denseVectorType = (Dense

[GitHub] [solr] cpoerschke commented on a diff in pull request #929: SOLR-16280: simplify for-loops in tests

2022-07-06 Thread GitBox
cpoerschke commented on code in PR #929: URL: https://github.com/apache/solr/pull/929#discussion_r914909077 ## solr/core/src/test/org/apache/solr/internal/csv/CSVParserTest.java: ## @@ -330,8 +330,8 @@ public void testEndOfFileBehaviorCSV() throws Exception { {"world", ""

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #904: SOLR-16246: Introduced pre-filtering in KnnQParser

2022-07-06 Thread GitBox
alessandrobenedetti commented on code in PR #904: URL: https://github.com/apache/solr/pull/904#discussion_r914920701 ## solr/solr-ref-guide/modules/query-guide/pages/dense-vector-search.adoc: ## @@ -279,13 +279,12 @@ The `knn` query parser can be used with filter queries: [IM

[GitHub] [solr] epugh commented on a diff in pull request #932: SOLR-15182: Remove remaining apispec files

2022-07-06 Thread GitBox
epugh commented on code in PR #932: URL: https://github.com/apache/solr/pull/932#discussion_r914923709 ## solr/core/src/java/org/apache/solr/api/ApiBag.java: ## @@ -17,37 +17,14 @@ package org.apache.solr.api; -import static org.apache.solr.client.solrj.SolrRequest.SUPPORTE

[GitHub] [solr] epugh commented on a diff in pull request #932: SOLR-15182: Remove remaining apispec files

2022-07-06 Thread GitBox
epugh commented on code in PR #932: URL: https://github.com/apache/solr/pull/932#discussion_r914927788 ## solr/core/src/java/org/apache/solr/handler/BlobHandler.java: ## @@ -22,6 +22,7 @@ import static org.apache.solr.common.params.CommonParams.SORT; import static org.apache.s

[GitHub] [solr] cpoerschke commented on a diff in pull request #926: SOLR-16223: unused throws identified by IntelliJ (round 2)

2022-07-06 Thread GitBox
cpoerschke commented on code in PR #926: URL: https://github.com/apache/solr/pull/926#discussion_r914923118 ## solr/core/src/test/org/apache/solr/cloud/ForceLeaderTest.java: ## @@ -59,7 +59,7 @@ public static void beforeClassSetup() { @Test @Override @Ignore - public v

[GitHub] [solr] epugh commented on a diff in pull request #929: SOLR-16280: simplify for-loops in tests

2022-07-06 Thread GitBox
epugh commented on code in PR #929: URL: https://github.com/apache/solr/pull/929#discussion_r914938935 ## solr/core/src/test/org/apache/solr/internal/csv/CSVParserTest.java: ## @@ -330,8 +330,8 @@ public void testEndOfFileBehaviorCSV() throws Exception { {"world", ""}

[GitHub] [solr] epugh commented on pull request #920: SOLR-16271: clean up imports (WIP)

2022-07-06 Thread GitBox
epugh commented on PR #920: URL: https://github.com/apache/solr/pull/920#issuecomment-1176328739 I am going to close this branch for now... It's so partial, it's not worth having open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [solr] epugh closed pull request #920: SOLR-16271: clean up imports (WIP)

2022-07-06 Thread GitBox
epugh closed pull request #920: SOLR-16271: clean up imports (WIP) URL: https://github.com/apache/solr/pull/920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [solr] epugh commented on pull request #894: SOLR-16236: Clarify use of GSON jar in jaegertracer-configurator

2022-07-06 Thread GitBox
epugh commented on PR #894: URL: https://github.com/apache/solr/pull/894#issuecomment-1176345947 Can I get a LGTM? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[jira] [Assigned] (SOLR-16236) Clarify use of gson dependency in jaegertracer-configurator

2022-07-06 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-16236: Assignee: Eric Pugh > Clarify use of gson dependency in jaegertracer-configurator > --

[jira] [Commented] (SOLR-16236) Clarify use of gson dependency in jaegertracer-configurator

2022-07-06 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563288#comment-17563288 ] Eric Pugh commented on SOLR-16236: -- consensus is to ship GSON, so updates are for that!

[GitHub] [solr-operator] HoustonPutman closed issue #427: Problems with istio and prometheus

2022-07-06 Thread GitBox
HoustonPutman closed issue #427: Problems with istio and prometheus URL: https://github.com/apache/solr-operator/issues/427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [solr-operator] HoustonPutman merged pull request #453: Add app-protocol for all services

2022-07-06 Thread GitBox
HoustonPutman merged PR #453: URL: https://github.com/apache/solr-operator/pull/453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[jira] [Commented] (SOLR-16236) Clarify use of gson dependency in jaegertracer-configurator

2022-07-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563324#comment-17563324 ] ASF subversion and git services commented on SOLR-16236: Commit 8

[jira] [Resolved] (SOLR-16236) Clarify use of gson dependency in jaegertracer-configurator

2022-07-06 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16236. -- Fix Version/s: 9.1 main (10.0) Resolution: Fixed > Clarify use of gson depend

[jira] [Commented] (SOLR-16236) Clarify use of gson dependency in jaegertracer-configurator

2022-07-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563325#comment-17563325 ] ASF subversion and git services commented on SOLR-16236: Commit 9

[GitHub] [solr] cpoerschke commented on a diff in pull request #929: SOLR-16280: simplify for-loops in tests

2022-07-06 Thread GitBox
cpoerschke commented on code in PR #929: URL: https://github.com/apache/solr/pull/929#discussion_r915025303 ## solr/core/src/test/org/apache/solr/internal/csv/CSVParserTest.java: ## @@ -352,8 +349,8 @@ public void testEmptyLineBehaviourExcel() throws Exception { {""}

[GitHub] [solr] HoustonPutman commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
HoustonPutman commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915031868 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +244,95 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentH

[GitHub] [solr] HoustonPutman commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
HoustonPutman commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915032474 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -326,12 +408,11 @@ public void forciblyRefreshAllClusterStateSlow() throws KeeperExceptio

[GitHub] [solr] epugh merged pull request #894: SOLR-16236: Clarify use of GSON jar in jaegertracer-configurator

2022-07-06 Thread GitBox
epugh merged PR #894: URL: https://github.com/apache/solr/pull/894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org F

[GitHub] [solr] ackepenek commented on a diff in pull request #753: SOLR-16005 added new feature in to schema screen: add new field type

2022-07-06 Thread GitBox
ackepenek commented on code in PR #753: URL: https://github.com/apache/solr/pull/753#discussion_r915036549 ## solr/webapp/web/partials/schema.html: ## @@ -218,10 +218,10 @@ https://solr.apache.org/guide/solr/latest/indexing-guide/schema-api.html#add-a-ne

[GitHub] [solr] HoustonPutman commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
HoustonPutman commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915038151 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +244,90 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentH

[GitHub] [solr] epugh commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type

2022-07-06 Thread GitBox
epugh commented on PR #753: URL: https://github.com/apache/solr/pull/753#issuecomment-1176451785 @janhoy @madrob any last comments? I think this is ready for merging from my perspective ;-).I'd love to merge this tomorrow as @ackepenek has been waiting a while to get this to "done done

[GitHub] [solr] epugh commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type

2022-07-06 Thread GitBox
epugh commented on PR #753: URL: https://github.com/apache/solr/pull/753#issuecomment-1176452054 down tjhe road, we can get rid of the JSON and make it all pure admin gui. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [solr] epugh commented on pull request #923: SOLR-15853 Solr paramset impl (Version 2)

2022-07-06 Thread GitBox
epugh commented on PR #923: URL: https://github.com/apache/solr/pull/923#issuecomment-1176456587 I'd love to get this comitted tomorrow if folks want to review? I'd love a LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Commented] (SOLR-16264) Set versions for all build tools and dependencies in Antora build

2022-07-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563349#comment-17563349 ] ASF subversion and git services commented on SOLR-16264: Commit 6

[jira] [Commented] (SOLR-16276) Review redundant local variables

2022-07-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563353#comment-17563353 ] ASF subversion and git services commented on SOLR-16276: Commit 8

[jira] [Commented] (SOLR-16264) Set versions for all build tools and dependencies in Antora build

2022-07-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563354#comment-17563354 ] ASF subversion and git services commented on SOLR-16264: Commit 1

[GitHub] [solr] HoustonPutman merged pull request #917: SOLR-16264: Set versions for all Antora build tools

2022-07-06 Thread GitBox
HoustonPutman merged PR #917: URL: https://github.com/apache/solr/pull/917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[jira] [Commented] (SOLR-16264) Set versions for all build tools and dependencies in Antora build

2022-07-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563358#comment-17563358 ] ASF subversion and git services commented on SOLR-16264: Commit a

[jira] [Updated] (SOLR-16214) Fix lunr-extension usage in ref-guide build

2022-07-06 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-16214: -- Fix Version/s: 9.0.1 > Fix lunr-extension usage in ref-guide build > --

[jira] [Commented] (SOLR-16221) Solr Jenkins CI - s390x support

2022-07-06 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563359#comment-17563359 ] Uwe Schindler commented on SOLR-16221: -- Hi, I cloned the Lucene job. I will add anot

[jira] [Resolved] (SOLR-16264) Set versions for all build tools and dependencies in Antora build

2022-07-06 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16264. --- Fix Version/s: 9.1 9.0.1 Assignee: Houston Putman Resolutio

[jira] [Commented] (SOLR-16262) Fix Robots headers for old ref guide pages

2022-07-06 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563361#comment-17563361 ] Houston Putman commented on SOLR-16262: --- So currently this does not work. If you te

[jira] [Created] (SOLR-16284) CLONE - Solr Jenkins CI - s390x support

2022-07-06 Thread Uwe Schindler (Jira)
Uwe Schindler created SOLR-16284: Summary: CLONE - Solr Jenkins CI - s390x support Key: SOLR-16284 URL: https://issues.apache.org/jira/browse/SOLR-16284 Project: Solr Issue Type: Wish

[jira] [Updated] (SOLR-16284) Solr Jenkins CI - s390x support

2022-07-06 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated SOLR-16284: - Summary: Solr Jenkins CI - s390x support (was: CLONE - Solr Jenkins CI - s390x support ) > Sol

[jira] [Commented] (SOLR-16284) Solr Jenkins CI - s390x support

2022-07-06 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563375#comment-17563375 ] Uwe Schindler commented on SOLR-16284: -- After LUCENE-10643 is done, I cloned issue t

[jira] [Updated] (SOLR-16284) Solr Jenkins CI - s390x support

2022-07-06 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated SOLR-16284: - Labels: jenkins (was: jenkins solr) > Solr Jenkins CI - s390x support > ---

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915129741 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +244,95 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentHashM

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915129741 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +244,95 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentHashM

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915129741 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +244,95 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentHashM

[jira] [Comment Edited] (SOLR-16284) Solr Jenkins CI - s390x support

2022-07-06 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563375#comment-17563375 ] Uwe Schindler edited comment on SOLR-16284 at 7/6/22 6:25 PM: -

[jira] [Commented] (SOLR-16284) Solr Jenkins CI - s390x support

2022-07-06 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563379#comment-17563379 ] Uwe Schindler commented on SOLR-16284: -- Job for Solr: https://ci-builds.apache.org/j

[GitHub] [solr] madrob commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
madrob commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915138036 ## solr/core/src/test/org/apache/solr/cloud/overseer/ZkStateReaderTest.java: ## @@ -184,16 +195,210 @@ public void testWatchedCollectionCreation() throws Exception { w

[GitHub] [solr] madrob commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
madrob commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915147046 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +244,90 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentHashMap

[GitHub] [solr] cpoerschke commented on a diff in pull request #929: SOLR-16280: simplify for-loops in tests

2022-07-06 Thread GitBox
cpoerschke commented on code in PR #929: URL: https://github.com/apache/solr/pull/929#discussion_r915176340 ## solr/core/src/test/org/apache/solr/internal/csv/CSVParserTest.java: ## @@ -351,9 +348,8 @@ public void testEmptyLineBehaviourExcel() throws Exception { {""}, //

[GitHub] [solr] HoustonPutman commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

2022-07-06 Thread GitBox
HoustonPutman commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r915197971 ## solr/solrj/src/java/org/apache/solr/common/cloud/DigestZkCredentialsProvider.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915236042 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +244,90 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentHashM

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915236042 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +244,90 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentHashM

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915236042 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +244,90 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentHashM

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915236042 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +244,90 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentHashM

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915236042 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +244,90 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentHashM

[GitHub] [solr-operator] huijieliu commented on a diff in pull request #451: Ability to customize default initContainer resources

2022-07-06 Thread GitBox
huijieliu commented on code in PR #451: URL: https://github.com/apache/solr-operator/pull/451#discussion_r915294179 ## controllers/util/solr_util.go: ## @@ -607,12 +615,20 @@ func generateSolrSetupInitContainers(solrCloud *solr.SolrCloud, solrCloudStatus }

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915236042 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +244,90 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentHashM

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915358372 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -540,7 +627,7 @@ private void constructState(Set changedCollections) { log.debug(

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915363090 ## solr/core/src/test/org/apache/solr/cloud/overseer/ZkStateReaderTest.java: ## @@ -29,35 +38,68 @@ import org.apache.solr.cloud.ZkTestServer; import org.apache.solr.comm

[GitHub] [solr] patsonluk commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
patsonluk commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915363420 ## solr/core/src/test/org/apache/solr/cloud/overseer/ZkStateReaderTest.java: ## @@ -184,16 +195,210 @@ public void testWatchedCollectionCreation() throws Exception {

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
sonatype-lift[bot] commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915385252 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -326,12 +432,11 @@ public void forciblyRefreshAllClusterStateSlow() throws KeeperExc

[GitHub] [solr] madrob commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
madrob commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915420568 ## solr/core/src/test/org/apache/solr/cloud/overseer/ZkStateReaderTest.java: ## @@ -29,35 +38,68 @@ import org.apache.solr.cloud.ZkTestServer; import org.apache.solr.common.

[GitHub] [solr] madrob commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
madrob commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915422007 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -540,7 +627,7 @@ private void constructState(Set changedCollections) { log.debug(

[GitHub] [solr] madrob commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
madrob commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915422193 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -549,7 +636,7 @@ private void constructState(Set changedCollections) { log.trace(

[GitHub] [solr] madrob commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

2022-07-06 Thread GitBox
madrob commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915426740 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +245,125 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentHashMap

[jira] [Created] (SOLR-16285) [CVE-2022-33980] Apache Commons Configuration performs variable interpolation, allowing properties to be dynamically evaluated and expanded

2022-07-06 Thread zhao tao (Jira)
zhao tao created SOLR-16285: --- Summary: [CVE-2022-33980] Apache Commons Configuration performs variable interpolation, allowing properties to be dynamically evaluated and expanded Key: SOLR-16285 URL: https://issues.apa

[jira] [Resolved] (SOLR-16285) [CVE-2022-33980] Apache Commons Configuration performs variable interpolation, allowing properties to be dynamically evaluated and expanded

2022-07-06 Thread zhao tao (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhao tao resolved SOLR-16285. - Resolution: Not A Problem > [CVE-2022-33980] Apache Commons Configuration performs variable > interpolat