johgoe commented on PR #453:
URL: https://github.com/apache/solr-operator/pull/453#issuecomment-1175933340
lgfm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
epugh commented on PR #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1176127063
I like how you nested the drop down inside of it! checking it out todya!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/SOLR-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563199#comment-17563199
]
Nayana Thorat commented on SOLR-16221:
--
[~uschindler] Thank you. Please letme know o
epugh commented on code in PR #929:
URL: https://github.com/apache/solr/pull/929#discussion_r914776978
##
solr/core/src/test/org/apache/solr/update/processor/SignatureUpdateProcessorFactoryTest.java:
##
@@ -179,20 +179,20 @@ public void run() {
threads2[i].setName("testTh
epugh commented on PR #929:
URL: https://github.com/apache/solr/pull/929#issuecomment-1176164427
@cpoerschke based on the changes, do you think this is ready?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/SOLR-15781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563238#comment-17563238
]
Jason Gerlowski commented on SOLR-15781:
Following some preliminary discussion on
[
https://issues.apache.org/jira/browse/SOLR-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563240#comment-17563240
]
ASF subversion and git services commented on SOLR-16245:
Commit f
gerlowskija commented on code in PR #932:
URL: https://github.com/apache/solr/pull/932#discussion_r914874464
##
solr/core/src/test/org/apache/solr/handler/admin/V2ApiMappingTest.java:
##
@@ -204,11 +204,12 @@ public String getHttpMethod() {
return queryRequestCaptor.getValu
gerlowskija commented on code in PR #932:
URL: https://github.com/apache/solr/pull/932#discussion_r914878254
##
solr/core/src/java/org/apache/solr/api/ApiBag.java:
##
@@ -17,37 +17,14 @@
package org.apache.solr.api;
-import static org.apache.solr.client.solrj.SolrRequest.SU
alessandrobenedetti merged PR #910:
URL: https://github.com/apache/solr/pull/910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr
gerlowskija commented on code in PR #932:
URL: https://github.com/apache/solr/pull/932#discussion_r914883795
##
solr/core/src/java/org/apache/solr/handler/BlobHandler.java:
##
@@ -22,6 +22,7 @@
import static org.apache.solr.common.params.CommonParams.SORT;
import static org.ap
alessandrobenedetti commented on code in PR #904:
URL: https://github.com/apache/solr/pull/904#discussion_r914902058
##
solr/core/src/java/org/apache/solr/search/QueryUtils.java:
##
@@ -215,4 +221,38 @@ public static Query combineQueryAndFilter(Query
scoreQuery, Query filterQue
alessandrobenedetti commented on code in PR #904:
URL: https://github.com/apache/solr/pull/904#discussion_r914906892
##
solr/core/src/java/org/apache/solr/search/neural/KnnQParser.java:
##
@@ -72,7 +78,41 @@ public Query parse() {
DenseVectorField denseVectorType = (Dense
cpoerschke commented on code in PR #929:
URL: https://github.com/apache/solr/pull/929#discussion_r914909077
##
solr/core/src/test/org/apache/solr/internal/csv/CSVParserTest.java:
##
@@ -330,8 +330,8 @@ public void testEndOfFileBehaviorCSV() throws Exception {
{"world", ""
alessandrobenedetti commented on code in PR #904:
URL: https://github.com/apache/solr/pull/904#discussion_r914920701
##
solr/solr-ref-guide/modules/query-guide/pages/dense-vector-search.adoc:
##
@@ -279,13 +279,12 @@ The `knn` query parser can be used with filter queries:
[IM
epugh commented on code in PR #932:
URL: https://github.com/apache/solr/pull/932#discussion_r914923709
##
solr/core/src/java/org/apache/solr/api/ApiBag.java:
##
@@ -17,37 +17,14 @@
package org.apache.solr.api;
-import static org.apache.solr.client.solrj.SolrRequest.SUPPORTE
epugh commented on code in PR #932:
URL: https://github.com/apache/solr/pull/932#discussion_r914927788
##
solr/core/src/java/org/apache/solr/handler/BlobHandler.java:
##
@@ -22,6 +22,7 @@
import static org.apache.solr.common.params.CommonParams.SORT;
import static org.apache.s
cpoerschke commented on code in PR #926:
URL: https://github.com/apache/solr/pull/926#discussion_r914923118
##
solr/core/src/test/org/apache/solr/cloud/ForceLeaderTest.java:
##
@@ -59,7 +59,7 @@ public static void beforeClassSetup() {
@Test
@Override
@Ignore
- public v
epugh commented on code in PR #929:
URL: https://github.com/apache/solr/pull/929#discussion_r914938935
##
solr/core/src/test/org/apache/solr/internal/csv/CSVParserTest.java:
##
@@ -330,8 +330,8 @@ public void testEndOfFileBehaviorCSV() throws Exception {
{"world", ""}
epugh commented on PR #920:
URL: https://github.com/apache/solr/pull/920#issuecomment-1176328739
I am going to close this branch for now... It's so partial, it's not worth
having open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
epugh closed pull request #920: SOLR-16271: clean up imports (WIP)
URL: https://github.com/apache/solr/pull/920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
epugh commented on PR #894:
URL: https://github.com/apache/solr/pull/894#issuecomment-1176345947
Can I get a LGTM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
[
https://issues.apache.org/jira/browse/SOLR-16236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-16236:
Assignee: Eric Pugh
> Clarify use of gson dependency in jaegertracer-configurator
> --
[
https://issues.apache.org/jira/browse/SOLR-16236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563288#comment-17563288
]
Eric Pugh commented on SOLR-16236:
--
consensus is to ship GSON, so updates are for that!
HoustonPutman closed issue #427: Problems with istio and prometheus
URL: https://github.com/apache/solr-operator/issues/427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
HoustonPutman merged PR #453:
URL: https://github.com/apache/solr-operator/pull/453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
[
https://issues.apache.org/jira/browse/SOLR-16236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563324#comment-17563324
]
ASF subversion and git services commented on SOLR-16236:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-16236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-16236.
--
Fix Version/s: 9.1
main (10.0)
Resolution: Fixed
> Clarify use of gson depend
[
https://issues.apache.org/jira/browse/SOLR-16236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563325#comment-17563325
]
ASF subversion and git services commented on SOLR-16236:
Commit 9
cpoerschke commented on code in PR #929:
URL: https://github.com/apache/solr/pull/929#discussion_r915025303
##
solr/core/src/test/org/apache/solr/internal/csv/CSVParserTest.java:
##
@@ -352,8 +349,8 @@ public void testEmptyLineBehaviourExcel() throws Exception {
{""}
HoustonPutman commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915031868
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -246,6 +244,95 @@ public boolean canBeRemoved() {
}
}
+ /**
+ * A ConcurrentH
HoustonPutman commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915032474
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -326,12 +408,11 @@ public void forciblyRefreshAllClusterStateSlow() throws
KeeperExceptio
epugh merged PR #894:
URL: https://github.com/apache/solr/pull/894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
F
ackepenek commented on code in PR #753:
URL: https://github.com/apache/solr/pull/753#discussion_r915036549
##
solr/webapp/web/partials/schema.html:
##
@@ -218,10 +218,10 @@
https://solr.apache.org/guide/solr/latest/indexing-guide/schema-api.html#add-a-ne
HoustonPutman commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915038151
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -246,6 +244,90 @@ public boolean canBeRemoved() {
}
}
+ /**
+ * A ConcurrentH
epugh commented on PR #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1176451785
@janhoy @madrob any last comments? I think this is ready for merging from
my perspective ;-).I'd love to merge this tomorrow as @ackepenek has been
waiting a while to get this to "done done
epugh commented on PR #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1176452054
down tjhe road, we can get rid of the JSON and make it all pure admin gui.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
epugh commented on PR #923:
URL: https://github.com/apache/solr/pull/923#issuecomment-1176456587
I'd love to get this comitted tomorrow if folks want to review? I'd love a
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
[
https://issues.apache.org/jira/browse/SOLR-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563349#comment-17563349
]
ASF subversion and git services commented on SOLR-16264:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-16276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563353#comment-17563353
]
ASF subversion and git services commented on SOLR-16276:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563354#comment-17563354
]
ASF subversion and git services commented on SOLR-16264:
Commit 1
HoustonPutman merged PR #917:
URL: https://github.com/apache/solr/pull/917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
[
https://issues.apache.org/jira/browse/SOLR-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563358#comment-17563358
]
ASF subversion and git services commented on SOLR-16264:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-16214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman updated SOLR-16214:
--
Fix Version/s: 9.0.1
> Fix lunr-extension usage in ref-guide build
> --
[
https://issues.apache.org/jira/browse/SOLR-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563359#comment-17563359
]
Uwe Schindler commented on SOLR-16221:
--
Hi,
I cloned the Lucene job. I will add anot
[
https://issues.apache.org/jira/browse/SOLR-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-16264.
---
Fix Version/s: 9.1
9.0.1
Assignee: Houston Putman
Resolutio
[
https://issues.apache.org/jira/browse/SOLR-16262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563361#comment-17563361
]
Houston Putman commented on SOLR-16262:
---
So currently this does not work. If you te
Uwe Schindler created SOLR-16284:
Summary: CLONE - Solr Jenkins CI - s390x support
Key: SOLR-16284
URL: https://issues.apache.org/jira/browse/SOLR-16284
Project: Solr
Issue Type: Wish
[
https://issues.apache.org/jira/browse/SOLR-16284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-16284:
-
Summary: Solr Jenkins CI - s390x support (was: CLONE - Solr Jenkins CI -
s390x support )
> Sol
[
https://issues.apache.org/jira/browse/SOLR-16284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563375#comment-17563375
]
Uwe Schindler commented on SOLR-16284:
--
After LUCENE-10643 is done, I cloned issue t
[
https://issues.apache.org/jira/browse/SOLR-16284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-16284:
-
Labels: jenkins (was: jenkins solr)
> Solr Jenkins CI - s390x support
> ---
patsonluk commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915129741
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -246,6 +244,95 @@ public boolean canBeRemoved() {
}
}
+ /**
+ * A ConcurrentHashM
patsonluk commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915129741
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -246,6 +244,95 @@ public boolean canBeRemoved() {
}
}
+ /**
+ * A ConcurrentHashM
patsonluk commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915129741
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -246,6 +244,95 @@ public boolean canBeRemoved() {
}
}
+ /**
+ * A ConcurrentHashM
[
https://issues.apache.org/jira/browse/SOLR-16284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563375#comment-17563375
]
Uwe Schindler edited comment on SOLR-16284 at 7/6/22 6:25 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-16284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563379#comment-17563379
]
Uwe Schindler commented on SOLR-16284:
--
Job for Solr: https://ci-builds.apache.org/j
madrob commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915138036
##
solr/core/src/test/org/apache/solr/cloud/overseer/ZkStateReaderTest.java:
##
@@ -184,16 +195,210 @@ public void testWatchedCollectionCreation() throws
Exception {
w
madrob commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915147046
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -246,6 +244,90 @@ public boolean canBeRemoved() {
}
}
+ /**
+ * A ConcurrentHashMap
cpoerschke commented on code in PR #929:
URL: https://github.com/apache/solr/pull/929#discussion_r915176340
##
solr/core/src/test/org/apache/solr/internal/csv/CSVParserTest.java:
##
@@ -351,9 +348,8 @@ public void testEmptyLineBehaviourExcel() throws Exception {
{""}, //
HoustonPutman commented on code in PR #857:
URL: https://github.com/apache/solr/pull/857#discussion_r915197971
##
solr/solrj/src/java/org/apache/solr/common/cloud/DigestZkCredentialsProvider.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
patsonluk commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915236042
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -246,6 +244,90 @@ public boolean canBeRemoved() {
}
}
+ /**
+ * A ConcurrentHashM
patsonluk commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915236042
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -246,6 +244,90 @@ public boolean canBeRemoved() {
}
}
+ /**
+ * A ConcurrentHashM
patsonluk commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915236042
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -246,6 +244,90 @@ public boolean canBeRemoved() {
}
}
+ /**
+ * A ConcurrentHashM
patsonluk commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915236042
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -246,6 +244,90 @@ public boolean canBeRemoved() {
}
}
+ /**
+ * A ConcurrentHashM
patsonluk commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915236042
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -246,6 +244,90 @@ public boolean canBeRemoved() {
}
}
+ /**
+ * A ConcurrentHashM
huijieliu commented on code in PR #451:
URL: https://github.com/apache/solr-operator/pull/451#discussion_r915294179
##
controllers/util/solr_util.go:
##
@@ -607,12 +615,20 @@ func generateSolrSetupInitContainers(solrCloud
*solr.SolrCloud, solrCloudStatus
}
patsonluk commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915236042
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -246,6 +244,90 @@ public boolean canBeRemoved() {
}
}
+ /**
+ * A ConcurrentHashM
patsonluk commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915358372
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -540,7 +627,7 @@ private void constructState(Set changedCollections)
{
log.debug(
patsonluk commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915363090
##
solr/core/src/test/org/apache/solr/cloud/overseer/ZkStateReaderTest.java:
##
@@ -29,35 +38,68 @@
import org.apache.solr.cloud.ZkTestServer;
import org.apache.solr.comm
patsonluk commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915363420
##
solr/core/src/test/org/apache/solr/cloud/overseer/ZkStateReaderTest.java:
##
@@ -184,16 +195,210 @@ public void testWatchedCollectionCreation() throws
Exception {
sonatype-lift[bot] commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915385252
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -326,12 +432,11 @@ public void forciblyRefreshAllClusterStateSlow() throws
KeeperExc
madrob commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915420568
##
solr/core/src/test/org/apache/solr/cloud/overseer/ZkStateReaderTest.java:
##
@@ -29,35 +38,68 @@
import org.apache.solr.cloud.ZkTestServer;
import org.apache.solr.common.
madrob commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915422007
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -540,7 +627,7 @@ private void constructState(Set changedCollections)
{
log.debug(
madrob commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915422193
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -549,7 +636,7 @@ private void constructState(Set changedCollections)
{
log.trace(
madrob commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915426740
##
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -246,6 +245,125 @@ public boolean canBeRemoved() {
}
}
+ /**
+ * A ConcurrentHashMap
zhao tao created SOLR-16285:
---
Summary: [CVE-2022-33980] Apache Commons Configuration performs
variable interpolation, allowing properties to be dynamically evaluated and
expanded
Key: SOLR-16285
URL: https://issues.apa
[
https://issues.apache.org/jira/browse/SOLR-16285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhao tao resolved SOLR-16285.
-
Resolution: Not A Problem
> [CVE-2022-33980] Apache Commons Configuration performs variable
> interpolat
77 matches
Mail list logo