dsmiley merged PR #3158:
URL: https://github.com/apache/solr/pull/3158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on code in PR #3158:
URL: https://github.com/apache/solr/pull/3158#discussion_r1948247603
##
solr/core/src/java/org/apache/solr/search/facet/FieldUtil.java:
##
@@ -44,27 +48,49 @@ public static SortedDocValues
getSortedDocValues(SolrIndexSearcher searcher, Str
dsmiley commented on code in PR #3158:
URL: https://github.com/apache/solr/pull/3158#discussion_r1948246532
##
solr/core/src/java/org/apache/solr/search/facet/FacetField.java:
##
@@ -139,11 +139,11 @@ public FacetProcessor
createFacetProcessor(FacetContext fcontext) {
// F
mkhludnev commented on code in PR #3158:
URL: https://github.com/apache/solr/pull/3158#discussion_r1948227521
##
solr/core/src/java/org/apache/solr/search/facet/FacetField.java:
##
@@ -139,11 +139,11 @@ public FacetProcessor
createFacetProcessor(FacetContext fcontext) {
//
mkhludnev commented on code in PR #3158:
URL: https://github.com/apache/solr/pull/3158#discussion_r1948229222
##
solr/core/src/java/org/apache/solr/search/facet/FieldUtil.java:
##
@@ -44,27 +48,49 @@ public static SortedDocValues
getSortedDocValues(SolrIndexSearcher searcher, S
dsmiley commented on PR #3158:
URL: https://github.com/apache/solr/pull/3158#issuecomment-2646477023
Looking for additional code review since I contributed to this PR
substantially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
dsmiley commented on code in PR #3158:
URL: https://github.com/apache/solr/pull/3158#discussion_r1945285244
##
solr/CHANGES.txt:
##
@@ -187,6 +187,8 @@ Bug Fixes
* SOLR-17652: Fix a bug that could cause long leader elections to leave PULL
replicas in DOWN state forever. (hos
dsmiley commented on code in PR #3158:
URL: https://github.com/apache/solr/pull/3158#discussion_r1944771535
##
solr/core/src/java/org/apache/solr/search/facet/FacetField.java:
##
@@ -152,7 +152,7 @@ public FacetProcessor
createFacetProcessor(FacetContext fcontext) {
}
thomaswoeckinger commented on code in PR #3158:
URL: https://github.com/apache/solr/pull/3158#discussion_r1944322475
##
solr/core/src/test/org/apache/solr/search/facet/TestJsonFacets.java:
##
@@ -4907,6 +4907,38 @@ public void testQueryJoinBooksAndPages() throws
Exception {
thomaswoeckinger commented on PR #3158:
URL: https://github.com/apache/solr/pull/3158#issuecomment-2639051999
> It's unfortunate we can't check the docValues format, but can we at least
add a comment explaining this. It's a bit confusing just looking at it without
context.
FacetField
dsmiley commented on code in PR #3158:
URL: https://github.com/apache/solr/pull/3158#discussion_r1943824313
##
solr/core/src/test/org/apache/solr/search/facet/TestJsonFacets.java:
##
@@ -4907,6 +4907,38 @@ public void testQueryJoinBooksAndPages() throws
Exception {
thomaswoeckinger commented on PR #3158:
URL: https://github.com/apache/solr/pull/3158#issuecomment-2636198561
@dsmiley @gerlowskija May you know who is responsible for this part of
faceting code, to get a reviewer
--
This is an automated message from the Apache Git Service.
To respond to
thomaswoeckinger commented on PR #3158:
URL: https://github.com/apache/solr/pull/3158#issuecomment-2634739177
@risdenk as your are one of the last commiters in this area, you may have a
look at this PR
--
This is an automated message from the Apache Git Service.
To respond to the message,
13 matches
Mail list logo
