Re: [PR] SOLR-17456: TransactionLog ctor integrity [solr]

2024-11-04 Thread via GitHub
dsmiley merged PR #2762: URL: https://github.com/apache/solr/pull/2762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17456: TransactionLog ctor integrity [solr]

2024-10-29 Thread via GitHub
dsmiley commented on PR #2762: URL: https://github.com/apache/solr/pull/2762#issuecomment-2445631092 I'm going to merge this in a couple days without further review. It's a super simple one. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] SOLR-17456: TransactionLog ctor integrity [solr]

2024-10-14 Thread via GitHub
dsmiley commented on code in PR #2762: URL: https://github.com/apache/solr/pull/2762#discussion_r1800172613 ## solr/core/src/java/org/apache/solr/update/TransactionLog.java: ## @@ -238,9 +240,6 @@ protected TransactionLog( } success = true; - - assert Object