Re: [PR] SOLR-17189 Fix DockMakerTest.testRealisticUnicode [solr]

2024-04-10 Thread via GitHub
dsmiley merged PR #2327: URL: https://github.com/apache/solr/pull/2327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17189 Fix DockMakerTest.testRealisticUnicode [solr]

2024-04-07 Thread via GitHub
dsmiley commented on PR #2327: URL: https://github.com/apache/solr/pull/2327#issuecomment-2041634519 After reading some QuickTheories docs, it seems using an `assume(Predicate)` would be an alternative; less code too. I'll switch it. -- This is an automated message from the Apache Git Se

Re: [PR] SOLR-17189 Fix DockMakerTest.testRealisticUnicode [solr]

2024-03-22 Thread via GitHub
dsmiley commented on PR #2327: URL: https://github.com/apache/solr/pull/2327#issuecomment-2016361123 Okay. For simplicity, let's just remap each whitespace to the first non-whitespace in the chosen block. Or maybe even simpler -- the letter 'X' (hey why not?). Or maybe you might recommen

Re: [PR] SOLR-17189 Fix DockMakerTest.testRealisticUnicode [solr]

2024-03-16 Thread via GitHub
markrmiller commented on PR #2327: URL: https://github.com/apache/solr/pull/2327#issuecomment-2001894989 Realistic is not referring to the characters. The random Unicode character code likely came from Lucene. If there is a regex check that fails in the test, then it’s likely the gene

Re: [PR] SOLR-17189 Fix DockMakerTest.testRealisticUnicode [solr]

2024-03-01 Thread via GitHub
dsmiley commented on PR #2327: URL: https://github.com/apache/solr/pull/2327#issuecomment-1974264126 I wrote a tiny script that loops over the code points here and there are many whitespace chars, including a space char (ASCII digit 32). This and many others are in the first block. @markr