Re: [PR] IOUtils: add back closeQuietly(Closeable) [solr]

2025-02-20 Thread via GitHub
dsmiley merged PR #3199: URL: https://github.com/apache/solr/pull/3199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] IOUtils: add back closeQuietly(Closeable) [solr]

2025-02-20 Thread via GitHub
dsmiley commented on PR #3199: URL: https://github.com/apache/solr/pull/3199#issuecomment-2672660493 Ported to branch_9_8 so that it gets in 9.8.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] IOUtils: add back closeQuietly(Closeable) [solr]

2025-02-19 Thread via GitHub
mkhludnev commented on PR #3199: URL: https://github.com/apache/solr/pull/3199#issuecomment-2670634374 Ok. ~chatting to deepseek~ referring to JLS 15.12.2.5 calms me down a little. Should be fine, since the most specific method will be chosen. -- This is an automated message from the Apa

Re: [PR] IOUtils: add back closeQuietly(Closeable) [solr]

2025-02-19 Thread via GitHub
mkhludnev commented on PR #3199: URL: https://github.com/apache/solr/pull/3199#issuecomment-2670599951 Hm.. couldn't it cause 'unambiguous error'? I mean now we have two methods with (param) overloaded signature, almost all arguments passed into these methods implement both interfaces. Just